From patchwork Fri Oct 27 19:28:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Peter_Gro=C3=9Fe?= X-Patchwork-Id: 5725 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp1072904jah; Fri, 27 Oct 2017 12:28:30 -0700 (PDT) X-Google-Smtp-Source: ABhQp+T6ipPbKzJ/BXf4SMdbR7E1BhXfe01GvHMqVof4+YQrLh9F2X3xwUHlb2kpExmskZW1vAYV X-Received: by 10.28.55.71 with SMTP id e68mr1230962wma.139.1509132510662; Fri, 27 Oct 2017 12:28:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509132510; cv=none; d=google.com; s=arc-20160816; b=tTSs5/pgXjZhY7H2brZF1yyYmrMlRto2occAx9B7q3jrNioFyNS8sW7T5CrXvMMLv7 1YTEQQ0sTuMHgw4av3q3VB0LxcQK/HSjjlDcmuT6eDojEu0h+iPwV+KCcNnLT9LM3Rg2 4jDylXdCNOhWdOPQT1vnLwGDnUojmTtj4cGpRtA3udEEuQOvNzku0Lm769XwR7e/pe22 M7FmALTo+h0kLZNhB5pjvmxTzLRk0mCX9zBr8V4Y+iLDqb/HzYzgCRS7QrZZTdmmbUA5 Of2nxNnKfIdYgKF07LLldJ1Wqk3vKLbb9piroGHiYuopgY/YniWU/2uRBSE3x7vfvcTn jx0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:to:from:date :delivered-to:arc-authentication-results; bh=7TNaq1QzjAFyE2pqHbiOgPEs8r1XX8jKBmgu8zg92qE=; b=VNi//aqSkTJNWvgCis49vEkbtjxRQUgyJcHvNOPVtmtoGqySku6+q8czDqym0YUq/Z s88AXwv/zj6qEfHd+BCqBN+ApnrPcY011iIVvBSSJG5+NYBCfObRhyI0wVFdXJTij3nf 6iCv4ce3Z1f5BtH0S0Xoh6FmvVfutLYA7ROb2FPfk7iw1nv8A5hkFHA9gn1ZX34bEs/q RFyAFHUyRqC7A/FYPj9ILOborpm2NfzuYCuDxo+l6kt4fgi2yw4OUdx8mECFvb7hl0ra 0kgk164t1t6dKxO4v/sVoHFO3WiWYspg+1Be9UChjVJArQr4pH0LXvcR38s7O9n4cLLG gwSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j25si1702968wme.187.2017.10.27.12.28.30; Fri, 27 Oct 2017 12:28:30 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D189F68A451; Fri, 27 Oct 2017 22:28:20 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from james.theweblords.de (james.theweblords.de [217.11.55.87]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 311D268A442 for ; Fri, 27 Oct 2017 22:28:14 +0300 (EEST) Received: (qmail 26156 invoked by uid 210); 27 Oct 2017 19:28:22 -0000 X-Qmail-Scanner-Diagnostics: from wl-r3-120.rz.tu-ilmenau.de (petronios@theweblords.de@wl-r3-120.rz.tu-ilmenau.de) by james (envelope-from , uid 201) with qmail-scanner-2.10st (mhr: 1.0. spamassassin: 3.4.1. perlscan: 2.10st. Clear:RC:1(141.24.16.120):. Processed in 5.061346 secs); 27 Oct 2017 19:28:22 -0000 Received: from wl-r3-120.rz.tu-ilmenau.de (HELO localhost) (petronios@theweblords.de@141.24.16.120) by james.theweblords.de with ESMTPA; 27 Oct 2017 19:28:16 -0000 Date: Fri, 27 Oct 2017 21:28:16 +0200 From: Peter =?UTF-8?B?R3Jvw59l?= To: ffmpeg-devel@ffmpeg.org Message-ID: <20171027212816.3b734f5c@friiks.de> In-Reply-To: References: <20171026155840.16816-1-pegro@friiks.de> <20171026182843.579d6ec5@friiks.de> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Subject: [FFmpeg-devel] DASH manifest conformance (was: Re: [PATCH 0/7] dashenc fixes) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Thu, 26 Oct 2017 18:32:57 +0200 Carl Eugen Hoyos wrote: > 2017-10-26 18:28 GMT+02:00 Peter Große : > > On Thu, 26 Oct 2017 18:07:55 +0200 > > Carl Eugen Hoyos wrote: > > > >> Did you test our dash muxer lately with some validation tool? > >> Errors were reported in the past. > > > > No official validation tool, no. > > The following was mentioned in the past iirc: > http://www-itec.uni-klu.ac.at/dash/?page_id=605 With the attached patch and checking against the current conformance XSD [1] instead of their "Standard XSD", I get a "Your DASH-MPD is VALID" logo. Regards Peter [1] https://github.com/Dash-Industry-Forum/Conformance-and-reference-source/blob/master/conformance/MPDValidator/schemas/DASH-MPD.xsd From 7a731e2d0d1fd9c771b0cc2730a812e84ae9981e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20Gro=C3=9Fe?= Date: Fri, 27 Oct 2017 21:18:47 +0200 Subject: [PATCH 1/1] dashenc: move UTCTiming element to the end of the manifest To: ffmpeg-devel@ffmpeg.org Required by comformance XSD [1]. [1] https://github.com/Dash-Industry-Forum/Conformance-and-reference-source/blob/master/conformance/MPDValidator/schemas/DASH-MPD.xsd --- libavformat/dashenc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index d3b0464d79..8c216a3af8 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -647,8 +647,6 @@ static int write_manifest(AVFormatContext *s, int final) av_free(escaped); } avio_printf(out, "\t\n"); - if (c->utc_timing_url) - avio_printf(out, "\t\n", c->utc_timing_url); if (c->window_size && s->nb_streams > 0 && c->streams[0].nb_segments > 0 && !c->use_template) { OutputStream *os = &c->streams[0]; @@ -666,6 +664,10 @@ static int write_manifest(AVFormatContext *s, int final) return ret; } avio_printf(out, "\t\n"); + + if (c->utc_timing_url) + avio_printf(out, "\t\n", c->utc_timing_url); + avio_printf(out, "\n"); avio_flush(out); ff_format_io_close(s, &out); -- 2.13.6