From patchwork Tue Oct 31 12:16:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Thomas_K=C3=B6ppe?= X-Patchwork-Id: 5785 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp3925641jah; Tue, 31 Oct 2017 05:23:07 -0700 (PDT) X-Google-Smtp-Source: ABhQp+R6mI3fbBJhviZ1rFWc1JtdRYUmlemDTbxCcZevKw3iex27RIO2AmS/p1KIMxBATD6Gu3UM X-Received: by 10.28.15.141 with SMTP id 135mr1750947wmp.74.1509452587261; Tue, 31 Oct 2017 05:23:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509452587; cv=none; d=google.com; s=arc-20160816; b=DFQjBAdabr5Ldhr0AHkJk4eG0MGiQ6TS32PY/uJr1HXeEWtbbI0K1EnxwwRONUTZVe jPVXURaYhcKdEESRWLVwffpERpE9mCEVbRlvcGY5YaercXSmO+uHIkmM3x2i9kJeqkBS HxlfJiSddjW+iU4lDT1XPHrQt7VuaUWgzZX7h3uiGMO8uDdUow4ZpXbRMksP/zbGs6S3 d3XWVFkLyv0i25qk8pKjYaAY8GV9aunmeYv48CHynmca92ONyWgXIb6hFmaix4Jy+1XC +qjbG9o6/Wf7PzHW/Qy5fWkoq8PS7QB1QzpMPf46lmr/sEb4u5pPF7Y1hQfQH0ChWJqs 45ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=yWfm/i7X+y/bI2q3OG/Nh7ie12uXIy2159+HM7Wh9xk=; b=oEIg4Vm8+POJYVcw6mn7cS4RgNS8WZnquJjOUVAuWj0nFw/BYfKvuhR+lUBW+IT3eI hVfeqxjdW0Us0sOntWRzTaaaa/uFEy2/CI86laTZyrTYGFMUmhlbMy191NXm9utNgrsU KflOAEYSQvPHodEWe+z2h7vqLiLZgNOGJv+SI6AOrtMECqu6DEyrKcZBhrPlCr805HdT soDJb8TSm8qvzrvz1AnlaE+5t/r6cmlgp6+GWUiqMQMIMIbxmAMT8JV1bCis2OooQVEv 4lduiisq8jVsOYp67rxvM3vbZmmPPZ8GtHvyDLF3JE+wUqfaIEPGC83bv1MhW+6mhgoH qLEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.s=20161025 header.b=KI/GSugW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id r65si1447542wmg.163.2017.10.31.05.23.06; Tue, 31 Oct 2017 05:23:07 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.s=20161025 header.b=KI/GSugW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 89C44689FFE; Tue, 31 Oct 2017 14:22:55 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A2B9689FA2 for ; Tue, 31 Oct 2017 14:22:50 +0200 (EET) Received: by mail-wm0-f65.google.com with SMTP id s66so22007275wmf.5 for ; Tue, 31 Oct 2017 05:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=g89DIgH7LxF5mQpexRqMcG0/ZIRmpIyim3vurwNIzJY=; b=KI/GSugWE5orBeZBqlXIRh2JgGQ17sNxY+4rHLg64Od0vpGSRBcm14PWA+Z0VuCTUy 9RvmeyH5P7Pe7E2k7gfeiUet/OH7asNVJ+wSZ74O+lapDeW1RqO/ce+ecmcwqLnDUnca +ZpF8mHBogJl5HfKb4gSkOYi3G9PBmzdgb0OJ/uwtEojGk9grN/xn45rr5zxkHAgfnzb 1wtlLup6xL471aUG4aJwQKaE3a/4Kr4YV/7IW9x49UYP70sew5pYlS5vondUBiHxIY2R GyPN1g26cTuSRg9P1ooaLu8mH8MyyE0OF3iaOB5R2oceiZkWHI3FXiNvg553SfRLf0QO 0MVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g89DIgH7LxF5mQpexRqMcG0/ZIRmpIyim3vurwNIzJY=; b=GNWWaDhUEw1jYooqdKOiGYtjpHjZGLz6DWeOAnrSd4+Y46W8o7KeD8FWQWaKaKdtkI gvJnyvxtz6i/QIRx2IRV4r9oE1MSpu9I34IaA7OfG9jxHtKtM0o5vm0EUBR4mC/X2OjH f4GkCcVKCHPQHRMcG3JgfIxcwyauySe9crjhGO/aBSBL8h09kCfQRfNDhsLy6YiXwFUK TgVKngHRiQt9mOECwZG/FADwP52MTQV8K4000cPMMk5y7uuy491njdN02OPb6lmAg6lI +9idLCqx6SwCepmclb9nU69UfXZDqwDtXZGBiXri17vl4Woh3o9mFiJ3vfLdSYNVSTSf yTpg== X-Gm-Message-State: AMCzsaXPORDzNGpABxF4Oe2MR7VPQoWwHFV9tnxahDcfTB/Hee9asszi EPk8pJHxDCXzn5zYxE5V1aoknBxuzWA= X-Received: by 10.28.202.9 with SMTP id a9mr1619865wmg.46.1509452184404; Tue, 31 Oct 2017 05:16:24 -0700 (PDT) Received: from tkoeppe.lon.corp.google.com ([2a00:79e0:d:207:f8e5:a2e3:b8ee:23e8]) by smtp.gmail.com with ESMTPSA id o190sm1608119wmd.32.2017.10.31.05.16.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2017 05:16:23 -0700 (PDT) From: =?UTF-8?q?Thomas=20K=C3=B6ppe?= To: ffmpeg-devel@ffmpeg.org Date: Tue, 31 Oct 2017 12:16:18 +0000 Message-Id: <20171031121618.21297-1-tkoeppe@google.com> X-Mailer: git-send-email 2.15.0.rc2.357.g7e34df9404-goog In-Reply-To: <891adff0-0649-d42b-8b4a-5fc158064aa4@gmail.com> References: <891adff0-0649-d42b-8b4a-5fc158064aa4@gmail.com> Subject: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?UTF-8?q?Thomas=20K=C3=B6ppe?= MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared dead. --- libavcodec/cabac.c | 2 +- libavutil/mem.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cabac.c b/libavcodec/cabac.c index dd2b057c6d..7321b48901 100644 --- a/libavcodec/cabac.c +++ b/libavcodec/cabac.c @@ -32,7 +32,7 @@ #include "cabac.h" #include "cabac_functions.h" -const uint8_t ff_h264_cabac_tables[512 + 4*2*64 + 4*64 + 63] = { +DECLARE_ALIGNED(1, const uint8_t, ff_h264_cabac_tables)[512 + 4*2*64 + 4*64 + 63] = { 9,8,7,7,6,6,6,6,5,5,5,5,5,5,5,5, 4,4,4,4,4,4,4,4,4,4,4,4,4,4,4,4, 3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3, diff --git a/libavutil/mem.h b/libavutil/mem.h index 527cd03191..c4ee11af58 100644 --- a/libavutil/mem.h +++ b/libavutil/mem.h @@ -101,7 +101,7 @@ #define DECLARE_ALIGNED(n,t,v) t __attribute__ ((aligned (FFMIN(n, 16)))) v #define DECLARE_ASM_CONST(n,t,v) static const t av_used __attribute__ ((aligned (FFMIN(n, 16)))) v #elif defined(__GNUC__) || defined(__clang__) - #define DECLARE_ALIGNED(n,t,v) t __attribute__ ((aligned (n))) v + #define DECLARE_ALIGNED(n,t,v) t av_used __attribute__ ((aligned (n))) v #define DECLARE_ASM_CONST(n,t,v) static const t av_used __attribute__ ((aligned (n))) v #elif defined(_MSC_VER) #define DECLARE_ALIGNED(n,t,v) __declspec(align(n)) t v