From patchwork Tue Oct 31 19:17:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 5794 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp4379147jah; Tue, 31 Oct 2017 12:17:48 -0700 (PDT) X-Google-Smtp-Source: ABhQp+Rn80UFzotydbCD+n+WSQi1ExjxXn1uaWfboZQ3D/4luZjEilotjrM4zW7Pid3ngtpAMV6z X-Received: by 10.28.24.70 with SMTP id 67mr2551629wmy.7.1509477468817; Tue, 31 Oct 2017 12:17:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509477468; cv=none; d=google.com; s=arc-20160816; b=mMLSrhktfx/2Cf2ag+cP+PfTey3BE2IUVz6WizjH0IgyrSHqNthTGEOxwT2fq48JhW 4UUVeJdlkPSVmYTeTEpMyA3RLdsd9xVM6f1cnbLFq+2NWoCdd9Ih7t8Z7BPpgUavkqkL d/NrORw1l+QPDfG5tClPZqN2DZ713O9eEKo4SP/nnz9pilsG5VeSC0lrrBoi8vTTNw6s Z1PNvM7ElStBG43ICP+sUaJSxIGQhDCENN6QPesRewrkmKWXVXYiZb8sNYggLYNH2uJS pbLrPo0YDua2bMwwi+8FlWff+BfLVTfywAe/pHKg6C59G2+Ws7aiAGxSahi+wSUfATd1 fKOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=zUCePHk+aCOGdH46yL/eEjbhoPPRjgoV7uukE4LHykU=; b=IorfW421TEzoS6uquhaE0G98xl+dOXVXn3UlZfiw6fMoKGKDsGb8gH4idiJHh0FLeM MV/YQ2z7aOC1xLYlistAnMB1VqGDNiS0pkCmNxDMWRLXwqpaSJ37wT4Y/eIZjZLRBHRQ EZSG9xOW6TW3zUl1IW+ToGhWayLxKOogy4m2evSszfej/T0QMrtmFTr9bdG8U4cBaxpE ultpR6c5oJg/3DVsuKuH90vtdSDW+0G2ry4IKLojCBK6yYzQroQ0t9G2X8uL2WsuI1To fp1HpakYmakabpyUxr4BT+3VxPQkZ/wp06OGfmOb+wy104Fa+qXdLJQckj8eHwlEVxyi 7ojg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g68si2190013wmc.138.2017.10.31.12.17.46; Tue, 31 Oct 2017 12:17:48 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB68A689B88; Tue, 31 Oct 2017 21:17:34 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 74D85689B3A for ; Tue, 31 Oct 2017 21:17:28 +0200 (EET) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id EF3B21720B1 for ; Tue, 31 Oct 2017 20:17:37 +0100 (CET) Date: Tue, 31 Oct 2017 20:17:00 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20171031191700.GW6009@nb4> References: <20171031034706.8952-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20171031034706.8952-1-jamrial@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dca: return standard error codes in avpriv_dca_parse_core_frame_header() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Tue, Oct 31, 2017 at 12:47:06AM -0300, James Almer wrote: > This prevents making the DCAParseError enum part of the ABI. > > Signed-off-by: James Almer > --- > libavcodec/dca.c | 11 ++++++++--- > libavcodec/dca.h | 12 ++++++++++-- > 2 files changed, 18 insertions(+), 5 deletions(-) this changes fate Test dca-xll_51_16_192_768_1 failed. Look at tests/data/fate/dca-xll_51_16_192_768_1.err for details. make: *** [fate-dca-xll_51_16_192_768_1] Error 1 [...] --- ./tests/ref/fate/dca-xll_51_16_192_768_1-dmix_2 2017-10-31 19:40:15.168912721 +0100 +++ tests/data/fate/dca-xll_51_16_192_768_1-dmix_2 2017-10-31 20:11:48.964935305 +0100 @@ -12,5 +12,5 @@ 0, 2048, 2048, 2048, 8192, c8ca1cff44674809d464ec39cf1bd1e9 0, 4096, 4096, 2048, 8192, d67d26915ca86554568aac685c9a6dc3 0, 6144, 6144, 2048, 8192, 8fdf69fdac9985ac4f9470a7b8e8529d -0, 8192, 8192, 2048, 8192, dc8a9ca39b38c98147f2308f985ff648 -0, 10240, 10240, 2048, 8192, ea13b97373762ab16d0f664013fdc962 +0, 8191, 8191, 2048, 8192, dc8a9ca39b38c98147f2308f985ff648 +0, 10239, 10239, 2048, 8192, ea13b97373762ab16d0f664013fdc96