From patchwork Thu Nov 9 20:22:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 5945 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp2493695jah; Thu, 9 Nov 2017 12:23:09 -0800 (PST) X-Google-Smtp-Source: AGs4zMbMnWJAKW/fSg+OyJChmAbLrwFU1qnRl1q/2J56qAG3auKxWqItKzxEGq+MSl1e2Gyc/Mkq X-Received: by 10.28.175.132 with SMTP id y126mr758740wme.20.1510258989546; Thu, 09 Nov 2017 12:23:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510258989; cv=none; d=google.com; s=arc-20160816; b=Uk8WALN62pI5pyouGpFZhHqSnqmqITXR82JeEY3MM2gFDgARFn6c7cI2fhu0p6W9Yp fZ61bp0SXtfKomHfxuKBFT03V52/CS89gBR8kjGpZ6G33Ax/HzhmK+DiV4onwhtFuJoU terWcdjs00TcJGuVV2BTINzOUn4T+L9/3OHEuJIsfWx6sn9Ov6qrEjirL6E8FwjtVxec kLqQDQWQdeKhALY74oTnZR/qHdW5Sb3S9tnqHgHhGqiPJWUzKNs6P4TFttPyJxLBzmWP prk1Gz1ih9i1OCRg7Y5AYTP9ytylYl0SsOLAkJ1Gaf4Gu97FPwM5kD+uuvj6zTvf0sxR 0k3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=dBbx7rei98A1wjiPnTAIrvZ72pGlc0z5/CpQtkciUv4=; b=NvcH7OD0JxRm7pD1u+4g++QjZEoVML7qF+W6trfaxJ0QaNQamqdO80WUDpDfxLeAdI qi3k5gjOyI2vNHgphvWsJDhWfP/eSjowkLlcyeTUQvHnqpj9sEpfPQNX7+TXQ8EyK8hI 8M0zwqT20LKpE9WtCyxZtPRCTMO7tvb0bj9B9e3qQczozQmhzbVy8f+tn1N1wrlagHWR ofcr3IQQMvJKfexLHzRjRgTK4GtfFYaBimPFCvKSSlPt/tCFIMl/lw1dl5/xyPrrXmYW 0HycIPAx1Qos+krjn6rcYpeJQtNjYQ1c79R3cLrg7fWNqdoXLuVx2Tni5hze2fFILNgf SXNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h196si1287872wmg.157.2017.11.09.12.23.08; Thu, 09 Nov 2017 12:23:09 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A2E17689E16; Thu, 9 Nov 2017 22:22:54 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1C225689B62 for ; Thu, 9 Nov 2017 22:22:48 +0200 (EET) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0DC91C5A60 for ; Thu, 9 Nov 2017 21:23:00 +0100 (CET) Date: Thu, 9 Nov 2017 21:22:11 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20171109202211.GT6009@nb4> References: <20171109001346.8458-1-isasi@google.com> MIME-Version: 1.0 In-Reply-To: <20171109001346.8458-1-isasi@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Wed, Nov 08, 2017 at 04:13:46PM -0800, Sasi Inguva wrote: > Partially fixes t/6699. > --- > libavformat/mov.c | 32 ++++++++++++++++++++----------- > tests/fate/mov.mak | 4 ++++ > tests/ref/fate/mov-elst-ends-betn-b-and-i | 31 ++++++++++++++++++++++++++++++ > 3 files changed, 56 insertions(+), 11 deletions(-) > create mode 100644 tests/ref/fate/mov-elst-ends-betn-b-and-i seems not passing fate here or i did something silly Test mov-elst-ends-betn-b-and-i failed. Look at tests/data/fate/mov-elst-ends-betn-b-and-i.err for details. make: *** [fate-mov-elst-ends-betn-b-and-i] Error 1 [...] --- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..." --- ./tests/ref/fate/mov-elst-ends-betn-b-and-i 2017-11-09 21:14:14.425558802 +0100 +++ tests/data/fate/mov-elst-ends-betn-b-and-i 2017-11-09 21:21:15.957563829 +0100 @@ -7,25 +7,27 @@ #dimensions 0: 320x240 #sar 0: 1/1 #stream#, dts, pts, duration, size, hash -0, 0, 0, 1, 115200, 4e5dc2b806e394cd666c968f736fecd0 -0, 1, 1, 1, 115200, 7a3c7473d44c5f60c07655f6fc0c2ac3 -0, 2, 2, 1, 115200, 038254422a603a3270c09cdcd149707b -0, 3, 3, 1, 115200, 7553b6b4547cb23ef8f0392ed5a5d4b0 -0, 4, 4, 1, 115200, 6d017ede7f446124af7308667cb0dc41 -0, 5, 5, 1, 115200, 77752f0288ae64f857732b8e62e47457 -0, 6, 6, 1, 115200, d656833951af99330625f7c6de7685c4 -0, 7, 7, 1, 115200, 14338b833e431e566ac98da841600bfe -0, 8, 8, 1, 115200, 07ea95d1659f3c4424a470a546d0df6e -0, 9, 9, 1, 115200, fd05b8cc83072f813e89d394d1f6efc6 -0, 10, 10, 1, 115200, 750b82ca5c7e901545e7b1aa69692426 -0, 11, 11, 1, 115200, 7347679ab09bc936047368b8caebcaff -0, 12, 12, 1, 115200, 63a23fdd57ac8462b9ffbcb12ab717b3 -0, 13, 13, 1, 115200, 705257a1c99693db233e2a3ee027adcf -0, 14, 14, 1, 115200, df861a2ec7a4ef70e82b1c28025e5a48 -0, 15, 15, 1, 115200, 2a8b403c077b6b43aa71eaf7d1537713 -0, 16, 16, 1, 115200, 973b5cd3ce473e3970dfa96045553172 -0, 17, 17, 1, 115200, fc612c0afeae3b6576b5ee2f3f119832 -0, 18, 18, 1, 115200, 97074fe5a0b6e7e8470729654092e56c -0, 19, 19, 1, 115200, 8cf9337201065335b3aa4da21dc9b37a -0, 20, 20, 1, 115200, 93ff3589294cc0673af3daee1e7fe42a -0, 21, 21, 1, 115200, c0b6fd870a022f374f9d6c697e8e293d +0, 0, 0, 1, 115200, e10741e5457e9326d5e992e6c05c3e32 +0, 1, 1, 1, 115200, 7e20f8729b6b53dc11791927bf4a5aec +0, 2, 2, 1, 115200, 4e5dc2b806e394cd666c968f736fecd0 +0, 3, 3, 1, 115200, 7a3c7473d44c5f60c07655f6fc0c2ac3 +0, 4, 4, 1, 115200, 038254422a603a3270c09cdcd149707b +0, 5, 5, 1, 115200, 7553b6b4547cb23ef8f0392ed5a5d4b0 +0, 6, 6, 1, 115200, 6d017ede7f446124af7308667cb0dc41 +0, 7, 7, 1, 115200, 77752f0288ae64f857732b8e62e47457 +0, 8, 8, 1, 115200, d656833951af99330625f7c6de7685c4 +0, 9, 9, 1, 115200, 14338b833e431e566ac98da841600bfe +0, 10, 10, 1, 115200, 07ea95d1659f3c4424a470a546d0df6e +0, 11, 11, 1, 115200, fd05b8cc83072f813e89d394d1f6efc6 +0, 12, 12, 1, 115200, 750b82ca5c7e901545e7b1aa69692426 +0, 13, 13, 1, 115200, 7347679ab09bc936047368b8caebcaff +0, 14, 14, 1, 115200, 63a23fdd57ac8462b9ffbcb12ab717b3 +0, 15, 15, 1, 115200, 705257a1c99693db233e2a3ee027adcf +0, 16, 16, 1, 115200, df861a2ec7a4ef70e82b1c28025e5a48 +0, 17, 17, 1, 115200, 2a8b403c077b6b43aa71eaf7d1537713 +0, 18, 18, 1, 115200, 973b5cd3ce473e3970dfa96045553172 +0, 19, 19, 1, 115200, fc612c0afeae3b6576b5ee2f3f119832 +0, 20, 20, 1, 115200, 97074fe5a0b6e7e8470729654092e56c +0, 21, 21, 1, 115200, 8cf9337201065335b3aa4da21dc9b37a +0, 22, 22, 1, 115200, 93ff3589294cc0673af3daee1e7fe42a +0, 23, 23, 1, 115200, c0b6fd870a022f374f9d6c697e8e293d