diff mbox

[FFmpeg-devel] Add DECLARE_ASM_ALIGNED macro for DJGPP architecture.

Message ID 20171114182649.2687-1-tkoeppe@google.com
State Accepted
Commit 53c492640c6b4690715793372454194379093d21
Headers show

Commit Message

Thomas Köppe Nov. 14, 2017, 6:26 p.m. UTC 
The macro was added in 43171a2a738f5114768d34a7278e56e5fde714bc, but I forgot to add it to the DJGPP architecture in that change.
---
 libavutil/mem.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Niedermayer Dec. 2, 2017, 4:04 p.m. UTC | #1 
On Tue, Nov 14, 2017 at 06:26:49PM +0000, Thomas Köppe wrote:
> The macro was added in 43171a2a738f5114768d34a7278e56e5fde714bc, but I forgot to add it to the DJGPP architecture in that change.
> ---
>  libavutil/mem.h | 1 +
>  1 file changed, 1 insertion(+)

will apply unless someone else is faster

thx

[...]
Thomas Köppe Jan. 2, 2018, 1:59 p.m. UTC | #2 
Hello,

Friendly ping, can I interest you in this patch? It seems like it fixes an
oversight that would be annoying for anyone trying to build FFMPEG for
DJGPP.

Thanks!

On 14 November 2017 at 18:26, Thomas Köppe <tkoeppe@google.com> wrote:

> The macro was added in 43171a2a738f5114768d34a7278e56e5fde714bc, but I
> forgot to add it to the DJGPP architecture in that change.
> ---
>  libavutil/mem.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavutil/mem.h b/libavutil/mem.h
> index 9e344bd2c3..7e0b12a8a7 100644
> --- a/libavutil/mem.h
> +++ b/libavutil/mem.h
> @@ -106,6 +106,7 @@
>      #define DECLARE_ASM_CONST(n,t,v)    const t __attribute__ ((aligned
> (n))) v
>  #elif defined(__DJGPP__)
>      #define DECLARE_ALIGNED(n,t,v)      t __attribute__ ((aligned
> (FFMIN(n, 16)))) v
> +    #define DECLARE_ASM_ALIGNED(n,t,v)  t av_used __attribute__ ((aligned
> (FFMIN(n, 16)))) v
>      #define DECLARE_ASM_CONST(n,t,v)    static const t av_used
> __attribute__ ((aligned (FFMIN(n, 16)))) v
>  #elif defined(__GNUC__) || defined(__clang__)
>      #define DECLARE_ALIGNED(n,t,v)      t __attribute__ ((aligned (n))) v
> --
> 2.15.0.448.gf294e3d99a-goog
>
>
James Almer Jan. 2, 2018, 2:08 p.m. UTC | #3 
On 1/2/2018 10:59 AM, Thomas Köppe wrote:
> Hello,
> 
> Friendly ping, can I interest you in this patch? It seems like it fixes an
> oversight that would be annoying for anyone trying to build FFMPEG for
> DJGPP.
> 
> Thanks!

This seems to have been applied already. See commit
53c492640c6b4690715793372454194379093d21
Thomas Köppe Jan. 2, 2018, 2:10 p.m. UTC | #4 
Oh, very true, I must have missed that -- thank you!

On 2 January 2018 at 14:08, James Almer <jamrial@gmail.com> wrote:

> On 1/2/2018 10:59 AM, Thomas Köppe wrote:
> > Hello,
> >
> > Friendly ping, can I interest you in this patch? It seems like it fixes
> an
> > oversight that would be annoying for anyone trying to build FFMPEG for
> > DJGPP.
> >
> > Thanks!
>
> This seems to have been applied already. See commit
> 53c492640c6b4690715793372454194379093d21
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
diff mbox

Patch

diff --git a/libavutil/mem.h b/libavutil/mem.h
index 9e344bd2c3..7e0b12a8a7 100644
--- a/libavutil/mem.h
+++ b/libavutil/mem.h
@@ -106,6 +106,7 @@ 
     #define DECLARE_ASM_CONST(n,t,v)    const t __attribute__ ((aligned (n))) v
 #elif defined(__DJGPP__)
     #define DECLARE_ALIGNED(n,t,v)      t __attribute__ ((aligned (FFMIN(n, 16)))) v
+    #define DECLARE_ASM_ALIGNED(n,t,v)  t av_used __attribute__ ((aligned (FFMIN(n, 16)))) v
     #define DECLARE_ASM_CONST(n,t,v)    static const t av_used __attribute__ ((aligned (FFMIN(n, 16)))) v
 #elif defined(__GNUC__) || defined(__clang__)
     #define DECLARE_ALIGNED(n,t,v)      t __attribute__ ((aligned (n))) v