Message ID | 20171115074417.25367-1-lq@chinaffmpeg.org |
---|---|
State | Accepted |
Commit | a30085f5708f16fcf2d133a2120ddf50d8f59c44 |
Headers | show |
On Wed, Nov 15, 2017 at 03:44:17PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu <lq@chinaffmpeg.org> > --- > libavformat/mp3dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM [...]
2017-11-16 22:58 GMT+08:00 Michael Niedermayer <michael@niedermayer.cc>: > On Wed, Nov 15, 2017 at 03:44:17PM +0800, Steven Liu wrote: >> Signed-off-by: Steven Liu <lq@chinaffmpeg.org> >> --- >> libavformat/mp3dec.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > LGTM > Pushed Thx > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User > questions about the command line tools should be sent to the ffmpeg-user ML. > And questions about how to use libav* should be sent to the libav-user ML. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >
diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index a5c4f2ea12..a76fe32e59 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -508,9 +508,9 @@ static int64_t mp3_sync(AVFormatContext *s, int64_t target_pos, int flags) return AVERROR(EINVAL); } } - if ((target_pos - pos)*dir <= 0 && abs(MIN_VALID/2-j) < score) { + if ((target_pos - pos)*dir <= 0 && FFABS(MIN_VALID/2-j) < score) { candidate = pos; - score = abs(MIN_VALID/2-j); + score = FFABS(MIN_VALID/2-j); } pos += ret; }
Signed-off-by: Steven Liu <lq@chinaffmpeg.org> --- libavformat/mp3dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)