diff mbox

[FFmpeg-devel,1/6] decklink: Fix case where return value wasn't being set before checked for errors

Message ID 20171116183417.93073-2-dheitmueller@ltnglobal.com
State New
Headers show

Commit Message

Devin Heitmueller Nov. 16, 2017, 6:34 p.m. UTC 
I missed an assignement which cauesd the error case to not ever be properly
checked.

Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
---
 libavdevice/decklink_enc.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Derek Buitenhuis Nov. 17, 2017, 12:07 a.m. UTC | #1 
On 11/16/2017 6:34 PM, Devin Heitmueller wrote:
> I missed an assignement which cauesd the error case to not ever be properly
> checked.
> 
> Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
> ---
>  libavdevice/decklink_enc.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM.

- Derek
diff mbox

Patch

diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp
index 070bfad..1fb986e 100644
--- a/libavdevice/decklink_enc.cpp
+++ b/libavdevice/decklink_enc.cpp
@@ -300,7 +300,7 @@  static int decklink_construct_vanc(AVFormatContext *avctx, struct decklink_ctx *
         if (ret != 0)
             return AVERROR(ENOMEM);
 
-        klvanc_set_framerate_EIA_708B(pkt, ctx->bmd_tb_num, ctx->bmd_tb_den);
+        ret = klvanc_set_framerate_EIA_708B(pkt, ctx->bmd_tb_num, ctx->bmd_tb_den);
         if (ret != 0) {
             av_log(avctx, AV_LOG_ERROR, "Invalid framerate specified: %lld/%lld\n",
                    ctx->bmd_tb_num, ctx->bmd_tb_den);