| Message ID | 20171207193013.90747-1-modmaker@google.com |
|---|---|
| State | Accepted |
| Commit | b38f222165f97af19f5bfc2c3e9217b5d1b25cfb |
| Headers | show |
On Thu, Dec 07, 2017 at 11:30:13AM -0800, Jacob Trimble wrote: > The opus.c file uses variables that are defined in opustab.c. The > opus parser needs to include that file to avoid linker errors when > not including the opus encoder/decoder. please list the symbols needed or the error message in the commmit message, so the reader knows about which symbols this is thx [...]
diff --git a/libavcodec/Makefile b/libavcodec/Makefile index ab7893f560..ca72138c02 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1005,7 +1005,7 @@ OBJS-$(CONFIG_PNG_PARSER) += png_parser.o OBJS-$(CONFIG_MPEGAUDIO_PARSER) += mpegaudio_parser.o OBJS-$(CONFIG_MPEGVIDEO_PARSER) += mpegvideo_parser.o \ mpeg12.o mpeg12data.o -OBJS-$(CONFIG_OPUS_PARSER) += opus_parser.o opus.o vorbis_data.o +OBJS-$(CONFIG_OPUS_PARSER) += opus_parser.o opus.o opustab.o vorbis_data.o OBJS-$(CONFIG_PNG_PARSER) += png_parser.o OBJS-$(CONFIG_PNM_PARSER) += pnm_parser.o pnm.o OBJS-$(CONFIG_RV30_PARSER) += rv34_parser.o
The opus.c file uses variables that are defined in opustab.c. The opus parser needs to include that file to avoid linker errors when not including the opus encoder/decoder. Signed-off-by: Jacob Trimble <modmaker@google.com> --- libavcodec/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)