From patchwork Sun Dec 17 21:57:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 6839 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.94 with SMTP id m30csp1999072jah; Sun, 17 Dec 2017 13:58:44 -0800 (PST) X-Google-Smtp-Source: ACJfBoseK5JbcbsAvxvF4Jmcfyyq7B4Ipz6UL1MY8EjNx8v7vDqelEp3b2DQn0Wo1c0wMuDeSj6e X-Received: by 10.28.66.73 with SMTP id p70mr10493199wma.65.1513547924608; Sun, 17 Dec 2017 13:58:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513547924; cv=none; d=google.com; s=arc-20160816; b=OjRz0q97gpH5sf33fR8KUFDOljsO6fyXVg4s+3MW70I1OVXQQveM5MBlfsk1d1WSEm zS5EFk+t2ze2C5zY3t5SWfTBQ4/yW9+RwvimWsKsP1TpXxEF7x8yZNVEoJehSJTQsmhz xhnvSKqZb0J86Z8E6HPta6wFnVHb1XhlZRjsCDASY9wUM6EDR0BrXa3TxV2aYukRKK1I auaBzqSyz0rRnJ8KFwse4ppNer66lP9YW6iCKyFiFYAFrJLwYjZ1arMiVF5RnX6ySXwd 1BaLFLABZhFy2/GntQuys+0xNyRMuUMzdyuKJO98gZZiEHoDmUgvnvOx4tJgWcnBVoyR J0cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=C+ITCL2xeYlHV8WtZIUsn9Ci+G1ZcKJCdxH7uf4wEJ8=; b=HSMyMf0Iey59CrEsUwJ6b1bCzUy4stnZJmzAC5BHMBUa/QIv7e/bNHfQ+4M3IEMTdK WcrU7jc70Oc67Uz5qH4jVjrliyoK+KYX1qnYzmunv3+QTEwSQJSihM3hijEbQOa3gBs8 gHihWDBLEzxRA2eeZOC3KWQ6ZHDAzlDJDXzJg54YR84IGqZ0KOM0mB+HuegeD8lBoZCS mvYCw6JWHWZG+rUfL5ZL7G8dpg0ugPtwCLMoQIr7jznfE8NkDYTPEmxbFp3zfcrwgZo0 yuGv5cD/20p+JXcn8j8AxwUIvJ1GuPbZtMMMxOi/3AgJxJoDUWnKjHjYAbIiP0bJ1IdG Kfdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n3si8516663wra.206.2017.12.17.13.58.44; Sun, 17 Dec 2017 13:58:44 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E5CB3689B54; Sun, 17 Dec 2017 23:58:32 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe02-1.mx.upcmail.net (vie01a-dmta-pe02-1.mx.upcmail.net [62.179.121.157]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE7D1689957 for ; Sun, 17 Dec 2017 23:57:05 +0200 (EET) Received: from [172.31.216.43] (helo=vie01a-pemc-psmtp-pe01) by vie01a-dmta-pe02.mx.upcmail.net with esmtp (Exim 4.88) (envelope-from ) id 1eQgvr-0000JH-Gx for ffmpeg-devel@ffmpeg.org; Sun, 17 Dec 2017 22:57:15 +0100 Received: from localhost ([213.47.41.20]) by vie01a-pemc-psmtp-pe01 with SMTP @ mailcloud.upcmail.net id n9xE1w00a0S5wYM019xF91; Sun, 17 Dec 2017 22:57:15 +0100 X-SourceIP: 213.47.41.20 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 17 Dec 2017 22:57:12 +0100 Message-Id: <20171217215713.20782-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.15.1 X-Mailman-Approved-At: Sun, 17 Dec 2017 23:58:31 +0200 Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Allocate lengthinc and data_start arrays as needed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Decreases memory requirements Fixes: OOM Fixes: 4525/clusterfuzz-testcase-minimized-6400713073623040 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000.c | 3 ++- libavcodec/jpeg2000.h | 4 ++-- libavcodec/jpeg2000dec.c | 7 +++++++ 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/libavcodec/jpeg2000.c b/libavcodec/jpeg2000.c index 5f3965047f..e7f03bd0df 100644 --- a/libavcodec/jpeg2000.c +++ b/libavcodec/jpeg2000.c @@ -359,7 +359,6 @@ static int init_prec(Jpeg2000Band *band, cblk->lblock = 3; cblk->length = 0; - memset(cblk->lengthinc, 0, sizeof(cblk->lengthinc)); cblk->npasses = 0; } @@ -607,6 +606,8 @@ void ff_jpeg2000_cleanup(Jpeg2000Component *comp, Jpeg2000CodingStyle *codsty) Jpeg2000Cblk *cblk = &prec->cblk[cblkno]; av_freep(&cblk->data); av_freep(&cblk->passes); + av_freep(&cblk->lengthinc); + av_freep(&cblk->data_start); } av_freep(&prec->cblk); } diff --git a/libavcodec/jpeg2000.h b/libavcodec/jpeg2000.h index 752feae96b..c429ca5996 100644 --- a/libavcodec/jpeg2000.h +++ b/libavcodec/jpeg2000.h @@ -165,14 +165,14 @@ typedef struct Jpeg2000Cblk { uint8_t ninclpasses; // number coding of passes included in codestream uint8_t nonzerobits; uint16_t length; - uint16_t lengthinc[JPEG2000_MAX_PASSES]; + uint16_t *lengthinc; uint8_t nb_lengthinc; uint8_t lblock; uint8_t *data; size_t data_allocated; int nb_terminations; int nb_terminationsinc; - int data_start[JPEG2000_MAX_PASSES]; + int *data_start; Jpeg2000Pass *passes; int coord[2][2]; // border coordinates {{x0, x1}, {y0, y1}} } Jpeg2000Cblk; // code block diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 0309b1f6fb..a9633fb9d1 100644 --- a/libavcodec/jpeg2000dec.c +++ b/libavcodec/jpeg2000dec.c @@ -949,6 +949,7 @@ static int jpeg2000_decode_packet(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile, for (cblkno = 0; cblkno < nb_code_blocks; cblkno++) { Jpeg2000Cblk *cblk = prec->cblk + cblkno; int incl, newpasses, llen; + void *tmp; if (cblk->npasses) incl = get_bits(s, 1); @@ -988,6 +989,12 @@ static int jpeg2000_decode_packet(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile, cblk->nb_lengthinc = 0; cblk->nb_terminationsinc = 0; + av_free(cblk->lengthinc); + cblk->lengthinc = av_mallocz_array(newpasses , sizeof(*cblk->lengthinc)); + tmp = av_realloc_array(cblk->data_start, cblk->nb_terminations + newpasses + 1, sizeof(*cblk->data_start)); + if (!tmp || !cblk->lengthinc) + return AVERROR(ENOMEM); + cblk->data_start = tmp; do { int newpasses1 = 0;