diff mbox

[FFmpeg-devel,6/6] psmf: add FATE tests

Message ID 20171231094607.68768-7-misty@brew.sh
State Superseded
Headers show

Commit Message

misty@brew.sh Dec. 31, 2017, 9:46 a.m. UTC
From: Misty De Meo <mistydemeo@gmail.com>

---
 tests/Makefile      |  1 +
 tests/fate/psmf.mak | 23 +++++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 tests/fate/psmf.mak

Comments

Michael Niedermayer Dec. 31, 2017, 8:44 p.m. UTC | #1
On Sun, Dec 31, 2017 at 05:46:07PM +0800, misty@brew.sh wrote:
> From: Misty De Meo <mistydemeo@gmail.com>
> 
> ---
>  tests/Makefile      |  1 +
>  tests/fate/psmf.mak | 23 +++++++++++++++++++++++
>  2 files changed, 24 insertions(+)
>  create mode 100644 tests/fate/psmf.mak
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index fd3713fe81..c569091fcb 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -165,6 +165,7 @@ include $(SRC_PATH)/tests/fate/pcm.mak
>  include $(SRC_PATH)/tests/fate/pixlet.mak
>  include $(SRC_PATH)/tests/fate/probe.mak
>  include $(SRC_PATH)/tests/fate/prores.mak
> +include $(SRC_PATH)/tests/fate/psmf.mak
>  include $(SRC_PATH)/tests/fate/qt.mak
>  include $(SRC_PATH)/tests/fate/qtrle.mak
>  include $(SRC_PATH)/tests/fate/real.mak
> diff --git a/tests/fate/psmf.mak b/tests/fate/psmf.mak
> new file mode 100644
> index 0000000000..0d83daad49
> --- /dev/null
> +++ b/tests/fate/psmf.mak
> @@ -0,0 +1,23 @@
> +#
> +# Test detecting ATRAC-3 audio in Sony MPEG files
> +#
> +
> +PROBE_CODEC_NAME_COMMAND = \
> +	ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream=codec_name \
> +	-select_streams a -print_format default=noprint_wrappers=1 -bitexact -v 0
> +
> +FATE_PSMF_FFPROBE = fate-psmf-probe-00006 \
> +					fate-psmf-probe-EV01_01_0500D
> +
> +fate-psmf-probe-00006: SRC = $(TARGET_SAMPLES)/psmf/00006.MPS
> +fate-psmf-probe-00006: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
> +fate-psmf-probe-00006: CMP = oneline
> +fate-psmf-probe-00006: REF = codec_name=atrac3p
> +fate-psmf-probe-EV01_01_0500D: SRC = $(TARGET_SAMPLES)/psmf/EV01_01_0500D.PMF
> +fate-psmf-probe-EV01_01_0500D: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
> +fate-psmf-probe-EV01_01_0500D: CMP = oneline
> +fate-psmf-probe-EV01_01_0500D: REF = codec_name=atrac3p
> +
> +FATE_SAMPLES_FFPROBE += $(FATE_PSMF_FFPROBE)
> +
> +fate-psmf: $(FATE_PSMF_FFPROBE)

This breaks:
fate-mpegts-probe-latm

i guess the PROBE_CODEC_NAME_COMMAND is what is causing this

[...]
misty@brew.sh Jan. 1, 2018, 9:29 a.m. UTC | #2
From: Misty De Meo <mistydemeo@gmail.com>

Haha, that shows me for copy/pasting from the other tests! Adjusted the
name to something PSMF-specific so it doesn't collide; confirmed both
sets of tests pass now. Updated patch included.

Misty De Meo (1):
  psmf: add FATE tests

 tests/Makefile      |  1 +
 tests/fate/psmf.mak | 23 +++++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 tests/fate/psmf.mak
diff mbox

Patch

diff --git a/tests/Makefile b/tests/Makefile
index fd3713fe81..c569091fcb 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -165,6 +165,7 @@  include $(SRC_PATH)/tests/fate/pcm.mak
 include $(SRC_PATH)/tests/fate/pixlet.mak
 include $(SRC_PATH)/tests/fate/probe.mak
 include $(SRC_PATH)/tests/fate/prores.mak
+include $(SRC_PATH)/tests/fate/psmf.mak
 include $(SRC_PATH)/tests/fate/qt.mak
 include $(SRC_PATH)/tests/fate/qtrle.mak
 include $(SRC_PATH)/tests/fate/real.mak
diff --git a/tests/fate/psmf.mak b/tests/fate/psmf.mak
new file mode 100644
index 0000000000..0d83daad49
--- /dev/null
+++ b/tests/fate/psmf.mak
@@ -0,0 +1,23 @@ 
+#
+# Test detecting ATRAC-3 audio in Sony MPEG files
+#
+
+PROBE_CODEC_NAME_COMMAND = \
+	ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream=codec_name \
+	-select_streams a -print_format default=noprint_wrappers=1 -bitexact -v 0
+
+FATE_PSMF_FFPROBE = fate-psmf-probe-00006 \
+					fate-psmf-probe-EV01_01_0500D
+
+fate-psmf-probe-00006: SRC = $(TARGET_SAMPLES)/psmf/00006.MPS
+fate-psmf-probe-00006: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
+fate-psmf-probe-00006: CMP = oneline
+fate-psmf-probe-00006: REF = codec_name=atrac3p
+fate-psmf-probe-EV01_01_0500D: SRC = $(TARGET_SAMPLES)/psmf/EV01_01_0500D.PMF
+fate-psmf-probe-EV01_01_0500D: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
+fate-psmf-probe-EV01_01_0500D: CMP = oneline
+fate-psmf-probe-EV01_01_0500D: REF = codec_name=atrac3p
+
+FATE_SAMPLES_FFPROBE += $(FATE_PSMF_FFPROBE)
+
+fate-psmf: $(FATE_PSMF_FFPROBE)