From patchwork Tue Jan 9 02:41:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Steven X-Patchwork-Id: 7226 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.78.2 with SMTP id r2csp3383204jaa; Mon, 8 Jan 2018 18:42:05 -0800 (PST) X-Google-Smtp-Source: ACJfBotWsPHwCmoYgIgIzU6N2A6N5vKH7iW0XIr+hl3hw3IvV/iHz8r039maFSl94mRbUcuqQw9Q X-Received: by 10.28.45.69 with SMTP id t66mr11000495wmt.120.1515465725837; Mon, 08 Jan 2018 18:42:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515465725; cv=none; d=google.com; s=arc-20160816; b=T/nt55VXdLPrYgZH23IoPqjQNw5kr/BHZdqRTzUGcuqGBKniJ2Lb/j4POMVCfN4S8K ludbpeErkYJnzIw3+E5CUDRu+iynq+4e/OH3vx+srS0k1RV2rSQ0v6ZluY6YQmlT48OM HleAapz4lmUQHp7/ZE86YLmo42tIIYaUZag4WNB5i05QyrMOBWU/pyO3Px0Dg+J7f/f4 LWyngWGkWx3hsIj9vf3Xnkbk8FEAkeT80hURuEJw32LbGm0qatwqZLIFdizR8SByF0Wu ACLLi7DBDanSUusRq/imAvVQFKbWAZ3ii0NKcvevWY8dMnvXbh4Xz0b1geA+7pTfMNHP s6yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:feedback-id:message-id:date:to:from :delivered-to:arc-authentication-results; bh=w73qhYV/tZzmytY/l0BmiGqeVHuvW6twTceI3nqJlQw=; b=Ka5rq+gzkKPTlgIBoykU+gENylGhyM6Y9fSv+VyRixOpQl9LjAftyN7r31jIt/tujF BA8YoobnjiS/LmAzslqRBAsLKxR9yuvkXC5+uJbQDa3zYXT7RF2UEBw15pagWoFe3cNb 7XP5pc6uyUurRPIMTvapWV9gdUqVg/VDugw3B1wriJr8ZPX2t7NB2dz6NhHU6eysW+Bt GI7McvNz6+FBWEBjqQV/5DNjnDF2yKco4ClGuAzJWmxiYirTvNEh0Ld1qkqQZOggWwgI DzzWe9LZ3f1zqEyRdbCBJ3axu6W0HTt2cjTV01fX93nnocy1xNs3eR0EX+Bbo58V9wyS mX4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b135si504311wmg.80.2018.01.08.18.42.04; Mon, 08 Jan 2018 18:42:05 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 39DFA689E53; Tue, 9 Jan 2018 04:42:02 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D5A95689E28 for ; Tue, 9 Jan 2018 04:41:53 +0200 (EET) X-QQ-mid: bizesmtp5t1515465705tvx23s2d6 Received: from localhost (unknown [47.90.47.25]) by esmtp4.qq.com (ESMTP) with id ; Tue, 09 Jan 2018 10:41:45 +0800 (CST) X-QQ-SSF: 01100000004000F0FKF0B00A0000000 X-QQ-FEAT: 3GtnPQ8BMmYESRrguoTXUjZ7meQOoinxZiFGbV0Cvh8JZaGegrQZBi2rsx1aM ASxrxw3ssBiZfNB5glZKr/xPrCA3fqRVeNVfPNz8RgHmUS5RVtwvQVuX68Jqp67vtpeMVlH 3g7cfP47nqL6AHsfnz6jrRaK/zntg+IVHQ3WygdpG0bLBrm5nP/uS4lIHFsXBkLhtGkVeiA DGoXlc7TgIwT/XU2McX6Nywp3fW434iT3H2nAUEVt/w/ExIq4d+p+GIpktIgLwuF7DcmZfN C2juY34J1L6N1hUo3WMocOOBwDtub6+E8Wcg== X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Tue, 9 Jan 2018 10:41:44 +0800 Message-Id: <20180109024144.22709-1-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.10.1.382.ga23ca1b.dirty X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgforeign:qybgforeign4 X-QQ-Bgrelay: 1 Subject: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: add comment into eval_expr X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" comment about the looks like a duplicate line. but that is used to reason x is expressed from y Signed-off-by: Steven Liu --- libavfilter/vf_overlay.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index aa5835ae3a..c6a6ac82f3 100644 --- a/libavfilter/vf_overlay.c +++ b/libavfilter/vf_overlay.c @@ -149,6 +149,7 @@ static void eval_expr(AVFilterContext *ctx) s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, NULL); s->var_values[VAR_Y] = av_expr_eval(s->y_pexpr, s->var_values, NULL); + /* It is necessary if x is expressed from y */ s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, NULL); s->x = normalize_xy(s->var_values[VAR_X], s->hsub); s->y = normalize_xy(s->var_values[VAR_Y], s->vsub);