From patchwork Sun Jan 28 02:21:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rshaffer@tunein.com X-Patchwork-Id: 7433 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.156.27 with SMTP id q27csp2412788jak; Sat, 27 Jan 2018 18:21:54 -0800 (PST) X-Google-Smtp-Source: AH8x226IPvYidLYs2KgYXtFdpYrkFyWENFB9+bLfHlctkrB05QoYk3maBdHnXA6qHpEja1iysDSF X-Received: by 10.28.20.8 with SMTP id 8mr13766227wmu.106.1517106114419; Sat, 27 Jan 2018 18:21:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517106114; cv=none; d=google.com; s=arc-20160816; b=ms5Tsh74NgXkQMZx6zQAk01m3Bm++abIoUk1JWDniFHYkJhFaVQUFBh9ylYiA8KHrZ 6PCGwLxu/YmpMRooCqUH3zM+agvAI3kN3r+eoREe5A1jueo4aPdlyPjmLL3Gk6VrT2B+ OPG0sowykKM4mVe+fD2AYPiPC/wNm2YSU6uKcD5oIFLgE750D9NFKu0ia0jm/SkrExAo j0LptqcWhkV7nPNUoUoEnDIDLsYAjaac39P5Rp4AMP/gzz8xR23kPoBbECnUxZxLCnFf CwS393zVrsF/ECZ+6QnucwzSUX7B9BKlJZdjmrPMhTEGpucI9rHlWo6btzhOyyRed5kI nfeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=gR/CIH92LBVIKgGbqM+NFItkqlE/4v7u5PEDDi3qfVE=; b=h0qUddx5vixeQH5nFEFZBrXaW3+SfagsCcPYDMuR6HYhPN+dl+8nT8FMgC0izo1I6f ScGR79Gzo4SC0kK4BpnhWXqyHYVG5tRZSv0s21jLmzObRGr6HRLBeRY1pGrD5zh+Lymw aIW3ydzL7R/U4lN5bOeVe0dk9H7fBAEN9UL+jnR9MyRXvC5IIWBvmOzDvXW2GweNQHMe GUFdTOXExI1NxhGehGDps8cIOFyMwsGkUQWd9l0eKXbAS859A9MFOzzjGnGFH0NNtc58 SnNdrYVg4KRHtKeKkv0cWaQD+ndPRoLSirgi1F7M+7vz95qKa1SgnIpARfJzqBWYDVAB e+MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@tunein-com.20150623.gappssmtp.com header.s=20150623 header.b=L+j6LfH3; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y14si5079788wme.147.2018.01.27.18.21.53; Sat, 27 Jan 2018 18:21:54 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@tunein-com.20150623.gappssmtp.com header.s=20150623 header.b=L+j6LfH3; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3512E68055B; Sun, 28 Jan 2018 04:21:48 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A49E66800CB for ; Sun, 28 Jan 2018 04:21:40 +0200 (EET) Received: by mail-pf0-f182.google.com with SMTP id c6so2220527pfi.8 for ; Sat, 27 Jan 2018 18:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tunein-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=CQpst4eqME8yCAnckL+MGpRNxnbQ3gCe1d0BNG5r9NQ=; b=L+j6LfH3MWI4E5zEhdivxiid4jTVpPNtpEI8sHoSCyzo9pdPyXfSr3fTRb35kp0YP1 vQMK5KTu2T8kgjkvC+7RDXboo/ePXTIfcExFbfIQAYd73oiJsEkXXS7yN5Tqx22E7ypS 46xSkToq8alqOni+f8RettyHe8Q2oVgG8hsx20a0ZvKjBIBq8M4/gQ5DiS7cK2oUm8GF a0W0B6YPObsT0Ta7v90BqlHIYHzLM7bKucLvLgjzsokOMdt1EjlG5NWPLvi/LHxSIceX oOchY7B5fjYo41MlkJyKgdWuZouhFZosPWlNV1TAg8eXleJamTucwQalQiTqzwVHefC6 r8ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CQpst4eqME8yCAnckL+MGpRNxnbQ3gCe1d0BNG5r9NQ=; b=nYZRx1RHDuaCTCLsqF2r+BTN6z2+esDwNWqlN4r01IJXqN6npzocd1mrxkYcIsP61W f8eaG3r8Fbxr6hdFMdV89P05cHT3ZA8eiyHxKjF1DxjTb9CNOhWFiCFfK9Y2EPodbNRj NrzfYWNMIQRp+mLFa1e71Ep/1EM3ZPNJCE5X241ZlHWuHnV5Dz+8ITr9kbaoOtME0yWi zGXil7mSBnv+AWYAhxoJXwj8KIVSv8kiwNog+px37iJSqFR4HLUusnqxX21Fzn7ls3J2 GDfaKIxZFcqN3ZBl54Z9dnurWGkJFXnb/MTfLeiB5qy9HxmwdDtMOATKlzLcPe65DCI8 S6VQ== X-Gm-Message-State: AKwxytdYGsem6Zm5Ms/o3+r++X+dTK21tBUlqm/H/wIzFu1/U5XnMo/p TObi2CO4E9x2lp3L5US9bwPBO8Bi6jM= X-Received: by 10.99.128.66 with SMTP id j63mr9557314pgd.254.1517106102262; Sat, 27 Jan 2018 18:21:42 -0800 (PST) Received: from jpena-vm.tunein.net ([204.69.221.190]) by smtp.gmail.com with ESMTPSA id 204sm7488881pfu.44.2018.01.27.18.21.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 27 Jan 2018 18:21:41 -0800 (PST) From: rshaffer@tunein.com To: ffmpeg-devel@ffmpeg.org Date: Sat, 27 Jan 2018 18:21:28 -0800 Message-Id: <20180128022128.45594-1-rshaffer@tunein.com> X-Mailer: git-send-email 2.14.3 (Apple Git-98) Subject: [FFmpeg-devel] [PATCH] fate: add id3v2 test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Richard Shaffer MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Richard Shaffer Adds basic unit test for parsing ID3v2 tags. --- This is the second time I'm attempting to send it. Sent it through an email client before, and it seems to have removed the leading white space. tests/Makefile | 1 + tests/fate-run.sh | 4 ++++ tests/fate/id3v2.mak | 6 ++++++ tests/ref/fate/id3v2-read | 5 +++++ 4 files changed, 16 insertions(+) create mode 100644 tests/fate/id3v2.mak create mode 100644 tests/ref/fate/id3v2-read diff --git a/tests/Makefile b/tests/Makefile index 14b9601378..327e3f4420 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -130,6 +130,7 @@ include $(SRC_PATH)/tests/fate/gapless.mak include $(SRC_PATH)/tests/fate/gif.mak include $(SRC_PATH)/tests/fate/h264.mak include $(SRC_PATH)/tests/fate/hevc.mak +include $(SRC_PATH)/tests/fate/id3v2.mak include $(SRC_PATH)/tests/fate/image.mak include $(SRC_PATH)/tests/fate/indeo.mak include $(SRC_PATH)/tests/fate/libavcodec.mak diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 05f4ca5e20..82862b7ef4 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -88,6 +88,10 @@ probefmt(){ run ffprobe${PROGSUF} -show_entries format=format_name -print_format default=nw=1:nk=1 -v 0 "$@" } +probetags(){ + run ffprobe${PROGSUF} -show_entries format_tags -v 0 "$@" +} + runlocal(){ test "${V:-0}" -gt 0 && echo ${base}/"$@" ${base} >&3 ${base}/"$@" ${base} diff --git a/tests/fate/id3v2.mak b/tests/fate/id3v2.mak new file mode 100644 index 0000000000..af60ee12b5 --- /dev/null +++ b/tests/fate/id3v2.mak @@ -0,0 +1,6 @@ +ID3V2_TEST_FILE=tests/data/id3v2-test.mp3 + +FATE_SAMPLES_ID3V2-$(CONFIG_MP3_DEMUXER) += fate-id3v2-read +fate-id3v2-read: CMD = probetags $(TARGET_SAMPLES)/id3v2/id3v2-test.mp3 + +FATE_SAMPLES_FFPROBE += $(FATE_SAMPLES_ID3V2-yes) \ No newline at end of file diff --git a/tests/ref/fate/id3v2-read b/tests/ref/fate/id3v2-read new file mode 100644 index 0000000000..965c8695e8 --- /dev/null +++ b/tests/ref/fate/id3v2-read @@ -0,0 +1,5 @@ +[FORMAT] +TAG:title=id3v2-test +TAG:id3v2_priv.testowner=testdata +TAG:id3v2_priv.testowner2=\x00\x01\x02 +[/FORMAT]