diff mbox

[FFmpeg-devel] lavf/aptxdec: fix the limit on the APTX demuxer definition

Message ID 20180210151123.3931-1-jeebjp@gmail.com
State Accepted
Commit 063be4fe2cc631315fac028b5e5642e451304807
Headers show

Commit Message

Jan Ekström Feb. 10, 2018, 3:11 p.m. UTC 
Fixes breakage with --disable-muxers as it was originally limited
to the muxer, and not the demuxer.
---
 libavformat/aptxdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol Feb. 10, 2018, 4:18 p.m. UTC | #1 
On 2/10/18, Jan Ekstroem <jeebjp@gmail.com> wrote:
> Fixes breakage with --disable-muxers as it was originally limited
> to the muxer, and not the demuxer.
> ---
>  libavformat/aptxdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/aptxdec.c b/libavformat/aptxdec.c
> index 467bc3fd5a..a262cd9ebe 100644
> --- a/libavformat/aptxdec.c
> +++ b/libavformat/aptxdec.c
> @@ -87,7 +87,7 @@ static const AVOption aptx_options[] = {
>      { NULL },
>  };
>
> -#if CONFIG_APTX_MUXER
> +#if CONFIG_APTX_DEMUXER
>  static const AVClass aptx_demuxer_class = {
>      .class_name = "aptx demuxer",
>      .item_name  = av_default_item_name,
> --
> 2.14.3
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

lgtm
Jan Ekström Feb. 10, 2018, 4:21 p.m. UTC | #2 
On Sat, Feb 10, 2018 at 6:18 PM, Paul B Mahol <onemda@gmail.com> wrote:
>
> lgtm
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Cheers, pushed.

Jan
James Almer Feb. 10, 2018, 4:27 p.m. UTC | #3 
On 2/10/2018 1:21 PM, Jan Ekström wrote:
> On Sat, Feb 10, 2018 at 6:18 PM, Paul B Mahol <onemda@gmail.com> wrote:
>>
>> lgtm
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> Cheers, pushed.
> 
> Jan

I know it's a simple fix so in this case it's fine, but keep in mind
Aurelien Jacobs is the maintainer of aptx for future patches.
Jan Ekström Feb. 10, 2018, 4:43 p.m. UTC | #4 
On Sat, Feb 10, 2018 at 6:27 PM, James Almer <jamrial@gmail.com> wrote:
>
> I know it's a simple fix so in this case it's fine, but keep in mind
> Aurelien Jacobs is the maintainer of aptx for future patches.

Yes, if this was less straightforward I would have waited for the maintainer.

Jan
diff mbox

Patch

diff --git a/libavformat/aptxdec.c b/libavformat/aptxdec.c
index 467bc3fd5a..a262cd9ebe 100644
--- a/libavformat/aptxdec.c
+++ b/libavformat/aptxdec.c
@@ -87,7 +87,7 @@  static const AVOption aptx_options[] = {
     { NULL },
 };
 
-#if CONFIG_APTX_MUXER
+#if CONFIG_APTX_DEMUXER
 static const AVClass aptx_demuxer_class = {
     .class_name = "aptx demuxer",
     .item_name  = av_default_item_name,