From patchwork Wed Feb 14 00:54:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 7591 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.150.1 with SMTP id c1csp166273jai; Tue, 13 Feb 2018 16:55:16 -0800 (PST) X-Google-Smtp-Source: AH8x226bvmagxyK8t4IcQ8ZkdsT2z12ViNVE3yPTn3msFkLl2JZa+yVB5Jtp8T/LDpXNaVIyKY5M X-Received: by 10.28.131.210 with SMTP id f201mr2777156wmd.117.1518569716542; Tue, 13 Feb 2018 16:55:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518569716; cv=none; d=google.com; s=arc-20160816; b=Ce86I1+0aFISaS5EFSY6d4ZAV6O+EcGMuxKyVtPQ7CZvsGp+w9+m2Vb6XRTpcpt+nj o2blBDvXIer88U0eWy6YnnmdOH/yJ6wDyRuz16QQsjgtvj1ylQ8FLBzm3EqSxKo5rDiO zwuzw3sZjiv9RAkNYYrcJCsapw+xRsPJt1nrbCFFXkmGL+JZPxwcQpZTQS6Gd32Bn4GY zxWRfLgpCYXxiCIId93QeWzRMfEYQWII5wCYqa/g2dhikw0cavvsBOEZ0JpO8XAucYZw X20THR5EO/Sof3j0JE2PXbftnvq5nLnitE5QIHB8V2tCIDbfCMELY6sxQxpzLqwmCttS goAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=quM2JLs8Aj5pZ0q+zqIC8iTZACUxDZqyn0v4tvEJjm4=; b=Flq3YxZWY0wTcp9J5mj4FwePQLl8414c00E5to8BE0puVH9yK36RciF3pYdtrVyrzS yqmtTfwnt+cRMZwzN+oYCgVxIG1trEgOP/XvhwT1AgPCPgag5T2gAQu5CRhM2LfJKaGG QxgbX4XOuEXXAI2/5bcPLVSK8b1QBaNMGGbrj7t1+Dm1xYXph2HwetkmNxr3oTN2GMkV j8F4Zhuh7bbK/nRZfOS6rIEFQGI/CTrzMDKnjVoVZVTbX1ED4QrMQkHkHsb6kYXqHMkt s80qhwVFQW/1USdw3HiVfRcA/5Uxm349PcNWbncQztgtK23nFrRqdMpMxagkDv+aCpmV jL9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=jEEzt0+z; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x12si5893766wmc.141.2018.02.13.16.55.15; Tue, 13 Feb 2018 16:55:16 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=jEEzt0+z; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 78CD8689E1C; Wed, 14 Feb 2018 02:55:02 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EA25C68925E for ; Wed, 14 Feb 2018 02:54:55 +0200 (EET) Received: by mail-qk0-f195.google.com with SMTP id g2so3713141qkd.12 for ; Tue, 13 Feb 2018 16:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=UdQfgFo/s0vj8Bu+gYsIch7W7omrhNl1FfO2RzF+TGg=; b=jEEzt0+zwH08zdDHTYIz4A37oRUwFs104ZPK772c8vNiW1YrmSutOtXE3iPIO0waU3 mxDTjq3AtzXBPza4YSwOAGdILzNas6TyBj6Is6xsyUkKOVVhn7P8LHCGWqQsk5+N+7kQ OZWcye5NTUbYZyCNIEd3aFlYRnOMpm2OfI31KIC9oRzrfVsduWQSLZ0B+PY2Rp/NhPnP 0kRQ66P5+8F7kCk2befoEH8lNNA/zMUyY133CExwxR3fybrGL9XOq4P02sosS7E0yEyo Yesryxv9OFfxbg6+f5rk7a2HPJp2mvjOr8REEZYzW2e7lnaU5R+v4LDyiHDWPUl4T2fU iSoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=UdQfgFo/s0vj8Bu+gYsIch7W7omrhNl1FfO2RzF+TGg=; b=sB9+q4E9qaZ41o/AJM8F3PmIjsjFvV/zIBa0lhOJWIrVaBVDIuns5+KPlzLODSCE4Q 8HZg79irFqkzptW8IZbtqWi1uywUhFNHn6piq5NlWNkX0fZZ/KYHjxKuGsUCfoURHs6x 6NOxQ0ZKtVKh/tPp11mAU/xZxCO39bOKjvBaFDlPuL6MzAFFvGAbwav7mXbHmzxMDdQE nXCK+X/dntCXQ7Tz7s83Uu5Pj/l0m3DZEvzQT96MBq2Hn3fVCXMCjVp7FeY67FjxrIqI NiYczuS14ZYka/ZY/MAbfLXmVWzAlyg1+tKwghbttZk6qu7Lgpl7XgB3PYW5yFu4mdKv QP2g== X-Gm-Message-State: APf1xPDvN3hHdApDxbouz1z9W+e1oBHCagJ5LlqZOpO2sG9wUKqZJOkj BOrM7+t0mYotbYl9PQWQLSI6PQ== X-Received: by 10.55.97.70 with SMTP id v67mr4999982qkb.159.1518569705920; Tue, 13 Feb 2018 16:55:05 -0800 (PST) Received: from localhost.localdomain ([181.229.225.176]) by smtp.gmail.com with ESMTPSA id 23sm8852063qtx.33.2018.02.13.16.55.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 16:55:05 -0800 (PST) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Tue, 13 Feb 2018 21:54:49 -0300 Message-Id: <20180214005449.42974-1-jamrial@gmail.com> X-Mailer: git-send-email 2.16.1 Subject: [FFmpeg-devel] [PATCH] avformat/aviobuf: initialize all checksum fields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Calling ffio_ensure_seekback() right after initializing an AVIOContext with ffio_init_context() would result in a use of uninitialised value. Fixes fate-adts-id3v2-demux when using valgrind. Signed-off-by: James Almer --- Maybe we should do a memset(s, 0, sizeof(*s)) at the beginning of ffio_init_context() instead, to effectively initialize every field to zero. Which is prefered? libavformat/aviobuf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 86eb6579f4..a5ce9b9bf2 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -106,6 +106,8 @@ int ffio_init_context(AVIOContext *s, s->seekable = seek ? AVIO_SEEKABLE_NORMAL : 0; s->min_packet_size = 0; s->max_packet_size = 0; + s->checksum = 0; + s->checksum_ptr = NULL; s->update_checksum = NULL; s->short_seek_threshold = SHORT_SEEK_THRESHOLD;