From patchwork Wed Feb 28 23:34:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jacobs X-Patchwork-Id: 7770 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.181.170 with SMTP id m39csp4380657jaj; Wed, 28 Feb 2018 15:34:31 -0800 (PST) X-Google-Smtp-Source: AG47ELsJ2oNcFkIOv0dpOX6iQFtgze9gVp2MWw2rC5rqhu4GXN3klzmNPEEakgUQ3WfHY3GELXxr X-Received: by 10.28.43.199 with SMTP id r190mr171688wmr.58.1519860871777; Wed, 28 Feb 2018 15:34:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519860871; cv=none; d=google.com; s=arc-20160816; b=tf1Qo3JfuoEKH5ilKTMIgcQDBQppmeDya5nVIOSSdXjmur0CroKlG/TNVDASMcgF+z OHbjd7BdcCbiZTcUkimTBXsOYMtqdfTH2s3M74d4f/VEHj/Yno/itVWErflq1mCIkyLT r6PM2OzJBV8e1FwIM30h2dbDda8a7ZOdhyNgM3MuFtWf4GO1cJ/EUcrQxlRu9gNX4ceC PA34f56HxUzp4Ftr1Cd9J1Ty6gbbWpgAUK2L3UslhwbhthfqGDxfOc3M0DFPziwRaBYQ MsmmoRAVDOBoxtwnM/t6qCngCVTPTPoDxLLhlT/V9HyP8JKmT+f4uOULMDLouG6cNO3z 3oRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :to:from:date:delivered-to:arc-authentication-results; bh=gRJypi6Ha8YonLEEQydV1OQ2Fb30BoijFyUfjIq/JRg=; b=XX28TcZKT0eWb7brIQyK2d+AX7tkkmoCfhSx+kdgNHTwKiGNWoaw3Tp6ZmHeJ3u9SI 2EJncNOjP+6O6gytPlBk7iWQMtsulEUmSiwcO3IKf2P/EQYrocNUI54eieoqW/pUri3x hVrgYqo8osRJ76hHo1W+7hDXpSVNg7dTMhPO0e0BK5l8MG8oWF1cH9woyNIfLgiJvXgM AwjuhP0bPznns+9R6VOK4Evrw9pjUgOpWjlQBrjDVn4K+dJWZgt0/unzfdAexnzsc+Fb +H2VXGli9L302h74RS+7YBY/khlq8BHSVOOdd1uAZQ3tnaokTeuJqJIc9mlqgLx/AWij 8WmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u42si1940723wrf.112.2018.02.28.15.34.30; Wed, 28 Feb 2018 15:34:31 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0E24568A2AD; Thu, 1 Mar 2018 01:34:24 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [212.27.42.6]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B98A3689C18 for ; Thu, 1 Mar 2018 01:34:17 +0200 (EET) Received: from marge.gnuage.org (unknown [IPv6:2a01:e35:2e26:9790::10]) by smtp6-g21.free.fr (Postfix) with ESMTPS id 70925780304 for ; Thu, 1 Mar 2018 00:34:22 +0100 (CET) Received: from aurel by marge.gnuage.org with local (Exim 4.89) (envelope-from ) id 1erBEr-00052O-JU for ffmpeg-devel@ffmpeg.org; Thu, 01 Mar 2018 00:34:21 +0100 Date: Thu, 1 Mar 2018 00:34:21 +0100 From: Aurelien Jacobs To: FFmpeg development discussions and patches Message-ID: <20180228233421.ej7r4xmk3he2qyj5@gnuage.org> References: <20180221223718.20789-1-aurel@gnuage.org> <20180221223718.20789-6-aurel@gnuage.org> <20180224120155.e6gfqbijsbvukvwy@gnuage.org> <20180227235613.vit3rh2vprgqppaw@gnuage.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: aurel@gnuage.org X-SA-Exim-Scanned: No (on marge.gnuage.org); SAEximRunCond expanded to false Subject: Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Wed, Feb 28, 2018 at 12:59:40AM +0000, Rostislav Pehlivanov wrote: > On 27 February 2018 at 23:56, Aurelien Jacobs wrote: > > > > > So I've updated the patch with only a msbc and a delay option and > > I've added some sane parameters decisions, mainly based on the following > > study : > > https://pdfs.semanticscholar.org/1f19/561d03bc88b67728375566c95bbf77 > > e730d5.pdf > > This seems to give pretty good results. > > > > > I think you ought to use a float for this, like: > > >{ "sbc_delay", "Maximum delay in milliseconds", offsetof(, >