From patchwork Thu Mar 8 03:53:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wm4 X-Patchwork-Id: 7857 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.181.170 with SMTP id m39csp335059jaj; Wed, 7 Mar 2018 19:53:54 -0800 (PST) X-Google-Smtp-Source: AG47ELsw2pimXme9VjD84DM5gqFuSbbgwBaLhqupOgR9CLYslKp4XwsBeJN84cro9Xku7P8W3gvC X-Received: by 10.28.114.6 with SMTP id n6mr15972858wmc.70.1520481234254; Wed, 07 Mar 2018 19:53:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520481234; cv=none; d=google.com; s=arc-20160816; b=HcQJtsI32Jh6/MqhrQPaFhGwb7QQljrVzrzjo8ewMwXT7BEGPPY89ULDgcUvO3orV+ iMV3znXG7IOsbGooDlGcCi47t6cbgG27J4Jwe9EnO54lPrUNvDiFy79dbR9o8FXeg/zF EEO3rzgUTsHBs6uyycVYFXL81IMNdixcllFo2bko0I8LG2O9LhJL52Q2FB1Z6DHfWOZv X2Obl08C7usA70eXrjPoZCzte404pabBuHjLhHavUr7VTrfroyrWZVzR428vb6q7z7sI ML55i8qKGDV8OOpgcSxIxjMlMpoafUzpNYcREtT8OYVrCAHWmtVtIRWoPWNqZcFYGPsP S7gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=lZ+Hs6aSw/vao+/64cf7Vr9PKQ/SeCsiGBY5rXknxNM=; b=LCVUD2NeXL4dzudzz7i4keXgvrxBrmJBuBEchpH65z687nuiea1X4t5Ws0D/bYiw0d nUpsNPsWmyqmRGPiY2HBYjGZMy6oczxhfF22C5UnLtP2NbObdwOhJlNCS8gqvabyor7o gH6VfoS/e4mmZQ2wQemoqz30wbb0tZDSZSY/6y4oSmeNIPiSNJQy0raa2BE6yd5IEOEv 7fzg0KnUvwDs/rUenSm1bZNSHUZSnUM3VFgszgUftQQO1/HFcoGDiC1mGXoieuYSNCxy jlc/ho9smp9yPTrGp4Vl2+oJNeWbKJsXegi2MA3E24yxnvUb5dS8KIW1uDRHcdZOOhq6 wdPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@googlemail.com header.s=20161025 header.b=eBGThP4e; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id t9si6182190wra.272.2018.03.07.19.53.53; Wed, 07 Mar 2018 19:53:54 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@googlemail.com header.s=20161025 header.b=eBGThP4e; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7297E68A563; Thu, 8 Mar 2018 05:53:43 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 86AB868A350 for ; Thu, 8 Mar 2018 05:53:37 +0200 (EET) Received: by mail-wm0-f47.google.com with SMTP id s206so25451356wme.0 for ; Wed, 07 Mar 2018 19:53:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=+luRGMN6XAwWQXlpAz9Vlw7edMqJvMZwKJh3NZbnaUI=; b=eBGThP4e+hg7hvu3yAPB0z3N1g5hHEHCnGqOVphBD2U5ua7FmyqL0miMlmFj6U2aRy rVZv6ybLqxCD5su3+5qESYBmymN3E2XvvYCHy9TscVn8mFW0gA9jcYN9usE0VRAXrIy2 ge7kdZO0B8OABHGkrFZAWB/9+vi4dlC+vHapMnYw6kbmzEivNwNrU9NwIqKYIvMrbTiz oVXNo3l8ufUC0WzMQyJYl9rSQKXk7npULSgEViLZavBp1UhESZigjKdGIWxxO/uCmZ0v 2maxyj+1y+RveYIDZo9vgIncwN4s1+J+TWMwPvy7uQScP5w5/fPpDRFRG8ULJolO7A9o iANw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+luRGMN6XAwWQXlpAz9Vlw7edMqJvMZwKJh3NZbnaUI=; b=QdaCOaj5YfFYGzPGVN4y++zDRuWPuLhuQJqVNLQMuWhDu+Lm8m802YozgCvSebSI7f 5D4W78NlQhYB1ZLLE81aDYj87sF10Xw1EvfPoFmE6lVVQmzAmBGtk+MUC+Dx2NIi0tam UoxuW2cKEwxU08DY5mBVAHv0W+PTpelUAyXNqGCjXBAAqNgW8zQbagRPO3OgBxJOlmNq Oq5reWS1ISB6gVt+dOzzKVOe7iUd88k4Swh/55XUSesYEbSFv5lbAzeEL9jkA4pB8Yf3 7zHZhbg9i/MZMVo5s92r9kFap7tJS4S2Rt4FMvUqs+lUEoyc0gf5cJ/5dzWUAgWSX148 K6XQ== X-Gm-Message-State: AElRT7FfeyeYlY0IKgZFUpUyGrQAjhtDoW4+Ee65R9BfxqhWI0h5cANH AOdGyQx2KAN/cckRyEuQts2h6w== X-Received: by 10.28.180.7 with SMTP id d7mr15317656wmf.132.1520481224808; Wed, 07 Mar 2018 19:53:44 -0800 (PST) Received: from debian.speedport.ip (p2003006CCD4EDC3291DC22650E2BAE5B.dip0.t-ipconnect.de. [2003:6c:cd4e:dc32:91dc:2265:e2b:ae5b]) by smtp.googlemail.com with ESMTPSA id r126sm20027968wmd.29.2018.03.07.19.53.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Mar 2018 19:53:43 -0800 (PST) From: wm4 To: ffmpeg-devel@ffmpeg.org Date: Thu, 8 Mar 2018 04:53:55 +0100 Message-Id: <20180308035357.18138-1-nfxjfg@googlemail.com> X-Mailer: git-send-email 2.16.1 Subject: [FFmpeg-devel] [PATCH 1/3] http: do not print a warning message for expired cookies X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: wm4 MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" libavformat prints a warning that the cookie couldn't be parsed (see callers of parse_cookie()). This is obviously not true - it could be parsed, but was simply ignored. Don't return an error to avoid the warning. --- libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 344fd603cb..d7a72e7129 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -802,7 +802,7 @@ static int parse_cookie(HTTPContext *s, const char *p, AVDictionary **cookies) // if the cookie has already expired ignore it if (av_timegm(&new_tm) < av_gettime() / 1000000) { av_dict_free(&new_params); - return -1; + return 0; } // only replace an older cookie with the same name