diff mbox

[FFmpeg-devel] avcodec/mp3_header_decompress: don't free the user provided packet on error

Message ID 20180319032119.1276-1-jamrial@gmail.com
State Accepted
Commit f18f9734694ea0761f94d57685f342b690d563b0
Headers show

Commit Message

James Almer March 19, 2018, 3:21 a.m. UTC 
It's owned by the caller.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/mp3_header_decompress_bsf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer March 20, 2018, 7:27 p.m. UTC | #1 
On Mon, Mar 19, 2018 at 12:21:19AM -0300, James Almer wrote:
> It's owned by the caller.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/mp3_header_decompress_bsf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

smells correct

thx

[...]
James Almer March 20, 2018, 8:40 p.m. UTC | #2 
On 3/20/2018 4:27 PM, Michael Niedermayer wrote:
> On Mon, Mar 19, 2018 at 12:21:19AM -0300, James Almer wrote:
>> It's owned by the caller.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  libavcodec/mp3_header_decompress_bsf.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> smells correct
> 
> thx

Pushed.
diff mbox

Patch

diff --git a/libavcodec/mp3_header_decompress_bsf.c b/libavcodec/mp3_header_decompress_bsf.c
index 22c1ef0220..294858953c 100644
--- a/libavcodec/mp3_header_decompress_bsf.c
+++ b/libavcodec/mp3_header_decompress_bsf.c
@@ -87,7 +87,7 @@  static int mp3_header_decompress(AVBSFContext *ctx, AVPacket *out)
         goto fail;
     ret = av_packet_copy_props(out, in);
     if (ret < 0) {
-        av_packet_free(&out);
+        av_packet_unref(out);
         goto fail;
     }
     memcpy(out->data + frame_size - buf_size, buf, buf_size + AV_INPUT_BUFFER_PADDING_SIZE);