From patchwork Mon Mar 19 21:11:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Courtland Idstrom X-Patchwork-Id: 8046 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp3114602jad; Mon, 19 Mar 2018 14:17:14 -0700 (PDT) X-Google-Smtp-Source: AG47ELtwQHW1eub25DV0eW7ql0uO7Z+ptiTYU7j4Rki0/N/4HROklVg4Bv5MKEqqCnG1jMBgG+dV X-Received: by 10.28.193.13 with SMTP id r13mr157938wmf.38.1521494234835; Mon, 19 Mar 2018 14:17:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521494234; cv=none; d=google.com; s=arc-20160816; b=beVvvL4h9sY5rrjwYFrNfTFktEx3+HAKVh+OutuPkHGEvGCbrs/yHgfi48fBgf80el 7RQOOFGJ2DR1olcZxGnCeQA7qCOFK7nGhF56oMyDT2DtoWCioIFYL0GoHWauwnPlxHH1 RQzuygbJ1YrKEl3YXIFQ3knmIe/5Nh50acFh6D8XlNxcx8aNtYZpTLyhmRat7Zja1ufw bM/I9RTLmasf/Y2EIe8cmB9CrF5N2jO1s1rWJPvp3iBKC+oaj4HT+Y0cVUA0eJk6H0FW V/5piVNA/ycZgEZKa9HZUA2UXRInIajLeMZ+JH92+1dZ3XXv93Og4aPkBqAn7s9RXhQR qekQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=sS6iOwo/UuoE45mgnmTjZThzZosL4HzlPBiI+wRWSSE=; b=DxISacTQ/p0W7w/HmKQWLfPPmlqltkF9vgjJdJGubFmyBmfkQDNrrGru6KamuFM0R8 JkMRgvlD5T0poaSb3nAVHz1LBwgVIYIEX5ea553YBHbdEgQIdPyyYPk+k/ZLoY3v+05q ClpMhu6ISFhjzeuYATXM2LZzZEAgmRiaLHkGIU2qjMHxYiW2TIC+2VmfrKU7asMzI3VL 4E2q3w/AZElDvkx6rkD9jsqRhdHrrR989hoqWApiBEr/+AE8/Ar/B+qPRtXmJN6E+uuT Ln2aqRwq3IOUSGqb3kkXsR040TTqx9gyWX4gK6gEEcIncXkUpy4lrpgprjjNoVmZ0dFK s9Pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@telltalegames.com header.s=google header.b=el7M7Nrx; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id m30si88847wrm.539.2018.03.19.14.17.14; Mon, 19 Mar 2018 14:17:14 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@telltalegames.com header.s=google header.b=el7M7Nrx; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 401FD680491; Mon, 19 Mar 2018 23:16:58 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8758C680282 for ; Mon, 19 Mar 2018 23:16:51 +0200 (EET) Received: by mail-pl0-f66.google.com with SMTP id u11-v6so7373305plq.1 for ; Mon, 19 Mar 2018 14:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telltalegames.com; s=google; h=from:to:cc:subject:date:message-id; bh=QMuLwzn1MkY03311uCryGfv65NMg05G9WeGObGNlXwk=; b=el7M7NrxcruRLWPV6RHi/2QE7jt1lKwMQxQAGCaaUMDPOU/wCLkkQESEQC6gqMSt0u UG1hQk7Hpj7CmNN7VJZfkz7T2XHwqknLQh6P7kF8P/+/NptTAtMu6s+gXbE9/V8+hknq SPew2s3CtehkTrRHSPQJeMcnso8frXzZwQWv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QMuLwzn1MkY03311uCryGfv65NMg05G9WeGObGNlXwk=; b=jEYAkeinf4Rg8wtEqaL+z/zAsjKntgnOqwjCNBmMNIUJVfMAY3x+YRXl2U4rz9CaPz zzcMgXoLohtro9FhBcH9DTgxd5XvU9P9P8HaPs/nDUKSLjBeTtxeNuFNl8qfOvPIZf05 KCFvEzqDo5+hQgNRACVwpgsHS5kjmiKI4BvBWeqX2jsNS2icZ6jwrWgbIKEZfUL7Kzhj UlZBzFTF8xIJjjsXMdLkZSquIyEhBIzozMw8tbBTFIBiddZEqIRn9zupr2sdINv0l4hg N6fMheGIN2O9YR2rsKJPJkJYYrLE8CRJwDF1FKz2a1+K/AehTMp3mHviQkZAuFs65xZZ 2sQQ== X-Gm-Message-State: AElRT7HJM/42OKKDB/ZcLa71eQ2LucPKU9Z7gztAgIjVzmnR4OLlEzXq fxpIKgsWe9meotuKhGDTuXwppvVh X-Received: by 2002:a17:902:74c5:: with SMTP id f5-v6mr13674127plt.91.1521493915367; Mon, 19 Mar 2018 14:11:55 -0700 (PDT) Received: from localhost.localdomain (76-246-10-223.lightspeed.snmtca.sbcglobal.net. [76.246.10.223]) by smtp.gmail.com with ESMTPSA id e4sm102769pfa.166.2018.03.19.14.11.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Mar 2018 14:11:54 -0700 (PDT) From: Courtland Idstrom To: ffmpeg-devel@ffmpeg.org Date: Mon, 19 Mar 2018 14:11:37 -0700 Message-Id: <20180319211137.45432-1-cidstrom@telltalegames.com> X-Mailer: git-send-email 2.14.3 (Apple Git-98) Subject: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Courtland Idstrom MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Track title (atom 'name') is a well defined user data atom for mov files. Existing code (for mp4) only writes title metadata if present. Relevant reference docs: https://developer.apple.com/library/content/documentation/QuickTime/Reference/QTRef_AtomsResources/Content/QTRef_AtomsResources4.html#//apple_ref/doc/uid/TP40004285-DontLinkChapterID_1--udta- https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFChap2/qtff2.html#//apple_ref/doc/uid/TP40000939-CH204-63839 --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 5b1e66c897..ca15a00265 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -3027,7 +3027,7 @@ static int mov_write_track_udta_tag(AVIOContext *pb, MOVMuxContext *mov, if (ret < 0) return ret; - if (mov->mode & MODE_MP4) + if (mov->mode & (MODE_MP4|MODE_MOV)) mov_write_track_metadata(pb_buf, st, "name", "title"); if ((size = avio_close_dyn_buf(pb_buf, &buf)) > 0) {