diff mbox

[FFmpeg-devel] cmdutils: print supported codecs in show_help_bsf()

Message ID 20180322011127.11668-1-jamrial@gmail.com
State Accepted
Commit ead257db560ae0c66c4e834a743f2148e6718f04
Headers show

Commit Message

James Almer March 22, 2018, 1:11 a.m. UTC
Signed-off-by: James Almer <jamrial@gmail.com>
---
 fftools/cmdutils.c | 2 ++
 fftools/cmdutils.h | 3 +++
 2 files changed, 5 insertions(+)

Comments

Jun Zhao March 22, 2018, 1:57 a.m. UTC | #1
On 2018/3/22 9:11, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  fftools/cmdutils.c | 2 ++
>  fftools/cmdutils.h | 3 +++
>  2 files changed, 5 insertions(+)
>
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 708a849f51..c0ddf0b287 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1907,6 +1907,8 @@ static void show_help_bsf(const char *name)
>      }
>  
>      printf("Bit stream filter %s\n", bsf->name);
> +    PRINT_CODEC_SUPPORTED(bsf, codec_ids, enum AVCodecID, "codecs",
> +                          AV_CODEC_ID_NONE, GET_CODEC_NAME);
>      if (bsf->priv_class)
>          show_help_children(bsf->priv_class, AV_OPT_FLAG_BSF_PARAM);
>  }
> diff --git a/fftools/cmdutils.h b/fftools/cmdutils.h
> index 87244891d4..6e2e0a2acb 100644
> --- a/fftools/cmdutils.h
> +++ b/fftools/cmdutils.h
> @@ -625,6 +625,9 @@ void *grow_array(void *array, int elem_size, int *size, int new_size);
>  #define GET_PIX_FMT_NAME(pix_fmt)\
>      const char *name = av_get_pix_fmt_name(pix_fmt);
>  
> +#define GET_CODEC_NAME(id)\
> +    const char *name = avcodec_descriptor_get(id)->name;
> +
>  #define GET_SAMPLE_FMT_NAME(sample_fmt)\
>      const char *name = av_get_sample_fmt_name(sample_fmt)
>  
LGTM, tested and verified
James Almer March 22, 2018, 3:16 a.m. UTC | #2
On 3/21/2018 10:57 PM, Jun Zhao wrote:
> 
> 
> On 2018/3/22 9:11, James Almer wrote:
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  fftools/cmdutils.c | 2 ++
>>  fftools/cmdutils.h | 3 +++
>>  2 files changed, 5 insertions(+)
>>
>> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
>> index 708a849f51..c0ddf0b287 100644
>> --- a/fftools/cmdutils.c
>> +++ b/fftools/cmdutils.c
>> @@ -1907,6 +1907,8 @@ static void show_help_bsf(const char *name)
>>      }
>>  
>>      printf("Bit stream filter %s\n", bsf->name);
>> +    PRINT_CODEC_SUPPORTED(bsf, codec_ids, enum AVCodecID, "codecs",
>> +                          AV_CODEC_ID_NONE, GET_CODEC_NAME);
>>      if (bsf->priv_class)
>>          show_help_children(bsf->priv_class, AV_OPT_FLAG_BSF_PARAM);
>>  }
>> diff --git a/fftools/cmdutils.h b/fftools/cmdutils.h
>> index 87244891d4..6e2e0a2acb 100644
>> --- a/fftools/cmdutils.h
>> +++ b/fftools/cmdutils.h
>> @@ -625,6 +625,9 @@ void *grow_array(void *array, int elem_size, int *size, int new_size);
>>  #define GET_PIX_FMT_NAME(pix_fmt)\
>>      const char *name = av_get_pix_fmt_name(pix_fmt);
>>  
>> +#define GET_CODEC_NAME(id)\
>> +    const char *name = avcodec_descriptor_get(id)->name;
>> +
>>  #define GET_SAMPLE_FMT_NAME(sample_fmt)\
>>      const char *name = av_get_sample_fmt_name(sample_fmt)
>>  
> LGTM, tested and verified
> 

Pushed, thanks.
diff mbox

Patch

diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 708a849f51..c0ddf0b287 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -1907,6 +1907,8 @@  static void show_help_bsf(const char *name)
     }
 
     printf("Bit stream filter %s\n", bsf->name);
+    PRINT_CODEC_SUPPORTED(bsf, codec_ids, enum AVCodecID, "codecs",
+                          AV_CODEC_ID_NONE, GET_CODEC_NAME);
     if (bsf->priv_class)
         show_help_children(bsf->priv_class, AV_OPT_FLAG_BSF_PARAM);
 }
diff --git a/fftools/cmdutils.h b/fftools/cmdutils.h
index 87244891d4..6e2e0a2acb 100644
--- a/fftools/cmdutils.h
+++ b/fftools/cmdutils.h
@@ -625,6 +625,9 @@  void *grow_array(void *array, int elem_size, int *size, int new_size);
 #define GET_PIX_FMT_NAME(pix_fmt)\
     const char *name = av_get_pix_fmt_name(pix_fmt);
 
+#define GET_CODEC_NAME(id)\
+    const char *name = avcodec_descriptor_get(id)->name;
+
 #define GET_SAMPLE_FMT_NAME(sample_fmt)\
     const char *name = av_get_sample_fmt_name(sample_fmt)