From patchwork Mon Mar 26 00:25:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 8172 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp2964994jad; Sun, 25 Mar 2018 17:26:18 -0700 (PDT) X-Google-Smtp-Source: AG47ELuBRc54Ih8sRK0oQQAxZNPnUIXBdZz6Jcjr016mSyLNprAZHR1D/JQK3MQnGWTVkKaEpcQh X-Received: by 10.223.142.13 with SMTP id n13mr27064420wrb.133.1522023978621; Sun, 25 Mar 2018 17:26:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522023978; cv=none; d=google.com; s=arc-20160816; b=EkqkOJZSqtvn0vKZL0oOvVGS1GqKLwX2vf24MrlGcmnTujdxXUpCWw7ObIlfz68qkD btwaXzJF+Qnc6Ya1/ewL03L5RAeJ1Qcht57s5wqBJl9piEeCsU1tCwsbvorwOC4D3iEK XjRD8gW3qesVFRrxovy0pAPJyZYUSvih1M8SV2l5MNs0zHEybzjaBTCzk7wuxzhqzHJe IO4THF2KUCXvOvFIhEakMlFth0fpvAHqtiYZIewbbPJ1hKD743WF1ZTGvvxjslSF3wy9 /+VfH8TICRwQI7pgzdDi022tVPVhfJrWoOsay6fnzihp3Ogoyemwoj1gaN4BctXbGHT+ azvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=HoP9+OK/djzxWxhAb5Z0sVMuld0IkhkIotC3NJIQDIM=; b=cCyG18YCE80s0fDSm3Je15bbTKwincUmDq3D9iYXLwprvSjXXsNoddIT0GLJvKv0uf kl42gN5y+ACuS291dBcmMjn0SRzmOGyVz9vTHoV9FlUpW4mFQyHcx7zurR5Ab5aiHIwu +ZDdatg69tx1VFQ6FmyLESKbV8+3j/8kaulJmM/PixVd03v0twFJCYD80936c1l3vkQA /Iu2iCxBuYiDuyjw5v6WuW2h1fHD0VljJLT6wIZm6r/cKHMggkC3QkJ5SOPH8DzJuII6 MbF/Mrp07FiUprKzreoZaL9t6pNxQsBtn9WUGiOlPYrfl8C8KFkl35tTZ2DmoY419Syy H3gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=m1FXMslI; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a6si9423206wme.240.2018.03.25.17.26.18; Sun, 25 Mar 2018 17:26:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=m1FXMslI; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 04BAB689972; Mon, 26 Mar 2018 03:26:00 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt0-f194.google.com (mail-qt0-f194.google.com [209.85.216.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 78A11680774 for ; Mon, 26 Mar 2018 03:25:53 +0300 (EEST) Received: by mail-qt0-f194.google.com with SMTP id j26so17938602qtl.11 for ; Sun, 25 Mar 2018 17:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=0OXcGVMN+7aTbGgSEPNY0hkhgVJDGZ8AoHOPPAGrtpM=; b=m1FXMslIFUU1TW/XTw6m5EJCe375+ryXUeeUgs3OVZ+2tgH5RsCyCV2JvLNPyUiAwI Oi8OAuDwzZ08mQIR1MRddWDFvlRVz+O3cxA/sjG2ZucEy8nbgHssORwdW91JuoSO6y+C pPY8jnErLLbvp6zfN3xTH9w/qsU1MyihCRgeTeox5Ondavy+qCwwVdcQ+G6lgJJohTFo 7QxUD0zofO3zfQoSsx/FWzFe9eXWmEMuDgFNFinnzN0wR6OovVHQ6DDLQOx1du0y4iTi bbCr6NuGyXX9ROf26f4RmSRaIq+67Sm2fbxYrjNHJQCzt+C7ES1vO1R9CAeNxAW3wUf/ DJdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=0OXcGVMN+7aTbGgSEPNY0hkhgVJDGZ8AoHOPPAGrtpM=; b=cYW0z+y8YOynmRhvGksJPFsVHVB9k5PKtNCED3UXKEraBWIUKI3U88v3om0Sa8VGn1 PdK4gQ1TYplJ3BfFO5c9ifsPJqbpYX1oWq9oZ9vBShvmyKPCXIHUUVszQPIF7CdI04G/ /4pLBPsNJPd3WU+ojn0N0S9sWiGzmdUXr3fKEO0ABmkDTwipNu62GeicSbfmPHyRWJdk L+N571LgCZVXV8j6Ynt8h80DYl2Had7Lmue8u/avSSX7/urAHfsz5jcV4B0+FG30Grym KX5WP5KNafyaX2B+L6Do9+NNNkW8uONdZCdlX1Nt2U2I0Y7f0wmI3boLqZNNf5rPZWpr dxIg== X-Gm-Message-State: AElRT7HaBA8k/zfsZNeADLzK3XrJn47gewoHylLFcOfNWakyxM7j5OXY FC77ynDVQy2NlOaSql97CJkNUw== X-Received: by 10.200.50.61 with SMTP id x58mr53146838qta.130.1522023969355; Sun, 25 Mar 2018 17:26:09 -0700 (PDT) Received: from localhost.localdomain ([190.188.171.140]) by smtp.gmail.com with ESMTPSA id z50sm10784881qtj.92.2018.03.25.17.26.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Mar 2018 17:26:09 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Sun, 25 Mar 2018 21:25:11 -0300 Message-Id: <20180326002511.7036-1-jamrial@gmail.com> X-Mailer: git-send-email 2.16.2 Subject: [FFmpeg-devel] [PATCH] avcodec/avpacket: remove unnecessary check in av_packet_make_writable() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Zero sized packets are already handled below in the function. This is more in line with av_packet_ref(). Signed-off-by: James Almer --- libavcodec/avpacket.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 0693ca6f62..0993481961 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -660,9 +660,6 @@ int av_packet_make_writable(AVPacket *pkt) if (pkt->buf && av_buffer_is_writable(pkt->buf)) return 0; - if (!pkt->data) - return AVERROR(EINVAL); - ret = packet_alloc(&buf, pkt->size); if (ret < 0) return ret;