Message ID | 20180326180239.2944-2-jamrial@gmail.com |
---|---|
State | Accepted |
Commit | 58ce4fdeaebce5d9837ebc77e1453e7cf3a5bb1d |
Headers | show
Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp3843771jad; Mon, 26 Mar 2018 11:04:43 -0700 (PDT) X-Google-Smtp-Source: AG47ELvNhvmAWpfdhOO9GhsCD+mEN+YnDNCd8MUxxcKbjD1hW7woFKyyhXmkMHn5VS7XNdeVa2SR X-Received: by 10.223.133.182 with SMTP id 51mr29439223wrt.226.1522087483354; Mon, 26 Mar 2018 11:04:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522087483; cv=none; d=google.com; s=arc-20160816; b=I6Xid+9M1RbG95eC/R7SWQt9hpxSHSCjoRNOj40XAOVwPm+ZhgXkx14ouDK1B/HKo4 Gg/heWNzu7H619p54RSGfcAfGjTJRjg/B7OF0etUeNnJf9VwcQxU0rrwNnB7+V49eUHG XzHWM4ZsqA4srx8qMVibWW+EEuup8z5N90OEq4Iwr2IRWXVvXHQKkA/BTs+u3jkCSTed cxOcdgS/8PMp0z/00Kubboq99r/f+XNcG7kYTu2BRCDwxtOg3daMDI9sQW33sgdDG6Gd lgu/j9YreQ4lGNW+SzdEEHzwfjf4UBZNOq4wM2rfvhU4acYKxA4ATs7/vFsL/TgTRdsU 4klg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=IvANesMo8PNXykFE/eyfldtMeCtYMUEo1T1dDoT5KVc=; b=ddexkzBCN8kibWKPEC4dQzYKrvSndQwfWwbtABBysirariEqvNT9cZDjBttGSRMs8A VbCsR4kgkwEzxLX5JL2kCnpYscCg5j0FPejezy2WFOUGhTX5laoxY9AjKv4xjyRC8ikL rdrX4oGLUUyG2TtHBTS+VxYqJYLL38OMPJvYrTUxR/cRWfUk1ITR9Vnbt7eu01eiRca0 zbnXTAvXmsgDXkQwmadXGIC61vl/5gicMrfXgmfBEdw12XfkB2dTXyLtftWrQ9MZv7FD dXjw1Ri9D9Smw88uyAE1nDgJfHemjepZHg7KXmh/WRR0t68Ry59ytrY71kmxSzgcqDrn fVRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=lRp1tfTj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 129si5742462wmq.144.2018.03.26.11.04.39; Mon, 26 Mar 2018 11:04:43 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=lRp1tfTj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8B7B8689BBB; Mon, 26 Mar 2018 21:04:09 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt0-f194.google.com (mail-qt0-f194.google.com [209.85.216.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D08E8689A59 for <ffmpeg-devel@ffmpeg.org>; Mon, 26 Mar 2018 21:04:02 +0300 (EEST) Received: by mail-qt0-f194.google.com with SMTP id j26so20509886qtl.11 for <ffmpeg-devel@ffmpeg.org>; Mon, 26 Mar 2018 11:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=m/AU7SM8/F1km3cS3PaBly2XaX2VlXQL2g9U6UyNu2o=; b=lRp1tfTjKrxmV6UJe8YgUVjCmRxooXLemTuhQaJFxXjhXWrq0vgzzlAVUtUpsO3S1W Hn8g/7Upain+2IWw4ngch5uFwMLvknJnG5wSLRJrx8AWoPq7ezEgMibxzfH+nC2O1dPk /SUnPcdvjIWUbjdVYimToJ4u0fLVdGCiywEvjNYXHwr9WQm3agBPA4NK6pGqCb5Y1k94 RRO388+CIi2pX7zVjntEOzPuZSopaFyQZLc/lpJu+1ESaLtczUT8uDIWLNH5edLXOFdT Pq9rbaqaEe8hOvxIeovja80m5tJNU0PXZtCYZgZ5kTZwyJWDOvw0xC806n5gRELvX02/ 3boA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=m/AU7SM8/F1km3cS3PaBly2XaX2VlXQL2g9U6UyNu2o=; b=JWqtXOObTqbPsH8IA64uOVV/n8ucMm1omWZGELRTMRUOFjrO3PHuhIW/SKWSo+0dNv E5C0SfAQanmIhNy/ieShUsBnqOamb/EacXAkK0kb+VvZbR4lnTayT5+WYZS9OCXauyR7 CvyKx4VcDXTY8vCl4tgAMExPozkurt11vABuRJKmg0KpHPO87J8ZBWS6Ifh9gHdC1enu CpBblo8JQMFPbSrh3wN2p5uTZvJUxvnuZPmMCpjvDuU7gaIskB3v4nhMkDyoR5loC9EG nsu+pDSilBdXiN3a5SIjKsiaCZSaJzyaaz5ZuGIm/Si1SBQHjAznuPgsKtq8jQ74QTa4 OgRw== X-Gm-Message-State: AElRT7Fx3wbXIi9XHG8NkKpm6RF67N6oT+hq2ucmG3RKNGaztDx5w/lT d6D2k8toMU2hVs63H/c1YLPiCQ== X-Received: by 10.200.64.70 with SMTP id j6mr42706864qtl.321.1522087459127; Mon, 26 Mar 2018 11:04:19 -0700 (PDT) Received: from localhost.localdomain ([190.188.171.140]) by smtp.gmail.com with ESMTPSA id r28sm8009901qta.77.2018.03.26.11.04.18 for <ffmpeg-devel@ffmpeg.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 11:04:18 -0700 (PDT) From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Date: Mon, 26 Mar 2018 15:02:36 -0300 Message-Id: <20180326180239.2944-2-jamrial@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180326180239.2944-1-jamrial@gmail.com> References: <20180326180239.2944-1-jamrial@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/5] avformat/utils: optimize ff_packet_list_free() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <http://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <http://ffmpeg.org/pipermail/ffmpeg-devel/> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> |
diff --git a/libavformat/utils.c b/libavformat/utils.c index cb1ea5b386..9faffa03a3 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1416,12 +1416,15 @@ FF_ENABLE_DEPRECATION_WARNINGS void ff_packet_list_free(AVPacketList **pkt_buf, AVPacketList **pkt_buf_end) { - while (*pkt_buf) { - AVPacketList *pktl = *pkt_buf; - *pkt_buf = pktl->next; + AVPacketList *tmp = *pkt_buf; + + while (tmp) { + AVPacketList *pktl = tmp; + tmp = pktl->next; av_packet_unref(&pktl->pkt); av_freep(&pktl); } + *pkt_buf = NULL; *pkt_buf_end = NULL; }
Don't contantly overwrite the list's head pointer. Signed-off-by: James Almer <jamrial@gmail.com> --- libavformat/utils.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)