From patchwork Wed Mar 28 22:52:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 8216 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp1003133jad; Wed, 28 Mar 2018 15:52:37 -0700 (PDT) X-Google-Smtp-Source: AIpwx49USDNVupHUeEdVA08eTLJLH8/HmeryELV+E5Q3UAxbVYEt7GlLWoTnemRsvdNbp7lRyWxK X-Received: by 10.28.50.130 with SMTP id y124mr3869791wmy.22.1522277557481; Wed, 28 Mar 2018 15:52:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522277557; cv=none; d=google.com; s=arc-20160816; b=kdYbyoxFI3fNlkHslLJJTMpyFxEnk5DojEK8tHuG/Tq9JDzwXMhL3WRuR7lTl0F+/y vK1fDmAap7iH09wx2UCYUnwuedsjgcDS+9OpcyVLa41vag0EJYGe+zQ9JvzMEmoAXsXS SVRFdX4sY348hrgHcEr0y/Xzyhc6bJ2Yc+ywzXSffVV9l8KQ8s/Zw74hnM4l1Wxx0kux FAYcz5nKyvFIRcSRt3leXYnnBp4PGgY0V0U075POVFCVZwyswfuF7kslA2q4HfvCxYbs 9papRqQOJ9okkOtkoxxJf2GLGGgLFXPfVk3jpX5TiVN5pP5c6x5Ui4Ke4H1M/Zl7+E3a krAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=jCSK6iWgHco3JugCZz0aQGSiKqGFdekcTXJ+QJHNa0k=; b=RbFBuIO0wQA0P/Doq+e1O+cp660p0uBFCMGnM5QqShZDL9NSnp76L9l3JonR/xVvoN p5Xmt6hdB/3gP85a68mFQceKCMbQTTKEv5cE93m/NdfpumtN/W4yxvieXOyJOUL75Jmi eGAr1VhFOVgwh9E5/KGbmEb1CIxJAH3llk7gUIg41GfzdvIVemS85uy5kdhb0G2eJXQ1 nfunwueH0NPQa/wU8B7vMIdOEb8B12j5/21nm9T368IBdLWndOXo0ALYKQEZFC6R+dDa 5DJDAgxTPmZX4j6SU0JyTdL37suOg8ii9PSVc+GdMrYVLZ5grj3cVBCTEP/3r3HdM6SM JFBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x1si361400wmh.18.2018.03.28.15.52.36; Wed, 28 Mar 2018 15:52:37 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7D61B689925; Thu, 29 Mar 2018 01:52:16 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay0-d.mail.gandi.net (relay0.mail.gandi.net [217.70.178.220]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A28A06802AA for ; Thu, 29 Mar 2018 01:52:09 +0300 (EEST) X-Originating-IP: 213.47.41.20 Received: from localhost (unknown [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay0-d.mail.gandi.net (Postfix) with ESMTPSA id 416414002A for ; Thu, 29 Mar 2018 00:52:26 +0200 (CEST) Date: Thu, 29 Mar 2018 00:52:26 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20180328225226.GP32664@michaelspb> References: <20180325145721.GN32664@michaelspb> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Tue, Mar 27, 2018 at 02:26:45AM +0300, Даниил Чередник wrote: > Now it should be fine. Second patch has been fixed. > > On Mon, Mar 26, 2018 at 3:59 PM, Даниил Чередник > wrote: > > > Hi. > > Yes, I reproduced it on mac. A bit strange, I run fate with valgrind > > during patch preparation, it was ok. > > I will fix it, and send updated patch. > > > > Thank you! > > > > On Sun, Mar 25, 2018 at 5:57 PM, Michael Niedermayer < > > michael@niedermayer.cc> wrote: > > > >> On Sun, Mar 25, 2018 at 01:55:42PM +0300, Даниил Чередник wrote: > >> [...] > >> > >> > libavcodec/dcaenc.c | 369 ++++++++++++++++++++---------- > >> -------------------- > >> > libavcodec/psymodel.c | 1 > >> > tests/fate/acodec.mak | 4 > >> > 3 files changed, 156 insertions(+), 218 deletions(-) > >> > fd146632a7f29530a59d35abd63149c81b4dfcc6 > >> 0002-avcodec-dcaenc-Use-aac-psychoacoustic-model-for-DCA-.patch > >> > From 99d937a0828bbd60aef52d7979c75f8c21989145 Mon Sep 17 00:00:00 2001 > >> > From: Daniil Cherednik > >> > Date: Sun, 4 Mar 2018 13:14:17 +0000 > >> > Subject: [PATCH 2/2] avcodec/dcaenc: Use aac psychoacoustic model for > >> DCA > >> > encoder > >> > > >> > There are several reasons to replace dca psychoacoustic to common model: > >> > - dca psychoacoustic has some quality problems especially at high > >> frequency bands > >> > - unclear implementation > >> > - aac implementation allows to use tonality measurement for future > >> improvements > >> > - a bit faster > >> > >> This breaks > >> make -j12 fate-acodec-dca > >> (segfaults) > >> > >> tell me if you can reproduce? If not ill rebuild with debug symbols and > >> get a > >> backtrace > >> > >> [...] > >> -- > >> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > >> > >> If you drop bombs on a foreign country and kill a hundred thousand > >> innocent people, expect your government to call the consequence > >> "unprovoked inhuman terrorist attacks" and use it to justify dropping > >> more bombs and killing more people. The technology changed, the idea is > >> old. > >> > >> _______________________________________________ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> > > > > > > -- > > Daniil Cherednik > > > > > > -- > Daniil Cherednik [...] > 57b2e6d001a856c9434fe6ad1856cb3f24443a83 0002-avcodec-dcaenc-Use-aac-psychoacoustic-model-for-DCA-.patch > From 49b4f2a966719c24f54c026c438680557c35e96b Mon Sep 17 00:00:00 2001 > From: Daniil Cherednik > Date: Sun, 4 Mar 2018 13:14:17 +0000 > Subject: [PATCH 2/2] avcodec/dcaenc: Use aac psychoacoustic model for DCA > encoder > > There are several reasons to replace dca psychoacoustic to common model: > - dca psychoacoustic has some quality problems especially at high frequency bands > - unclear implementation > - aac implementation allows to use tonality measurement for future improvements > - a bit faster > > Signed-off-by: Daniil Cherednik > --- > libavcodec/dcaenc.c | 369 +++++++++++++++++++++----------------------------- > libavcodec/psymodel.c | 1 + > tests/fate/acodec.mak | 4 +- > 3 files changed, 156 insertions(+), 218 deletions(-) breaks fate on arm qemu TEST acodec-dca Test acodec-dca failed. Look at tests/data/fate/acodec-dca.err for details. make: *** [fate-acodec-dca] Error 1 [...] --- - 2018-03-29 00:37:01.286083392 +0200 +++ tests/data/fate/acodec-dca 2018-03-29 00:37:01.283607451 +0200 @@ -1 +1 @@ -c610f911aa74656132abb650be6b548a +503d8eac7238d87aae6f92808231e0c0