From patchwork Sat Mar 31 19:44:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 8258 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp951956jad; Sat, 31 Mar 2018 12:45:18 -0700 (PDT) X-Google-Smtp-Source: AIpwx49dJc4bKW5YW3G5GccvkZzynRdJ0XX+Hn3/FUcEmDsHDHAM7ltvIgfIx9vuOODpWhFfG/km X-Received: by 10.223.175.211 with SMTP id y19mr2696186wrd.139.1522525518521; Sat, 31 Mar 2018 12:45:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522525518; cv=none; d=google.com; s=arc-20160816; b=FxuvglbBJmJXK7iTW61q6C9LdnsOCXvuAw4z5QgAKGQ8R0o1ZBzI8QD+42ySbSqQZs wHBMmX8uyb7tbDkIZKpFkdzjnAhe7U5cj4yzUBwG05P/PjmbA9braMCQAjGMhP/6uVc0 pqdOqTbiDu6RZPxOT26r1qNVHsdRZCSJNqjJMurybsyhVIBuJpFa0urUeF/nPo6tgBpJ uyj007XPaKMp2wqZBKMCp6C8iYuLOjEKq+F/KZmU/nEJ4cK0xp+Rpfz2OhwYbasLWqeI sQaYOUKUTiyvSJ3HKPyNCLgoEljKJkdQJ29qRdsXgVntrbNDx/zYTMmdIvgmKK4CoECq 1PWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=STFTBArIdSlskai86ryZ2Qvq8N7oLq/OSGVzDiMEMy8=; b=NybbCqcXEpNozYqo8tHwff6H32+F9XrHfXH9VHW15ljOctWBOl9jXlNgSaqR1iLZdB yL3RwNswTB9ZYoCT1n8xaQWTTHgSNwFLtGkFkWVezBAM2TlwldDt3b8EA5o335qdIxED xvi4K6WSod2t0bXtWcJhXbhbnxnhSoO+W+2OW62vVTQe2RyRQ5rNNlT6JgWQgFWiOesQ 9SaUFWpgaX/ktx1xYzagy1OTz+YRmmUnN+0kuWNuNleWbfIcxdFby1QheGRlUCdgw2FE op1ng3sp9t9AaJ5ZwSmOF9geUI97wNBbHGbNIquu8GrRaxsXP/c4rCd5WBgfU+zn6VgM c4HQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j66si5601081wmf.195.2018.03.31.12.45.14; Sat, 31 Mar 2018 12:45:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5BF5D689C63; Sat, 31 Mar 2018 22:44:53 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe07-2.mx.upcmail.net (vie01a-dmta-pe07-2.mx.upcmail.net [84.116.36.18]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9EFFF689BAE for ; Sat, 31 Mar 2018 22:44:46 +0300 (EEST) Received: from [172.31.216.43] (helo=vie01a-pemc-psmtp-pe01) by vie01a-dmta-pe07.mx.upcmail.net with esmtp (Exim 4.88) (envelope-from ) id 1f2MQz-0004cp-C0 for ffmpeg-devel@ffmpeg.org; Sat, 31 Mar 2018 21:45:05 +0200 Received: from localhost ([213.47.41.20]) by vie01a-pemc-psmtp-pe01 with SMTP @ mailcloud.upcmail.net id Ujky1x0070S5wYM01jkz12; Sat, 31 Mar 2018 21:44:59 +0200 X-SourceIP: 213.47.41.20 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 31 Mar 2018 21:44:23 +0200 Message-Id: <20180331194423.2976-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.16.2 Subject: [FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow in apply_independent_coupling_fixed() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" I was not able to reproduce this, this fix is based on just the fuzzer log. Fixes: 4959/clusterfuzz-testcase-minimized-6035350934781952 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aacdec_fixed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacdec_fixed.c b/libavcodec/aacdec_fixed.c index f96999efb4..5c3613e06c 100644 --- a/libavcodec/aacdec_fixed.c +++ b/libavcodec/aacdec_fixed.c @@ -417,7 +417,7 @@ static void apply_independent_coupling_fixed(AACContext *ac, int i, c, shift, round, tmp; const int gain = cce->coup.gain[index][0]; const int *src = cce->ch[0].ret; - int *dest = target->ret; + unsigned int *dest = target->ret; const int len = 1024 << (ac->oc[1].m4ac.sbr == 1); c = cce_scale_fixed[gain & 7];