From patchwork Fri Apr 13 00:34:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 8433 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp186132jad; Thu, 12 Apr 2018 17:35:08 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+b2bMZxpsZUeOHK1V26WcAlGijTuD7c5CJrNwXFdyep8BA5hgS2JcyfBG4hqNxhNCAd/ud X-Received: by 10.223.160.78 with SMTP id l14mr1985234wrl.153.1523579708738; Thu, 12 Apr 2018 17:35:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523579708; cv=none; d=google.com; s=arc-20160816; b=oCdnChPE9Q60jsULtGRiE8c6L0COlANeFZpgV7BeSHGw2RSO5CmdpltyVsan4sJp7s 7640C+O58juloXNfbBl4FrlDMm38Tgup2w0h0kTst1YkytEd8mSr1gxDkrgTuj3KR10P 2hdfiXFRq3KwQfSlm8ti2S415LBBcnoRnzpvks8Q4Bj6GhE9jtQWA7thuklGvMoTzLVg UocOZXuQxFxWpiZRkU7QYx9k4G07odZ6tE3FdWY2SLJNvB6s1MUs0FT8pUwWpNZ/nxOj a6dDK+WeAxM62hmNoj3+UEoyptZxHx02IJJvsGoVaH+lRXqUoVVZaivEvaAdAV1sP317 VdqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=ocP6sSZU4zjk6vmoDp2bfNgantdkU0L21m2SpGirIe4=; b=x68j7NVEFyo3+oIaeXsfqkVDfTnhIF5JoEqpHqeZAVZuHrjAV4hgh6saE+0F9LRqv9 Zrth60vKzqEwFA02P22jlx/EUPFDqYqwp3h8VU9aPGHu3qCwBe0H3gDj2Nf83qmgfoFu MAK4FKHt6SnK2WFCne3pMvqWvIzNaJM34711N3FFz3UstF/0OzQMnAvvFrAG9+3cexUW yo82+qZ4tLM37NyGFmvC42x9g5g2vg32r1pXY2tK5rG8hkT98+VB6FRl4EjgPeIcjGZi XE64bNYxL4qAHgJCuJ03y5MznNQ7IuAXljd48XjjFQ1yhuhQ6Z+SRTERpzZagl/7Y0kJ 1/8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g66si435925wmi.107.2018.04.12.17.35.07; Thu, 12 Apr 2018 17:35:08 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BAF1768A042; Fri, 13 Apr 2018 03:34:41 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe04-3.mx.upcmail.net (vie01a-dmta-pe04-3.mx.upcmail.net [62.179.121.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 76AA6689DA8 for ; Fri, 13 Apr 2018 03:34:35 +0300 (EEST) Received: from [172.31.216.43] (helo=vie01a-pemc-psmtp-pe01) by vie01a-dmta-pe04.mx.upcmail.net with esmtp (Exim 4.88) (envelope-from ) id 1f6mg7-0003VB-E0 for ffmpeg-devel@ffmpeg.org; Fri, 13 Apr 2018 02:34:59 +0200 Received: from localhost ([213.47.41.20]) by vie01a-pemc-psmtp-pe01 with SMTP @ mailcloud.upcmail.net id Zcaq1x0080S5wYM01car4P; Fri, 13 Apr 2018 02:34:51 +0200 X-SourceIP: 213.47.41.20 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Fri, 13 Apr 2018 02:34:01 +0200 Message-Id: <20180413003401.28202-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.0 Subject: [FFmpeg-devel] [PATCH] tests/checkasm/checkasm: Provide verbose failure information on float_near_abs_eps() failures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" This will make understanding failures and adjusting EPS easier Signed-off-by: Michael Niedermayer --- tests/checkasm/checkasm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 20ce56932f..8a3e24f100 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -294,8 +294,12 @@ int float_near_ulp_array(const float *a, const float *b, unsigned max_ulp, int float_near_abs_eps(float a, float b, float eps) { float abs_diff = fabsf(a - b); + if (abs_diff < eps) + return 1; - return abs_diff < eps; + fprintf(stderr, "test failed comparing %f with %f (abs diff=%f with EPS=%f)\n", a, b, abs_diff, eps); + + return 0; } int float_near_abs_eps_array(const float *a, const float *b, float eps,