From patchwork Mon Apr 16 00:40:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 8460 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.85 with SMTP id c82csp263999jad; Sun, 15 Apr 2018 17:40:43 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+P33OzQSKoLzlhqZvoZ16/aagat4EsR5PVgRFjhxEqFuXgAmRcGyWk630Ps47si0fOBB1H X-Received: by 10.223.153.134 with SMTP id y6mr6421636wrb.40.1523839243532; Sun, 15 Apr 2018 17:40:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523839243; cv=none; d=google.com; s=arc-20160816; b=UblMaLg+zfcYGW8EEWLzKhginmSOHSPyJoG21n0GDVhrs0bODiZyQN36OQcw2Aab0J OQb+6hOx/bpVYHmXIADgp1mC2RJ64PBrtC3fEq2BuQn7VRwrgsgsn+QYq+PRjl4B4ttG 4CuizBc1WxCkkREe10aWBQSSGhSNXcyjFiUjyp7vvNlsVvrI7y5Ke3aY05bE0RgnFI7Y kdZd6p7CgWWtvZk9GK3kDvNjIwxA7CBhxlGtDScRo7kgtW+vNeUHR2f+u1HO3WjYMCcu RL3HHJVjoEI5Mp+EIRWOvTZi/yMvMX+XLdQQXkrtWo6BBYIZwDl/5KCngr3hTLsIycHP c6Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=uvT5ank+u4SsLPKdVYLMmrXB95GvTqB7KtxtXM9Z57M=; b=QtV2HxE2aZCkaEy4p11nFO1SosPzWOkVof7N32AcHBu3okg0m4vGUXRGemA3GQDxYJ Knk1EcS43Gk6QEX5S3NonwN6wPshnS61Sfe5jGRQR5Bn418hRp/ku3vTaYkNYx7bwHIA DBfChAMi8lGEEqNHMrYuR+UzwqQZRFLOwg39Nr45VBAxCPst3BHZX9UJmon0N73Gp8sN JDRcqsAyYDRfOEgwG8LtF5oRm+bJNsbc3l96oW5IxQ+4wP8qBmfsmX7AO/G5SU8Gy6H4 oDzgkTIvgi57Sxq/OZfUUUIOC0jdUdtcykh2R4j1+blTYcUxbLpC7DeQE3JjbX5QsOfW 6UvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=j1ZwG1kL; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h67si3278305wmg.141.2018.04.15.17.40.43; Sun, 15 Apr 2018 17:40:43 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=j1ZwG1kL; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BCAED689E43; Mon, 16 Apr 2018 03:40:15 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E61A7689A22 for ; Mon, 16 Apr 2018 03:40:08 +0300 (EEST) Received: by mail-qk0-f195.google.com with SMTP id a202so2073299qkg.3 for ; Sun, 15 Apr 2018 17:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=Nw0u/qBxD9EN22ItGFowVN1BorqBEDzcehgTFXOv8ZQ=; b=j1ZwG1kLMmtosl6/ttvmx6FDIaEdyM0bC0Kgub0VOkZc2BNPcopRnZYUtG+wplh+37 RrM6Pd4ryR/LCa3rmgsXLldKi9svTtx8iDv93jtefUQlNmrOgEXbqxvAKCK1QhNMMAvL uBJDxhXHdk0reaQH11417QMD0hW86FhrKF1I6Z33ey3nmJaB5HozKRtpi2LX9N4Sng64 hZnqmlRaHfpY2Pcya9QYBcy7aPEuc4PwJOvBC5KqeLjludRnB+diaGrErhycLDZfWk0Y W5SodFxewkgj3VOTsEe4vrefw3ZHIophyFWp6bOVekPtBTNt2wnQkatmEfVnDA3yn+B+ KPtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=Nw0u/qBxD9EN22ItGFowVN1BorqBEDzcehgTFXOv8ZQ=; b=Ond5wP6NMwHa0lpZHM8A6j0OQNsuoBwq70vZhR/lXHAXbndoFjmEGKCxrTUdnd0SFd Vj83+7XZfVlF2/Yzur+hLur2mMzdOiBALYylHnH9D52FqUHQ6HLnjA8MUEf57knhep+x MQ8HoOa/Wmwk/90hggYIdEIn9662McONZ6ZaTkdpL76HP32h0tj08gT2m00rvOsbsqrB jM11Q4aU5yUu3Waq0Nn4v7xPb1K+dOZcA9etDf64x94KIxzVhyUivbl713k7MyQbOWs5 q+PLk6o6LQ1ladU7fo7s+VUqczN0MFMQhBNkaRXwHaTxvZkzPv3l4UVMBXmE5I6Fey5G v6tw== X-Gm-Message-State: ALQs6tDqGRPgeaGgZ74kmxV+VoGwiElHjzZJWSE12qXURslS0arBMzae RGft21rSk1SSbgXSv904kBHAWw== X-Received: by 10.55.80.6 with SMTP id e6mr14977118qkb.191.1523839233717; Sun, 15 Apr 2018 17:40:33 -0700 (PDT) Received: from localhost.localdomain ([190.188.171.140]) by smtp.gmail.com with ESMTPSA id s2sm8512729qtd.97.2018.04.15.17.40.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Apr 2018 17:40:33 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Sun, 15 Apr 2018 21:40:16 -0300 Message-Id: <20180416004016.6916-1-jamrial@gmail.com> X-Mailer: git-send-email 2.16.2 Subject: [FFmpeg-devel] [PATCH] avformat/movenc: forbid muxing AV1 streams until the spec is finished X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" This prevents creating potentially broken files, as both the AV1 and the AV1 in ISOMBFF specs are unfinished. Signed-off-by: James Almer --- This is mainly so it's effective in ffmpeg 4.0, the first version to support libaom (including pre-bitstream freeze builds). Best to prevent muxing files that may not work anymore a few months from now. libavformat/movenc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index d03d7906a1..dc5c842cb8 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -6081,6 +6081,10 @@ static int mov_init(AVFormatContext *s) av_log(s, AV_LOG_ERROR, "VP9 only supported in MP4.\n"); return AVERROR(EINVAL); } + } else if (track->par->codec_id == AV_CODEC_ID_AV1) { + /* spec is not finished, so forbid for now */ + av_log(s, AV_LOG_ERROR, "AV1 muxing is currently not supported.\n"); + return AVERROR_PATCHWELCOME; } else if (track->par->codec_id == AV_CODEC_ID_VP8) { /* altref frames handling is not defined in the spec as of version v1.0, * so just forbid muxing VP8 streams altogether until a new version does */