From patchwork Wed Apr 18 14:34:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hendrik Leppkes X-Patchwork-Id: 8491 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.85 with SMTP id c82csp3164702jad; Wed, 18 Apr 2018 07:34:59 -0700 (PDT) X-Google-Smtp-Source: AIpwx48jPnc4AP3fkJo5vg89Fs6Z07X2eAK/BZypqZdMj8fK1o1lInK733ijFi4f8zE5yJwb6jlN X-Received: by 10.28.232.84 with SMTP id f81mr2034185wmh.134.1524062098932; Wed, 18 Apr 2018 07:34:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524062098; cv=none; d=google.com; s=arc-20160816; b=lFh4aBevusv1WZ67bLCf/KGVP8SnUf0SgGyLY5rL0gVnnCMWRDP8VBmqJ+A3YLVc3Y OkhIaX9JB/rLp7dtMMe0Wdf2n3Xm0IS499Y3hmU3gU6alcPl8XiLgC6CBnkzi0DW/fL0 0JCTytbdo8y7p8d7uCgFUxmQ+qsMiDUqoYxpTGQi1xRoSSG1iludxxWX2p012zAD0CZ0 5uq5duqTzou4vYBmdfWNWIzeVVml7Psq9/+bVJfGyH9z3+i8VVU09KEqmZSXQEJR1xmu tHN4lDPgcbPo8r7X7L6iqj2/4f+0CHrY8+LIvLlw9JEpu8qYzBXCqAIPSnaTpXlvC1/m 3p8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=NGEsfr7H0VAbBwNFBfjsdBn6VZEkOsnnyrR4Uzta2Vc=; b=Ce0PqQdaNEM7u3rilvcaipqz1TyMMHiVP5Bs8lKoOu4vOUBLVzohNZGIJwSySoDgLG wC6TWECKiWEpbcGS7qLRDT+ojKbQA/zk1d8T6RSsbDvSaB7vBpbinGfD5Ztf8ew2kpoa 3uxwb92d7sQ0D4eJL5QvEF7R/5HzxLBIopFGHqmq1Uh9VnXPPrMuQlMYeMCXoP4NTBAY MimV0+B/l0YvcoXWzv5JhjJUFQVw+yGfHx8mox6DpVX9Vt3X+nWRz9wbwRp//yoxstaF rIA0c+hh9M+BPHJJw62Xu53zTMlb1fccjkoYADYkJK991cK9akkUuZuUEulnCRO6xsL5 075Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=uxgHCYmj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b65si1222405wmd.186.2018.04.18.07.34.58; Wed, 18 Apr 2018 07:34:58 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=uxgHCYmj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 53F5868A04C; Wed, 18 Apr 2018 17:34:29 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 53105689F41 for ; Wed, 18 Apr 2018 17:34:23 +0300 (EEST) Received: by mail-wr0-f174.google.com with SMTP id d19-v6so5498287wre.1 for ; Wed, 18 Apr 2018 07:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=OYCVZ7VESFdFZMCICweUD3PZFpnjpFEM9csQ/dtHYvE=; b=uxgHCYmjQo8gwNSNuaCKD9Qmxs6LefxSJaqAAdhCob5RQhisKvxLCGkDygzi64lyAK QacatRCr2ulchxN7BJfEn8g3pvw6yZg65fWpMq65gnLvy2TC6NEx0wZfZ6SEcnJEJcJh 1UPLu03GrWX9CeVfgPQBhlE3XCzUPAnhq77EcFW2uy1yzRPl3bYsQcjkF7dUf5++F3Xx KQ5SWDAzKH7sHS+MoWUHvUisd6RiuKA4CeY/pB7pUnZCHhLdhBuFtNtGkOzBE8eL8y2S 0ifD3OF64krc6bsKd+sCAaWKfl2y56Hu7mppWvvsU730cgAWFCSDOfQKi0Vjqs1Hxj/j /V9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=OYCVZ7VESFdFZMCICweUD3PZFpnjpFEM9csQ/dtHYvE=; b=X7kkfcGE998Byn+zyn2t8nwrOI/NQmNC0MTT8j7+E4OPriNpd77JD4E+J7HyOaBRNX 8euki9u4oZhSNsSdilpnODmcRMazEEkzP5Hfi//NzMUVD/ULAxZKcAKKt/jwD7CVxiI8 okz9RevyNwQ9hbuR92uuYDfIFqL4bSzIfVAwSBdN6JxS3HeIq6XpPpmspRjn+rhyFvF5 bV5SFJW2JFeUvgkNoQSWtOFnDJXyckhz5xaJmNNwk1NTsDmyXDCQFihE5ItJTyqFKNJ3 aiN02wqm5vDNNfoJHUjBPo4QzWmKRM80B98cEA+4FMFwk0mRXZKN8943nTVwQq84Pqeb 9hAA== X-Gm-Message-State: ALQs6tB7uiwKTlg8h1b4ymv0AZ8+K1I1X6UPdSKDEwEIeUTLmjDXpHWu uYx1IhKji3HRgl3Fh823BlGm3NxZ X-Received: by 10.28.159.81 with SMTP id i78mr1937934wme.8.1524062089343; Wed, 18 Apr 2018 07:34:49 -0700 (PDT) Received: from localhost (p4FC4F2E6.dip0.t-ipconnect.de. [79.196.242.230]) by smtp.gmail.com with ESMTPSA id v66sm2710564wmd.41.2018.04.18.07.34.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Apr 2018 07:34:48 -0700 (PDT) From: Hendrik Leppkes To: ffmpeg-devel@ffmpeg.org Date: Wed, 18 Apr 2018 16:34:47 +0200 Message-Id: <20180418143447.12144-1-h.leppkes@gmail.com> X-Mailer: git-send-email 2.16.1.windows.4 Subject: [FFmpeg-devel] [PATCH] configure: fix clang-cl check in the MSVC section X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Without properly grouping the checks, the second test would execute for MSVC cl.exe, which results in configure getting stuck since cl.exe -? is an interactive paginated help screen, waiting for input. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 535a59b737..0074f36eba 100755 --- a/configure +++ b/configure @@ -4411,7 +4411,7 @@ probe_cc(){ _flags_filter=msvc_flags _ld_lib='lib%.a' _ld_path='-libpath:' - elif $_cc -nologo- 2>&1 | grep -q Microsoft || $_cc -v 2>&1 | grep -q clang && $_cc -? > /dev/null 2>&1; then + elif $_cc -nologo- 2>&1 | grep -q Microsoft || { $_cc -v 2>&1 | grep -q clang && $_cc -? > /dev/null 2>&1; } then _type=msvc _ident=$($_cc 2>&1 | head -n1 | tr -d '\r') _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)'