From patchwork Fri Apr 27 00:51:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jan_Ekstr=C3=B6m?= X-Patchwork-Id: 8663 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:155:0:0:0:0:0 with SMTP id c82-v6csp69305jad; Thu, 26 Apr 2018 17:52:06 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoPo24OMXB6PSOF1Q9BDQyHJMPpDjtWLj8bhJiPodgPK5G/QXz9uGiVAyh03xmm6SsKRlh3 X-Received: by 10.28.232.84 with SMTP id f81mr305641wmh.134.1524790326472; Thu, 26 Apr 2018 17:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524790326; cv=none; d=google.com; s=arc-20160816; b=KtwsVj0OpUT9k1C15P3QjuDSdxvSr6c/GD8h28Yh5KcfpvjAgLt8dX5EI4WuKExXw4 yqaBiZNF+ztiVw4ru7kzUzhk1bV90jxtvO4vvWIUJ3oEHNm4NJTgh8p2bMelcdTUVwQS am9tf7iyyhEWpn5H82qT2YuY1zT4Fjh0QofE0+nv8iVm+Q90fqkzArbz7ZnJ2nauCQh0 xqwYnxa/K5Gz3lCuy7cbPsl8sQtlCB58o3z0Z1S5k9qzIvxtnUODjZ+UODhZa00uMI63 BwU7dC1OMQo1RLTRxotDtxNXXLVTUyMEByg8zHtEs8OLy4aigy/tDnTeGniqPSEUbFie DMuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=Txg4pWqzRykVxBM1nTEcFVw4gOROskWZuZ9sDo2qL64=; b=Lfl/vrhIPVxmU6Y+HpQG2C9O76njKRR3y/W+60GIuSpFvor7N+O0Nwb7qzg/IOaNEb gQEgy9pncJPcGGvYe65Y5jNk2eGjUhwsomhvwbpVmPf2pEufKWLq+mnbxoo3A4orS4cY No6JLrjpKSwaKI8SMsUUch1xv7PqLQspJXZnjvLGVqls4OXQOdbp4wyi/K5cRpgWtUrk cDqTH8ZEp3ZVkqy46m/buKsI/jaETtb4ZTS1M2sbGTE/yjPzu9YEAND7M1mLzDhcSP8k qstZ0Aoo5OlMI6knB/z4nVWZMq/l54pGSqiAtq6i/41dfQBLxZao4r01kRkRqgx4lyvG pjcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=W4JQHnEo; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id r5-v6si84561wra.428.2018.04.26.17.52.06; Thu, 26 Apr 2018 17:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=W4JQHnEo; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E5A5D68A630; Fri, 27 Apr 2018 03:51:18 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 62B2E68A629 for ; Fri, 27 Apr 2018 03:51:12 +0300 (EEST) Received: by mail-lf0-f67.google.com with SMTP id q5-v6so244068lff.12 for ; Thu, 26 Apr 2018 17:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=WIUs6C76EQ/zlZ9GpKuGwkBuNoDZVv71Vfyr/Un5/kA=; b=W4JQHnEoFsRDKGhqVCxmG6aKwvCka72/AvHng0Qs0XwYQFZJOiZrou9A6fKIsk7yr4 K3nUmEq7PiPjx2wMXeSBoHGKh8wnUxjUw6TVK7z5ZrntQ9pH009yI3AUthYIoJ+0qm0c xdEwjSnVkfAT04NyRlahCL5KMlQ1E/bqD6IBnfL45BQP0Yhsk/IbT9DbZgGUhmxVpYEK 5tRDovkWXbMVeNlRmKTiOInE4gxE0AiANDdt9FklCI7y31DKGEb/dSarty47UjVBithz 2BL++0rcxOT+fgaz+0WGk9VkNz//dmZi49Oz8EJPfNxOC+dsb1r0+taqe07MoF35NlK7 jxHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=WIUs6C76EQ/zlZ9GpKuGwkBuNoDZVv71Vfyr/Un5/kA=; b=XerF46atbfH09VxDzWGyTApOTWZO5Sb0bdlUX/kW5bHJ8f6cUePBEV0L6FYPAjrYxh VJOep/8ERLzkyUKysLFXM71OZYbMJc5ejoT99rpTOZ2c7oxxd+Kmo/s9BYMK8ZjiHfmb bT79BkJAzCTVHqZ+JBUC5pyHzdWxCjvpgEy9ZDYOuNHTejZKqbXXwNDPVG9ec/oUfA5r mI8TdiWevUFqCYCvlKns48p3OhwlmR2L60wGVqFdBFpVoQWiZ9Ana8uyO7xcZM1RkeTi K4o1yAvZplgRajtWHEzIrH5JbaLgiq40mogLRM1XBZhaJYqkOLob11FALcBr3kEpRAG5 JUeQ== X-Gm-Message-State: ALQs6tCZVC8hUeX644lZIoIhK0N6H7ZfmrWDowY+ejSyavii5ccPfrP4 YMmTX8UqQukOYTjYI31J/uq2zxMz X-Received: by 2002:a19:cc09:: with SMTP id c9-v6mr106466lfg.3.1524790302526; Thu, 26 Apr 2018 17:51:42 -0700 (PDT) Received: from localhost.localdomain (91-159-194-103.elisa-laajakaista.fi. [91.159.194.103]) by smtp.gmail.com with ESMTPSA id m4-v6sm22222lfg.69.2018.04.26.17.51.41 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 17:51:41 -0700 (PDT) From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= To: ffmpeg-devel@ffmpeg.org Date: Fri, 27 Apr 2018 03:51:36 +0300 Message-Id: <20180427005137.6220-3-jeebjp@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427005137.6220-1-jeebjp@gmail.com> References: <20180427005137.6220-1-jeebjp@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/3] lavf/dashenc: require experimental mode to be enabled for WebM X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" It has not ever been working and has not been validated, Additionally, mention that the segment file names should be changed to end with webm instead of m4s, which is utilized for ISOBMFF fragments. --- libavformat/dashenc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 4f8f61b704..45f7830aec 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -966,6 +966,16 @@ static int dash_init(AVFormatContext *s) s->streams[i]->codecpar->codec_id == AV_CODEC_ID_OPUS || s->streams[i]->codecpar->codec_id == AV_CODEC_ID_VORBIS) { snprintf(os->format_name, sizeof(os->format_name), "webm"); + + if (s->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) { + av_log(s, AV_LOG_ERROR, + "WebM support in dashenc is experimental and has not " + "been validated. For testing purposes, make sure " + "to add -strict experimental and override " + "-init_seg_name and -media_seg_name to end with " + "the extension 'webm'.\n"); + return AVERROR(EINVAL); + } } else { snprintf(os->format_name, sizeof(os->format_name), "mp4"); }