From patchwork Fri Apr 27 00:54:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 8665 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:155:0:0:0:0:0 with SMTP id c82-v6csp70836jad; Thu, 26 Apr 2018 17:54:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpxG2pvxBzTceIW2AN7fWKuKaNLOm60TzYjCFt9Es31hny+JEK6dwuHya2k/ZtolKkfLUPT X-Received: by 2002:adf:a3c7:: with SMTP id m7-v6mr132014wrb.208.1524790474850; Thu, 26 Apr 2018 17:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524790474; cv=none; d=google.com; s=arc-20160816; b=oCxW4g3KA6M7/+c3D4A8Rfo7frVdcPj9U5ZVdy50nfTTgCEetsK2J8QwriIDf0EdaD iXWkik6DVuowbpx8I+WndxrvBvJpNoEJ2jj3uUI4TbxjWWJXx1dvR0ahHYVl6HGRPIeV 6uLyy449XSHRpJHHgI7blWJ/F4H5TzH+vTLx+8oLKcAI2kpFw4eIDTas91LzZyo8A2vU YadN00OnhD7kyNjYyREnu3Puu9aAXpWqrgubfD1O9o4xD72CGxemtChcV2WbMMIjdDGM lf6FvtJKw1ZguF8Af3a8C/lmShOEkTMwCsaZvNAt4URouqKCSKnUI6B93pGR7eTcE44V rPHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=QYgeT9sjsI5be8Pa4E0jPh0WT6pjOTMQmnic09jh5ws=; b=XtLmoNVC4K38ON5zSQvHoJHLS+wHXo4oXuRMEyUTDFeRy6HxnsfRGWshO6SEC3qhUx jHHeUTstxLyTx8CSSxMQKRSuurKQb2Zf4fripe5WzKz65wr8wHCjrCkE2ssRPAJ2hNSx PWwE0mHi5m/TbcKROCOZ3fxDjqqGMTlc4QdeR5+pi0P/4W+fV8xzkxanMeILhOiUBlpp jKC2jAOPCZVtasb4BZ1wrm3mBYyrz9guV+YJ2E+f4y9tLT4GMjDhooxQ7q6ToPCF3Ghy 0mSRN73JSga8/0PSgiXp2Mr3YwUpId3DQNptnweowSPdfk7LeSMmr79v8wx+vUGEQYtl 9ZUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n13-v6si101512wrf.204.2018.04.26.17.54.34; Thu, 26 Apr 2018 17:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7E03768A638; Fri, 27 Apr 2018 03:54:02 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F51668A61A for ; Fri, 27 Apr 2018 03:53:56 +0300 (EEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id BC28640002 for ; Fri, 27 Apr 2018 02:54:26 +0200 (CEST) Date: Fri, 27 Apr 2018 02:54:25 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20180427005425.GJ20131@michaelspb> References: <1524719040-30542-1-git-send-email-vdixit@akamai.com> MIME-Version: 1.0 In-Reply-To: <1524719040-30542-1-git-send-email-vdixit@akamai.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Level: Subject: Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: handling copyts use case in forced key frames functionality X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Thu, Apr 26, 2018 at 10:33:59AM +0530, vdixit@akamai.com wrote: > From: Vishwanath Dixit > > Forced key frames creation functionality was assuming the first PTS > value to be zero, but, when 'copyts' is enalbed, the first PTS can > be any big number. This was eventually forcing all the frames as > key frames. To overcome this issue, the actual first PTS value has > to be considered. > --- > fftools/ffmpeg.c | 5 ++++- > fftools/ffmpeg_opt.c | 1 + > 2 files changed, 5 insertions(+), 1 deletion(-) breaks fate Test pva-demux failed. Look at tests/data/fate/pva-demux.err for details. make: *** [fate-pva-demux] Error 1 [...] --- ./tests/ref/fate/pva-demux 2018-04-26 01:45:19.589231218 +0200 +++ tests/data/fate/pva-demux 2018-04-27 02:50:51.828844428 +0200 @@ -34,3 +34,18 @@ 1, 47520, 47520, 2160, 384, 0xfddbb7df 1, 49680, 49680, 2160, 384, 0xbbb2af0c 1, 51840, 51840, 2160, 384, 0x8f03b5fc +0, 26, 26, 1, 470016, 0xead57e3f +0, 27, 27, 1, 470016, 0x787085d0 +0, 28, 28, 1, 470016, 0x3d529159 +0, 29, 29, 1, 470016, 0xed32986b +0, 30, 30, 1, 470016, 0xcdd2c5a7 +0, 31, 31, 1, 470016, 0xb271d212 +0, 32, 32, 1, 470016, 0x838cad86 +0, 33, 33, 1, 470016, 0xdb992f3f +0, 34, 34, 1, 470016, 0x88779a1e +0, 35, 35, 1, 470016, 0x6a73db7b +0, 36, 36, 1, 470016, 0x7b4e6ace +0, 37, 37, 1, 470016, 0x72d14489 +0, 38, 38, 1, 470016, 0xd5b17c4d +0, 39, 39, 1, 470016, 0x1f62ed78 +0, 40, 40, 1, 470016, 0x97f98fff