From patchwork Mon May 14 23:57:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rostislav Pehlivanov X-Patchwork-Id: 8971 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:155:0:0:0:0:0 with SMTP id c82-v6csp720056jad; Mon, 14 May 2018 17:04:47 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpMjIlQR5whXH4PojiG13GL27OTX2y2pdTRggJ2howNv5CcZYPnOKj9k5+hUY/CIi2I/3Tv X-Received: by 2002:a1c:7c05:: with SMTP id x5-v6mr5949433wmc.7.1526342687246; Mon, 14 May 2018 17:04:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526342687; cv=none; d=google.com; s=arc-20160816; b=Hd/vWdKFptYFRPv2eJzK4WSHs1Pmbxf/d/75FO+FwGuejbNx6SSr9Mn5MRDQcboxYD nC+tnu8ueVf7mwOoOdz0hpzKOiqn0GzLIaNfpLUq8sekWmzvAG3ijPssw8qmLMSLDzvK e0cXdxM/rkNdEx6QeqiZPP4Af3wN9zPBdojZVfDRuwC+IVn+946dGoivkY7rqwiMKEHa 8L48wZPJOL6Y4/DkVgoweDAgDlZyzVDV5uOdESpJ9CaStEk78pbrLGNV/k3JFt1n+17B geRzpE4Qex2shhBQjnSOx6Q1zm/2O7RYS8BaTfBJGEUlTQTa3uSKXOmUkYBGBe2vT3v1 EwdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=FMm4vYN1cP+Hfr6DFMgX3EBsnV6WQ17W7AXkdSrmDzQ=; b=fzxemHc62MYTly/Xsp3+yxPLR1lnz22GU0ktZZmsPjG+r6aQo68y8Av7P58c9Cco/+ l2FtvIDLpiEdvfbbWQfXNGxRqiAu+D9HWtLOAlTvr+lRNLy0AT/9kAyD7ZWnlGXulv4K /wY0mFn+vW56edsBbILYyj1u6unGDhZ3iMYhXFgntswu8IycSJRcN2nn1xVU746gzzd7 LkvPVFmPVn4M/qrToslC0VbJ9QmQXhkNRu1PuGCcywMPClo1x3XoQYeWy63WhjXb20+X Ke39Hcqr+nwGFQ5haagpy/Z2+5PZEMhuhxkA9Z+ENmC9P0v8JCpMxtFsWiFpQDdjav0l o1yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=Ruqy+not; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g36-v6si9254371wra.434.2018.05.14.17.04.46; Mon, 14 May 2018 17:04:47 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=Ruqy+not; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8FDD4689EE0; Tue, 15 May 2018 03:04:07 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B295F689AC2 for ; Tue, 15 May 2018 03:04:00 +0300 (EEST) Received: by mail-wr0-f195.google.com with SMTP id v15-v6so14060532wrm.10 for ; Mon, 14 May 2018 17:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=AWzncqo6M6A8tJUf+Oiz3KpBkhIuLUod9McYCxd8FvY=; b=Ruqy+notPAjIwllCHB7eP3mHv4GO1PDwng6OcSRIFvSieY626RNF5rlkb3xtYI3TAu 1CtcDFKFc8FQJGLbcY0HhnVLYehbFy6plscDyw9/kmEs658604lb8MRKHNTAUZrORHpY tZgX2wvvhZJBKZMVLaHi4fD47j2IiZX/fymoDxnK022Z+oqeAUi7+CN3E3c7YX6Aj+Nc 9JZ/6RcWX/kO3N0f5x3vGIFgOkyY+xJgTZKOlOfIDIHoItfC9EbUMJzxnn5CPnfKgDcI w1F99Ug1j5Effeyi+rqjeqdJKAzaQx+wb2LPljPLmn1VENDorZDldYZbjlzg6A5gT4k/ nYMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AWzncqo6M6A8tJUf+Oiz3KpBkhIuLUod9McYCxd8FvY=; b=pIDOgmQpP43b4I2Ou/ERkNWTYLHyn6x6m/HiaCFUwlQVtWSPPzYl9m1IqdVDjvBYpm zh+G8y0lU7OttlGw9ykioXpzbUmHVDasrQnFo70anNVgVdeZP/iSjs7L8O7DzdiQnGDm urLA579Q2iL7/nxFcBq6RqJZ/0UrvfLLrWB9sXgYpt8/ekoUz1oiCHzZl1TJB7TkAX+Z EuFoCbBbeLym0wEC0GlG6kNzoI4RFbdeCrFiRFslSVTBwhRig1YhMrRiU1CNQTFP+yt9 pMHpf2qzq4KrRdVZ9iii9kpjDKM5GOk4KijTcP03wk2tf+06yPOpRWLeA6q5/Fw4EijI SBkg== X-Gm-Message-State: ALKqPwcONGEMvnQcI4mHw9RJIniu0Wkgyr6I2gqycE1JITD2Mhs94hPf GcvPhxTXxC1tU5Ind+s5HwgyM0v/ X-Received: by 2002:adf:8ab7:: with SMTP id y52-v6mr8209826wry.98.1526342319710; Mon, 14 May 2018 16:58:39 -0700 (PDT) Received: from moonbase.pars.ee ([2a00:23c4:7c8c:8e00:1f2:da18:35aa:ab1e]) by smtp.gmail.com with ESMTPSA id t46-v6sm14666239wrc.95.2018.05.14.16.58.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 16:58:39 -0700 (PDT) From: Rostislav Pehlivanov To: ffmpeg-devel@ffmpeg.org Date: Tue, 15 May 2018 00:57:00 +0100 Message-Id: <20180514235700.15110-1-atomnuker@gmail.com> X-Mailer: git-send-email 2.17.0 Subject: [FFmpeg-devel] [PATCH] configure: error out on unsupported MSVC versions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Rostislav Pehlivanov MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The FATE tests for MSVC versions older than 2013 are untested in FATE and apparently are no longer supported. This commit makes the configure process error out in case an older version is used, and suggests to use a supported version of MSVC to compile. As discussed on IRC: 2018-05-12 19:45:16 jamrial then again, most of those were for old msvc, and i think we're not supporting versions older than 2013 (first one c99 compliant) anymore 2018-05-12 19:45:43 +JEEB yea, I think 2013 update 2 is needed 22:53 <@atomnuker> nevcairiel: which commit broke/unsupported support for msvc 2013? 23:23 <@atomnuker> okay, it was JEEB 23:25 <+JEEB> which was for 2012 and older 23:25 <+JEEB> and IIRC we no longer test those in FATE so that was my assumption 23:26 <+JEEB> 2013 is when MS got trolled enough to actually update their C part 23:26 <+JEEB> aand actually advertised FFmpeg support 23:26 <+JEEB> (although it was semi-failing until VS2013 update 1 or 2) Signed-off-by: Rostislav Pehlivanov --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 1f7d0140e3..9f253834f3 100755 --- a/configure +++ b/configure @@ -3988,8 +3988,7 @@ case "$toolchain" in cc_default="cl" cxx_default="cl" else - cc_default="c99wrap cl" - cxx_default="c99wrap cl" + die Unsupported MSVC version (2013 or newer required) fi ld_default="$source_path/compat/windows/mslink" nm_default="dumpbin -symbols"