From patchwork Tue May 15 04:17:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rostislav Pehlivanov X-Patchwork-Id: 8973 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:155:0:0:0:0:0 with SMTP id c82-v6csp925144jad; Mon, 14 May 2018 21:25:15 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpxE/0i2/b2Venrj5Y9t+RknvUTVzqv+dZ+AnZGiAnIYN3S4c9ZXpAHqXILLdBvAf9SVSgA X-Received: by 2002:a1c:eacc:: with SMTP id g73-v6mr7352700wmi.137.1526358315641; Mon, 14 May 2018 21:25:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526358315; cv=none; d=google.com; s=arc-20160816; b=ObeAkX3B08ioSrqqH9xQ3gFLsh1u2jLJkLGlhuIsZBxKpKzM3+kkUGyBzfh2OaL89E X54x3WjHZprtMzGrebIeGC/k/XAt7LXasuKST/L+EF3s+4qaLoH6Bxe13OhsPmLm7PD8 8EFxC73TzbSSbBLQFHxbW8VzVnstkdY9fWBHNW/kC7mAlzDo3IehspMPU57TOebJJj1C +jdM43vQaSpOAHNL3NR15s/67/o2OaFqIK/0ftK3r0oP6c14kn2My44Dzrhervh7R0Zz Adm7/fXzciywerZ2GRwyBX8bdh9VweqqRTYp2XQCRnUXWGXg0ebgVV3S6DBrXVRKwlVt MT5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=JCUYj9rCcpUHlNMFbSsH1+JJYZYUjOdvIlBYve8T1tg=; b=kykvqRY6HMfhEhaeQeNfkFBOWb1+goTC5JBB/8M1CDSkhFrp64oicqP0vUwQB241+E oyZEmcDyl0laSSCM8zNXfrLN2vUplDC509X2Zj681Tqv6XDpoKSzlj+eDIiNeSpwElnC 5Z3eHv0/5gyfmwH86w/ywGycMUfhbdrun9beK+jxmlk3awwo2/UkyFxHj2G+drJwt4PY Xwcq+K8sKDcvDLKZf2ZjIWZlFhlx0VsJxogseoTWUt1mkkRUkNbH5+LYDiP0DmVnJ/Wt O+ckaOUexLCSdsCxpNmiEUZhEorCiZUdaVBfVI+TBPyczs3+xhNu/4/mDe6u1vO4e3/F asfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=WiF/JgvN; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 63-v6si8913309wra.165.2018.05.14.21.25.14; Mon, 14 May 2018 21:25:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=WiF/JgvN; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B8F19689F10; Tue, 15 May 2018 07:24:34 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4D11F687EB2 for ; Tue, 15 May 2018 07:24:28 +0300 (EEST) Received: by mail-wm0-f54.google.com with SMTP id j4-v6so16964376wme.1 for ; Mon, 14 May 2018 21:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zW2Whi7VhJEGTU77Fv8DYGHQrfwYKSFFbpeteHSeJ1U=; b=WiF/JgvNRvb6FwQ48MIK9M2bdPt41ogyJg5qR6hTC/eYzUezO7QDnIjOCt7WaNo3jg M2SUPAQeEem9LLabGjEvIVrHYYEMtGXeXX/bqZc8O3rI5STyOKGwwwWFHDv3lXLJdjBW +Vhmz+gOBAh9hpzYNTsKieFE6Oa4oj5GvJNk2LTmrc6E5InqD4kTtadcMQPGrlCAHvd7 E2zYy/cB7PX5/n35XQcVngk+qoy34uM8Ze0uh7TOp3pty/dVycKy4xxkxV+oX3I0NvbK xjOtQ8Xl3/7Z0n55dPgYiFLzvDgCe6vtuWTfz9JsVv6LuBPIk98DiEVUfFhDziOD4Y+l 3Vgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zW2Whi7VhJEGTU77Fv8DYGHQrfwYKSFFbpeteHSeJ1U=; b=QxQuVmWKcxsY8AQUZQU8elnvx7guhvLu53XgjP7BUQgBlBymH9sarsbS9f9xVoH5kC g6HKQxyaM7gWUz7seW0MBhTi0rQ9xJgsD55Tb860mYyCfXIzE3oGGLPa75e9kQldh9K3 Xk1dUuoVUWABHCCKHhhhPz5u5lL+ZV+VGl6f6rZy5uf+DZbkqpZPL7qQPicQ3GBr8gQ5 AZApRmUk3DtGxMbgacK+TOgTxsqYdyB99PBFWOVQasWSPOcobaEHtKexcvPUpSAAzifb i6i+4xOUg+7B5EtoHTb0iuen8oMnT3LZtVvFJAtYfwUWMkmtLmzfqi21oOlPaa/8ZrzX ImMg== X-Gm-Message-State: ALKqPwdqjiBMEzF0I9EasW81PEmSx7/sOjqT6tEMhuAezUEcsO9z7ZAL 7Ee7h033aAS64dzkvx2L+l0HzYMQ X-Received: by 2002:a1c:59c4:: with SMTP id n187-v6mr6804101wmb.51.1526357940471; Mon, 14 May 2018 21:19:00 -0700 (PDT) Received: from moonbase.pars.ee ([2a00:23c4:7c8c:8e00:1f2:da18:35aa:ab1e]) by smtp.gmail.com with ESMTPSA id f143-v6sm12740423wme.43.2018.05.14.21.18.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 21:18:59 -0700 (PDT) From: Rostislav Pehlivanov To: ffmpeg-devel@ffmpeg.org Date: Tue, 15 May 2018 05:17:19 +0100 Message-Id: <20180515041719.5366-1-atomnuker@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180515014242.GV20131@michaelspb> References: <20180515014242.GV20131@michaelspb> Subject: [FFmpeg-devel] [PATCH v2] configure: error out on unsupported MSVC versions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Rostislav Pehlivanov MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The FATE tests for MSVC versions older than 2013 are untested in FATE and apparently are no longer supported. This commit makes the configure process error out in case an older version is used, and suggests to use a supported version of MSVC to compile. As discussed on IRC: 2018-05-12 19:45:16 jamrial then again, most of those were for old msvc, and i think we're not supporting versions older than 2013 (first one c99 compliant) anymore 2018-05-12 19:45:43 +JEEB yea, I think 2013 update 2 is needed 22:53 <@atomnuker> nevcairiel: which commit broke/unsupported support for msvc 2013? 23:23 <@atomnuker> okay, it was JEEB 23:25 <+JEEB> which was for 2012 and older 23:25 <+JEEB> and IIRC we no longer test those in FATE so that was my assumption 23:26 <+JEEB> 2013 is when MS got trolled enough to actually update their C part 23:26 <+JEEB> aand actually advertised FFmpeg support 23:26 <+JEEB> (although it was semi-failing until VS2013 update 1 or 2) Signed-off-by: Rostislav Pehlivanov --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 1f7d0140e3..e52f8f850b 100755 --- a/configure +++ b/configure @@ -3988,8 +3988,7 @@ case "$toolchain" in cc_default="cl" cxx_default="cl" else - cc_default="c99wrap cl" - cxx_default="c99wrap cl" + die "Unsupported MSVC version (2013 or newer required)" fi ld_default="$source_path/compat/windows/mslink" nm_default="dumpbin -symbols"