From patchwork Thu Jul 26 22:30:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 9812 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:104:0:0:0:0:0 with SMTP id c4-v6csp126195jad; Thu, 26 Jul 2018 15:30:44 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcLKNaTbgWaxpFfGNZNeLRJzLivGcQzrnZAJYpnNAG+/zShSvzBCPd0PKBNBB6iwRPHaEaT X-Received: by 2002:a1c:9809:: with SMTP id a9-v6mr2541664wme.15.1532644244231; Thu, 26 Jul 2018 15:30:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532644244; cv=none; d=google.com; s=arc-20160816; b=iz46MZo5PCISWJKmvp7sXoDSKBEj+Pp1eKQ1m3o2LLmV/bM8KMJZbkWtXdZjxeSzK/ 9r0q+7TxsLN4E++6ZwK27Xp1gICK2Mbkk7R+bREhA8+fZd35ixjUz4kGGUWqxRm4p8av yvTzQhA0CZdxLu10209FVAXUe9BrFWhsvJG+RdcXAWLHVMB+f4hizZ0kYTwMkXdqzItc T4EJxphRMrnAT6VmXUEAdjL0R2JsUDmP2Xafhdgslmx2BGmHWwyhIDCxlvWUHG6tZR83 Stp4eZw92Xl8Xvqw1/Jt42gj5OWH/k3VTGJDvN9An88ru7CWS8sKe42ytfOv0FwQP3sJ jqLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=ChN93BQsenyrOrkcC7AjRsZYK35FBJcKtPPhY8yvM0U=; b=sNN57E+eY7umbws+lR9Xl4/67Bz65Cl7Ahk4AC0rhoxoqDSmvPdptHfOh2tRztmHdR bbzHDTP+3kXYrHmAH9RcAAqOBUAl6S045ip2AxWMWjUF6BiebtmqI+XzMls5I28pcqu9 +ip3eF8NyehBI6QkqtD/X6k0YjIRV6xGNamFuCeBMqmT+V+GmicoHmqYYx7xxwDGjl2f p83uOUfjyw/LWQDwICfSCWcQJi8emJhlJUpKs0l00PllnP67CzghBSTGIJnwrDVmGcJ8 9/AA52yd0UblAv7IOWUbQgtY6Z1HpfEMdqITPT3gKGCyDx3KuGnu8Hl6mkfzaAnzlw4y gPAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id k7-v6si1954742wrv.439.2018.07.26.15.30.43; Thu, 26 Jul 2018 15:30:44 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3477768A44C; Fri, 27 Jul 2018 01:30:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6849568A3B5 for ; Fri, 27 Jul 2018 01:30:20 +0300 (EEST) Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 9D113240006 for ; Thu, 26 Jul 2018 22:30:33 +0000 (UTC) Date: Fri, 27 Jul 2018 00:30:31 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20180726223031.GF19650@michaelspb> References: <20180725235138.27380-1-jeebjp@gmail.com> MIME-Version: 1.0 In-Reply-To: <20180725235138.27380-1-jeebjp@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Level: Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: implicitly enable negative CTS offsets for ismv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Thu, Jul 26, 2018 at 02:51:38AM +0300, Jan Ekström wrote: > ISMV lacks any sort of edit list support, as well as tfxd is > effectively the PTS of the fragment for most intents and purposes. > > Thus, if b-frames are requested without negative CTS offsets you > end up with N frames' worth of delay (tfxd PTS plus the CTS offset > of the first sample). Negative CTS offsets enable the first sample > to have CTS=DTS, and thus a/v desync due to b-frame reorder delay > is avoided. > --- > doc/muxers.texi | 2 ++ > libavformat/movenc.c | 2 +- > tests/ref/fate/movenc | 4 ++-- > 3 files changed, 5 insertions(+), 3 deletions(-) breaks fate TEST lavf-ismv Test lavf-ismv failed. Look at tests/data/fate/lavf-ismv.err for details. make: *** [fate-lavf-ismv] Error 1 [...] --- ./tests/ref/lavf/ismv 2018-07-20 13:20:28.137581113 +0200 +++ tests/data/fate/lavf-ismv 2018-07-27 00:29:48.709348455 +0200 @@ -1,9 +1,9 @@ -a9ccbb4cd1436d222ef4425567b4e03d *./tests/data/lavf/lavf.ismv +96053075a3f60d271131fe2d0765c267 *./tests/data/lavf/lavf.ismv 312542 ./tests/data/lavf/lavf.ismv ./tests/data/lavf/lavf.ismv CRC=0x9d9a638a -440d85f9fd5b9f63c2676638782b5c15 *./tests/data/lavf/lavf.ismv +7022701b4c693bc4ffe1e9f96dd82a02 *./tests/data/lavf/lavf.ismv 321448 ./tests/data/lavf/lavf.ismv ./tests/data/lavf/lavf.ismv CRC=0xe8130120 -a9ccbb4cd1436d222ef4425567b4e03d *./tests/data/lavf/lavf.ismv +96053075a3f60d271131fe2d0765c267 *./tests/data/lavf/lavf.ismv 312542 ./tests/data/lavf/lavf.ismv ./tests/data/lavf/lavf.ismv CRC=0x9d9a638a