From patchwork Sat Jul 28 03:58:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 9826 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:104:0:0:0:0:0 with SMTP id c4-v6csp1532610jad; Fri, 27 Jul 2018 20:59:49 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcbBNQfPos5GNF9r8RJNoouAZxwf5GpSogIH4AHVz1FlYDS1m6brKnjXYSkeJATEq1lU7yX X-Received: by 2002:a5d:5201:: with SMTP id j1-v6mr7354497wrv.198.1532750388997; Fri, 27 Jul 2018 20:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532750388; cv=none; d=google.com; s=arc-20160816; b=neFJgHKX/UgyNmrmcJJInI5JO/ruHjEvjBnNrbnJ25T5VJVr0pHcvP/+rzaF72DuL7 T+al4UAdhIRpFyj0LbN0ahjajY4eFkxm8e5McvLW4i644D45iQDVqSHAxnPDnL/8kEc3 9qpgFq79Fqbgq5sKWTo8A9Dp1vRTGhZXJq5VEic90B+6psr2qa0ZkRowzZU8r4xmkoPM ZrnWzNt+PVvybddrZ/aL4wdFbSciNmndJxMwrZIp9I9v27lO26DdKn346zrMx3QG+FFP E/zZxv9aB6erexIVsUtvltPeA5G/v5ZXS9e9Q7RiRKTBfYnLJbzJfLaberwQMFXRQdJJ a0vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=JqJ0an4NKOdI13r6W5oPAsg2BwpV4V4chEUQT42+wg0=; b=Gn+RU3aIw21zRyZzvicyxCeu/Cs7R+yc/+KrjU24iQMiIYBtjqP8wacyDPJ/njPvrB 4vsPBG9rCSo8AR0aKvnjkGqf7R/MeNN0mz4RL3WT5OqDr8FGdq3I+gV1Bd8rU8F6hEup RufkkTORmk6fj3Ele1V17pladRU+aZqU4a3+8pSrTqEovXQewXcNzikNWd3q/ISMIoee kv8+dYjv1xDuuo/CJpjGYbZzem1fFoap9ZwGMw0UsXRB1EyeexP/x2hpVtK3bezJwVRZ aOcHRDMx90J1EkGCjIjCPoN1up0+3fn1ldaEDoxn4RXKau/Hzgk4xZh+ldLpT5EdnNwO J4Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=Tl99syvr; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 139-v6si4844192wms.62.2018.07.27.20.59.48; Fri, 27 Jul 2018 20:59:48 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=Tl99syvr; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C19B268A567; Sat, 28 Jul 2018 06:59:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4D8B168A4EF for ; Sat, 28 Jul 2018 06:59:25 +0300 (EEST) Received: by mail-qk0-f175.google.com with SMTP id b5-v6so4621722qkg.6 for ; Fri, 27 Jul 2018 20:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=06y+Nuo9yctGbaiM/g27x9aH3S7pFmoMZttpXFz4siQ=; b=Tl99syvren68xPdiYZd2vZEI/ERt3p0F34SKptxvZmEWlYrUS/mtsrd+Qy+ZX77NMl IcHT+yxIzEh4hWpXq109d60XlcKXqqQU4wLfZsVBkna4TN3dx6pc1YZz1tiU2QmKJ058 0JgfBbUqK5hsFNut0XE+N9XQBfigYaU3LY6skvV9RTnKBps622gBVxZrlUxQBkIT7aiH tRTgA4+fzxCnl2Qj+MELI5HGjDLgXSbzu+YKwIsEWUdT1QU/ED9NaDM5XyNbgVH2F41f JMqlCPUI537OGgmEuR9HEi8UT6NLyPhPpGBy+JWDG9o1K7Bh7BFtmlEOwsopMbll80RG j3Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=06y+Nuo9yctGbaiM/g27x9aH3S7pFmoMZttpXFz4siQ=; b=Tv9kdAO1kjF6fdPFDWiKBMrHsJ0FHTbwJN6tRw8sgOcHD8RIxjCg06xULS1Nxid9C1 S9Fd0wijGdRxKwEx4+sIswLYUhhoOXtUJY7+UdqCMxd/H3XhDhF7L43y+1bRbLiA/gsS 1nbR91Oy1ODcCchiX1JpQaemhIt8Tqd1HMsVx+4+bkpKxid06KFuwSOkjPNA10yZI8Eu LfTjdsBSyutsYu+Nx2bGqUjGrWdMlUn0SkrH5FBugX2pm9RttB/6AsSaFRMxuTbijVqb 3E6PkWkW/E/7VSZwdig5jtdNY/q7WStOPO5Q0ptbJTBybstcBWEAmFur6NpxCDUEO+fc Ketg== X-Gm-Message-State: AOUpUlFtxUOiF2H9vY8h6+k6v30NLL+EFSxeijnyw8okAoLrNnITtYye rJ76xQqoOkWwZ3OPB5aEyubPL1T8 X-Received: by 2002:a37:1090:: with SMTP id 16-v6mr8165504qkq.344.1532750379596; Fri, 27 Jul 2018 20:59:39 -0700 (PDT) Received: from localhost.localdomain ([190.188.171.140]) by smtp.gmail.com with ESMTPSA id l18-v6sm2985467qtp.56.2018.07.27.20.59.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jul 2018 20:59:39 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Sat, 28 Jul 2018 00:58:47 -0300 Message-Id: <20180728035848.1932-1-jamrial@gmail.com> X-Mailer: git-send-email 2.18.0 Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/bitstream_filters: check the input argument of av_bsf_get_by_name() for NULL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes crashes like "ffmpeg -h bsf" caused by passing NULL to strcmp() Signed-off-by: James Almer --- libavcodec/bitstream_filters.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/bitstream_filters.c b/libavcodec/bitstream_filters.c index c21373621c..3433921554 100644 --- a/libavcodec/bitstream_filters.c +++ b/libavcodec/bitstream_filters.c @@ -78,6 +78,9 @@ const AVBitStreamFilter *av_bsf_get_by_name(const char *name) const AVBitStreamFilter *f = NULL; void *i = 0; + if (!name) + return NULL; + while ((f = av_bsf_iterate(&i))) { if (!strcmp(f->name, name)) return f;