From patchwork Sat Jul 28 03:58:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 9827 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:104:0:0:0:0:0 with SMTP id c4-v6csp1532660jad; Fri, 27 Jul 2018 20:59:56 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd5jpO0IwyPR33RUjvfKMGrEKfIj5cX4uQ681IF+th+pECZRDBRKVUO2h9MhJaBaBv4TJFb X-Received: by 2002:adf:c4f0:: with SMTP id o45-v6mr7388464wrf.173.1532750396379; Fri, 27 Jul 2018 20:59:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532750396; cv=none; d=google.com; s=arc-20160816; b=RJyI4zXKGeWFCYp2ydcShKm0a0ELl1wYC2J+7S8DrDDtdIG2wB7Gnu8ksQ3CjP3LNm wUD4EyVaB9R7p8+dZ09mznKS2Ug+oxTbe4d7BXyzGwNEznJkocWgxWpMFADxR40Fxdkf FGFeQUmVt1ZWTwDS45zx2Rl9Rn57OJPaR9R4U+p8eLcsLfsGrogI6lWsQnb6emtKvwvj sGXJddCuMv6fskbVIwhxOlccEYdnSpjdItKieyEOQsbjmUYUu5qxYK+jmGMtd+1wNueQ 2xgTf7cqdf0ImxTWxolONwuK5hfHopuu0PgRPX5kEz7kF+wMaArXweF4sn7uZ1MG4wX7 DvGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=7ZKwLQK6L0fFcYSqwz1ugKANXfNviWLYtMB2jU2yWTA=; b=guBjaI4B49u2ZFnVOjBsY3eMcY5fRWcqSlSibje9WycM+MehxuXr5CCKa/G7vK0o0X gJHWtxaS1RJveuUN8HU4GSyWrbuL/WRS9rzdQ/7e2ugWbtuZo2J0tli4SctUOMphZXr4 Li/udPPgbe+liymRzXSp4hRCCzNs4nUxRwi8FhU0MbirQg3Ga6Blv9l4/g/J+tOCZMqu YNCCBeFWexqbz1x8FVdyBUJwI3kt+Ghkn1KWY22weTvUcz1pPMwQ8VKct87Wv1NdjkRw xuSvq0cLo8IKSaM302D0MHA8JRRhPiEimgxQ8tEJMiJgbX2QOCeKDRfPMZD6j7hNu9Ws jejQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=e8ixceQI; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q142-v6si1338916wmb.71.2018.07.27.20.59.56; Fri, 27 Jul 2018 20:59:56 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=e8ixceQI; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 600AE68A585; Sat, 28 Jul 2018 06:59:33 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk0-f171.google.com (mail-qk0-f171.google.com [209.85.220.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3E2D968A4EF for ; Sat, 28 Jul 2018 06:59:26 +0300 (EEST) Received: by mail-qk0-f171.google.com with SMTP id d22-v6so4608237qkc.8 for ; Fri, 27 Jul 2018 20:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=GozM6dwevOBGG04PE4Ft7awwX1mWIhyO4n5DFvTykXw=; b=e8ixceQIxhqna6sG+0PsWlV9yz5GFxPHMZsboyXE4R2EcOU8v4J6C7Bzxt+XycjoxL vpbdbNnbYFyn5na/y5J4vT85g/T0SkokdEWdDS8rTUPQe7QurhgIWH68DZ4QKNMVAsx1 6lpH71+zVRQox87xPM6+3U4OS6N91evkUHXLtTS7oGtIsV82SzNbFKJcapdFok3/BKGB FW2s2qCYykDQ20QRLMZa9W9CXznHGwiFLORb8OkevlXJNA80akt8SZeFfLbusKMS/Wjf HTNxkvupn607GqO2eKJsOjLAxUR7EMcTcCD6o68WHKvhgZZAtg7nJ6aJLOEA5zmSVxMZ gqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=GozM6dwevOBGG04PE4Ft7awwX1mWIhyO4n5DFvTykXw=; b=BL3fYCXx8oaQfWK1te1SHkS5r7zpMEwPS14fTm5RWp35kWRDSoPe3QSJG8RDZFv1fc Q/6Z5S/jEvtNylpHPkJjG5QzzktEv0zz0w2cv8AC+q6aM6kSWwxiCII5gvT/LFBCUtmm Sd0+q6dUHiEr3cd5Xyfv4TnAeQdYvf71UYfdBRmvCyhXidXUYrKnKZn0VYQyl/dxY+cg hDaIISFCubF+gEYMwQJK8D2JNucTQw7hpsAulsMsFhkouJUgQicPRjMPgRYAXbGG3Kqy 3eKziDmrb14VqYlwyegtn0C2fZ1I7dyFJXfXnSwRjofEXlIKIUNt//HfSySJUhl86z3L y7+A== X-Gm-Message-State: AOUpUlFQLl4975bvA3hUjUb97tRnyHKM7OlGA91dJS6Ddkvv6R8onoiE vvWoLKMnX+v1uBho/ze9rFoM5js+ X-Received: by 2002:a37:7304:: with SMTP id o4-v6mr8255625qkc.356.1532750380738; Fri, 27 Jul 2018 20:59:40 -0700 (PDT) Received: from localhost.localdomain ([190.188.171.140]) by smtp.gmail.com with ESMTPSA id l18-v6sm2985467qtp.56.2018.07.27.20.59.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jul 2018 20:59:40 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Sat, 28 Jul 2018 00:58:48 -0300 Message-Id: <20180728035848.1932-2-jamrial@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180728035848.1932-1-jamrial@gmail.com> References: <20180728035848.1932-1-jamrial@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/2] cmdutils: print a more descriptive error message in show_help_bsf() when no bsf is specified X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: James Almer --- fftools/cmdutils.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index b8de319fe4..9cfbc45c2b 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1956,7 +1956,10 @@ static void show_help_bsf(const char *name) { const AVBitStreamFilter *bsf = av_bsf_get_by_name(name); - if (!bsf) { + if (!name) { + av_log(NULL, AV_LOG_ERROR, "No bitstream filter name specified.\n"); + return; + } else if (!bsf) { av_log(NULL, AV_LOG_ERROR, "Unknown bit stream filter '%s'.\n", name); return; }