From patchwork Thu Aug 2 19:10:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Wegner?= X-Patchwork-Id: 9876 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:104:0:0:0:0:0 with SMTP id c4-v6csp2427735jad; Thu, 2 Aug 2018 12:27:21 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc9YBoYir5S+hc+EAeMZ2+yTjtZFbHjCfyaV6d8sCrf9tJV91FZit6RiLaxsc17qL+Mw6o2 X-Received: by 2002:adf:8bd1:: with SMTP id w17-v6mr532370wra.283.1533238041374; Thu, 02 Aug 2018 12:27:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533238041; cv=none; d=google.com; s=arc-20160816; b=gWGrSIjZgICvEmjBYUUt5rL4b1gSeIWhNOy7SYPB6BoWXowBEWPIUvD3ExsS+DgXKM W8mzx26ms1ay59PMF2pUE+rYOQKUI1gTCY9SC2J1+8Cru7yWv51tJS3+VUUwxSPXRh4V WIh1r/F3SI6nvNaGtJ1fqSh4cfPcck9pWZuLQlCZxiK/mO7nOXk5QlS5rx+Vidq5p75Y 5wpx488TpXv06B/Ev6bfys7WRsZLRRFyvQ2ERuxN6Lma4tmVnW+XCbY3GEZp7LIYXg0y mkZ9/9E7CUFKc5X/vjVs7MPyWUE6NbQVXMnsc7Eu/p0HDsobJQn+IhQ5jrMojrfdFo5z aZiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=rSivU+9ykCpKZrduzf0xZMMRhHJIfeaZxFxJhqfI05A=; b=jG26wFKOPg1lGH1jM4AsWHoXqaP7rHUoVid/Y2t57fpYHmxwjMo/kEKkHNosajOPkI iOliD4GItAG9M3TQlx6PdOz2BVecFAiU4PUj75XpGwdySe1BBK1xTHdHFN+cSxoMZifd Sx+V+sNcAfXHW3FuGhtfFjYKW5G9flszsjDz7SLEwTknZAOTL/KFtJCEK9jUvSdal3lg nEBRHbATLoUr2+lbQPyZSzyXL4MEeXoxhE9Bzsn5IBqI8IsuGJjfuC2jWU5xOs+26dvT Si/XcXE3KJYYJysw8cChHij0OHBWBFqKAmtpT5Zq5OI8wvC/6SGKBy5EDoR7Zncg9JLH 8tVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=OnfHh+h9; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 126-v6si1949534wmb.52.2018.08.02.12.27.20; Thu, 02 Aug 2018 12:27:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=OnfHh+h9; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8DE67689C61; Thu, 2 Aug 2018 22:27:01 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 916C2689720 for ; Thu, 2 Aug 2018 22:17:00 +0300 (EEST) Received: by mail-lf1-f68.google.com with SMTP id g6-v6so2326594lfb.11 for ; Thu, 02 Aug 2018 12:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Zu0M2p1C6l3RbQ3sZc6PR6OgjzA/duNLaXNOI9nRBX0=; b=OnfHh+h9BcJQxtoBwMbawBXDyHW29RqgycXaoLvj7k7VxlAwQeY11NJ2vtWRdJFwIS PpWkdghQdbgWk3wK4G/LnaB7nwMDuAJbvifMi6M4c2vLyz3u7mRbb2lEuHkN6UZjwxK2 ibkUSf1ogrEi/ebfniE3lENQ9ozugCkNU4qkLdb8M2Vv+29S5pwLb6O9fMvoKiqnoWRF T6uykGyUc3Sezu6hh2AdOAYKupK1Uuc60DFoRd6A7hTNDsiVS3Tfx1Swna8D7fstmle3 kh+op4To2pFDGOFHvfkrmaG6XmhgzP+SiuaakKDOITQqki6XyJgLoq6Rmqc1+eZj0wHM P9OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Zu0M2p1C6l3RbQ3sZc6PR6OgjzA/duNLaXNOI9nRBX0=; b=W3E8RKxJZRX0y8+j8al0FAnUWwk0HcVLMn76Vx++QR1nB7MN55GKoyLzFmzNmTPZNq 0z2U0F0WzIGpqXslBakHtuHBTkixQuvSQbE6XFMss9P1gNg2NsGZqEnqWx5lpXzv/r2y QMNT23soESvltYGNVc02rzMoyZbNhMzebijGNpWmKKkXNhXB7LbYtN7AvX7ThKoVKwOY N6uf/SJAzQ/NyZxRv+L5G+jL78RmCWPwpQAwyWGts9dy/ymSFF9oG01HvDXp6rEhwatX dzATv7tCDkN2qu3U6nmTPNIHBYas1Pd2slzFrdkaeJZHnWbg4tbGn2735hOc4kyanjlC 1Zmg== X-Gm-Message-State: AOUpUlF3ZfIx0FqRuastM6ozq2hl6BJ+5JG51tY0EHcCoxY9xCIgyKEC 9n00sn6HGslHGpOwIFd0Rsh7Xo8w X-Received: by 2002:a19:4b90:: with SMTP id y138-v6mr2544066lfa.118.1533237033251; Thu, 02 Aug 2018 12:10:33 -0700 (PDT) Received: from localhost (host-46-186-85-74.dynamic.mm.pl. [46.186.85.74]) by smtp.gmail.com with ESMTPSA id d73-v6sm529514ljd.70.2018.08.02.12.10.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Aug 2018 12:10:32 -0700 (PDT) From: =?UTF-8?q?Pawe=C5=82=20Wegner?= To: ffmpeg-devel@ffmpeg.org Date: Thu, 2 Aug 2018 21:10:05 +0200 Message-Id: <20180802191005.4489-1-pawel.wegner95@gmail.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 02 Aug 2018 22:27:00 +0300 Subject: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?UTF-8?q?Pawe=C5=82=20Wegner?= Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes: runtime error: passing uninitialized value to FreeContextBuffer causes a crash Signed-off-by: Paweł Wegner --- libavformat/tls_schannel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c index f41b007773..6b51c1f3dc 100644 --- a/libavformat/tls_schannel.c +++ b/libavformat/tls_schannel.c @@ -154,6 +154,8 @@ static int tls_client_handshake_loop(URLContext *h, int initial) SecBufferDesc inbuf_desc; int i, ret = 0, read_data = initial; + memset(outbuf, 0, sizeof(outbuf)); + if (c->enc_buf == NULL) { c->enc_buf_offset = 0; ret = av_reallocp(&c->enc_buf, SCHANNEL_INITIAL_BUFFER_SIZE);