From patchwork Fri Aug 17 10:04:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Wegner?= X-Patchwork-Id: 10019 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:104:0:0:0:0:0 with SMTP id c4-v6csp563445jad; Fri, 17 Aug 2018 03:05:09 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZNzceG9HnjdUjn/HNuIrD3h4tKk3a0uAoZ8ZrIjGfg6LoR2MElntgX8BTIRY+/ibX4MgIs X-Received: by 2002:adf:eac5:: with SMTP id o5-v6mr1353496wrn.150.1534500309618; Fri, 17 Aug 2018 03:05:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534500309; cv=none; d=google.com; s=arc-20160816; b=oVC8sHc5ESI0BzT1MH22SQslX8fUWUhPeN5UdopA9+25sIqeowYSoJpYzyCOVozriF 02SzO/YiN6lCz+pdmwjbacCdxM4AjP+QeOHG71cvnaZjs1cDtLYJkECFIxiVz5+TtUr3 HLciEq+mGmeb0A7hiRRj6IO3BakUieVtaisUhN4bViUh482BTLK6h1enXbd1s6J9Euoh 9WXibJ7oNX+fPUGXuMkwMwWoDkzLc/aFXgXfQwuETTFNKB8Cxa6eQSfUeRV6D0hUyoon gcKJg9iYD48ypxH8JQ7IRoYci89sLpcSmYVcVT9fFI8LzVIzbefK4tcuK1It5AFkXuob Fkxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=OqYQSUQZ8Xf33KJ94eUS1PHKgphpNuV+R/cEnVEaw5w=; b=KODbYYL6Lm+VKV/cHCMC4iafnQB7LmnJSQcmbtAn1gNbh2hOV0CKPeXWYlXaz6WLNW QkKfLd348b5NLCGOhhb9l6okFU1PrHY26d9D7A3TxCb8sluZhS0PcJ5cG14YuMmEcC3M G7t82AFFiWEIJ6x6+dgoLNiDcm3Zy79j/V6w8WrOu11h1JYqbzyNQalg6dm9GYY4dxeb NBhvti/1m5sd62uxfIYFxglsTaAlg0HdK6HGUOkruvFol9payfWlVXkvFGcg9JwA478r x3B00tI6EF7K0vHwAjqh8YTsQLnCYVW6O0TJ1MzHh0JB8QRxuJ3KK4BqFWx7hrJZw5i2 6p9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=E7fKJPdP; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o54-v6si1607136wrf.97.2018.08.17.03.05.08; Fri, 17 Aug 2018 03:05:09 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=E7fKJPdP; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B84BF680D4C; Fri, 17 Aug 2018 13:04:41 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C5915680296 for ; Fri, 17 Aug 2018 13:04:34 +0300 (EEST) Received: by mail-lj1-f194.google.com with SMTP id q127-v6so5919772ljq.11 for ; Fri, 17 Aug 2018 03:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v9/OjIzuRxZuB7HYnNU0U3bZVw2WRza0kYZs+FVFc0w=; b=E7fKJPdPdzF9j5lXupSI+sU7G6KdGw97wWX23P5aLz/bORbE+jK2fZ+YyBSJbSZb9z 5o03SiWah0cYH6XwRMPbK3tklcgwWmnRXTaeaey4Alq77JpiqsV28AuJD5ZjHx4aZk9Q rntzNKzDhcCz4p0LxQIEoz24EsG3IvRi+hSdu10gHturitPqb92qxhYtJ/yLlu3CepZz uebMNj10Ox9JBJo4SjrCswcmEBnHi5vd408v+ZaHgXGCq4kdJ4yHuVh78xQuPgDnV3CQ zYHbxHXecav5MpInPUWzMzAB7CzUAJlm23WsZ2+InADd1d1t1aAFkjYqNAmjr5L2FLOs JEZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v9/OjIzuRxZuB7HYnNU0U3bZVw2WRza0kYZs+FVFc0w=; b=eeNWEDmZVRzPt7IlIAofXFP+mA3vHWuXa59F/1/dcPeU9gPOJmqr4f6E5i2/+rE6AX ajPt4GIDIAKr1AqWG4dklE0vItH91FHdZ8CpeE3ZSPqAKPsxLXzwpCA7EXODHzYrWNHa KzFcvXqINYNwoHxLflFLwzZOnWYeKd7FOSH0vXCiOcbr8+bjKb8G3xamqwA8zmyOzamI 8iZrMRBPxb1iDURKbbBEc0nP5gdpaH9LST2T9yl0akeQPh4vFHe0ifOdonxTtt0q0CLN olPRrHZoyfXRV3qV50yR3n368yzD8/l/0frZopjyo27zJ3wKlXoANaUoqPezVUNnfM7N Upwg== X-Gm-Message-State: AOUpUlFLIBfhXTIHR2PISCxbqZSraB3ALTLUbiDaqUlPGZeq7sAr4IDV +9MbC/r6xjMhn2N0HCEHentS/XaQ X-Received: by 2002:a2e:1517:: with SMTP id s23-v6mr24863715ljd.73.1534500299654; Fri, 17 Aug 2018 03:04:59 -0700 (PDT) Received: from localhost (host-46-186-85-74.dynamic.mm.pl. [46.186.85.74]) by smtp.gmail.com with ESMTPSA id y6-v6sm240615ljy.42.2018.08.17.03.04.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Aug 2018 03:04:58 -0700 (PDT) From: =?UTF-8?q?Pawe=C5=82=20Wegner?= To: ffmpeg-devel@ffmpeg.org Date: Fri, 17 Aug 2018 12:04:51 +0200 Message-Id: <20180817100451.9294-1-pawel.wegner95@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?UTF-8?q?Pawe=C5=82=20Wegner?= Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Yes, it will work. Fixes: runtime error: passing uninitialized value to FreeContextBuffer causes a crash Signed-off-by: Paweł Wegner --- libavformat/tls_schannel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c index f41b007773..4f0badcb8d 100644 --- a/libavformat/tls_schannel.c +++ b/libavformat/tls_schannel.c @@ -148,7 +148,7 @@ static int tls_client_handshake_loop(URLContext *h, int initial) TLSContext *c = h->priv_data; TLSShared *s = &c->tls_shared; SECURITY_STATUS sspi_ret; - SecBuffer outbuf[3]; + SecBuffer outbuf[3] = { 0 }; SecBufferDesc outbuf_desc; SecBuffer inbuf[2]; SecBufferDesc inbuf_desc;