From patchwork Sat Sep 1 23:18:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 10200 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:12c4:0:0:0:0:0 with SMTP id 65-v6csp1091015jap; Sat, 1 Sep 2018 16:19:12 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYpEewLZn7kCC9bqiyXG0fZg5H1NW+N7Oxq8T8cFqg/TV+917F1015uutJ1JlhZWw95RicV X-Received: by 2002:a7b:c086:: with SMTP id r6-v6mr1554473wmh.119.1535843952531; Sat, 01 Sep 2018 16:19:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535843952; cv=none; d=google.com; s=arc-20160816; b=UJL2ct+6+dPAdmfLZMnS1qdCBDdNa/gyIwnbBRh7rWNeKd8/gbMKPZ4/LzW2A6xbvm yJdvxtAtnib6kw/RnbTXvkwJZzrCgDST3nfkr+HfRcqBRqBcZh6DbGVLFH02QvCbekw0 Krj4j7qYrf+REfkHUSocvwIxNodCKLfS/5QBRK0apT/D2vP+Dtz4VAN+wunRaBydabsD RSk5W3xvuXU1yAK9fLmcSPnki9iBqJl4WRFIDk9oqgfhC1pvjr/PQh/SwC1Mjxxvqy2Y nA15sv3zN/a7XaQRnN0Q7FkTE63JdvXuyA2ZcP+sJ/mFRj5jGP5YG84agqkIiD65dAOW vBEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=O1iYFZ9VcdeSA/M4/3qx6ABzcIQWUIB6Eg3KLfytLgw=; b=E+Mk0oqidiOTG2OVyGdWa/wQGEe//XQL19xRJex1qOgxZZgfTTNgmyXBlsoErenr6V +jAJCLa5BWjU8176ANkMPekBI8OuO0Q2fA0z6cDw4Y1lxE/PiJuKNwE5GzBWlt8SS//4 PlOW44R85MQdS+dNOzTykSKd46uIzc0xLXVijmpNXqD0A1ctFfKCQ/oXAcDW7mYvjdeb BC0chE/FRwWJqL8VPj7izTPnsW1IVUlgi8v/a73u2RwVFwRXrT4KWv7DDZp6FspTF15o hpbjgBnmQ0Sn1lg046sBRKhHH870DS6MYthsF2Rml6dW3GeenP6Yl7LnUZe/xltEGavX hqvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=Tr+ZSwOa; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c189-v6si5890170wma.66.2018.09.01.16.19.11; Sat, 01 Sep 2018 16:19:12 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=Tr+ZSwOa; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EF652689BF0; Sun, 2 Sep 2018 02:19:03 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9FA1B689AC3 for ; Sun, 2 Sep 2018 02:18:57 +0300 (EEST) Received: by mail-qk1-f194.google.com with SMTP id z125-v6so3661598qkb.12 for ; Sat, 01 Sep 2018 16:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=mcAHjLzPTkQs93BFznMAAaQ3yOzRS7VtU+haB/p83s0=; b=Tr+ZSwOaE4nBMUJ1T0wiNNE4KzoHD4hbGhxMo8DaCPqdeTaWVsOQB2bR+SPt1jPXoL wYEmNDD3lgCVUighO5SlW19XT0zp50jOwvy7RJWnDj7+mO1wyQhTqFEkmV+ZrLsK+Qnh GFmb57MS9KMJg1b/5er/RDPjgUx/mtqvhVhev0S9N+urz1JWMzGbQoTx5pi4y03+MxZ2 HWZYkU+63N4N1Z87QcdNK8/H4So6JC4vF0ke9/xGntFugOKR62Ny9pdr9v2BN6WGaePO sVJpMIBEv20OdzuHe20r0uVJnBIcCIxjIh+9r32hyW6DIeJHKvQQ5LQe1mzruhmKuGya 4NLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=mcAHjLzPTkQs93BFznMAAaQ3yOzRS7VtU+haB/p83s0=; b=SCShLePWoWKSd0kkb+pi5Hs1ZF25AS04HjUx0gqHEdL5bKVxj+iXwmWaoQY+7h4Fwa 6ZMaCEfbSIoFQOX270gf/JstSCqZOq+ASivV6OH52Xsn7lC8hlvkZi3/PjUeAM4J4Zhf iLV61KbVSW8bdtOy2/v35bNkWgPtPhIG9fOoeDw1DQQIavW+wmfvmYG1OslraucuD6tO LKmSDKc9PIsr3VmionsvGDV3D4kzZRvpi/Ftg8AvI2/2Jk8wsmn9SNl/sePpQeILDfc2 II5osjLHzOauuYiZ29vKu4vj1axxXSb3c+ivo4nS2hJf5wQTjPhiR6ASAbc3C/IGI7BW 0DIQ== X-Gm-Message-State: APzg51DF8InMEGbS9GJ1zuyHinAiMksfbYQrawUweXP/SjzDgFcCfaDc jEDU9aqsZiPUPeqp4FwnvJq8YUbT X-Received: by 2002:a37:3309:: with SMTP id z9-v6mr20098461qkz.172.1535843941873; Sat, 01 Sep 2018 16:19:01 -0700 (PDT) Received: from localhost.localdomain ([181.231.186.237]) by smtp.gmail.com with ESMTPSA id b18-v6sm8923417qtk.92.2018.09.01.16.19.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Sep 2018 16:19:01 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Sat, 1 Sep 2018 20:18:35 -0300 Message-Id: <20180901231835.1404-1-jamrial@gmail.com> X-Mailer: git-send-email 2.18.0 Subject: [FFmpeg-devel] [PATCH] avcodec/utvideodec: use cached bitstream reader only on targets with fast 64bit ops X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: James Almer --- Unbenched, but if x86_32 is slow with it, then chances are so are arm and similar 32bit architectures. It may also be worth looking into just making HAVE_FAST_64BIT the default in get_bits.h directly. libavcodec/utvideodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c index 3891df3570..542b051e45 100644 --- a/libavcodec/utvideodec.c +++ b/libavcodec/utvideodec.c @@ -27,7 +27,7 @@ #include #include -#define CACHED_BITSTREAM_READER !ARCH_X86_32 +#define CACHED_BITSTREAM_READER HAVE_FAST_64BIT #define UNCHECKED_BITSTREAM_READER 1 #include "libavutil/intreadwrite.h"