diff mbox

[FFmpeg-devel,2/5] avformat/segment: fix segment_time_delta option min/max value

Message ID 20180930204513.26772-2-cus@passwd.hu
State Accepted
Commit 3bfd409e59e8ce9f168bfa07f20bbe869af37522
Headers show

Commit Message

Marton Balint Sept. 30, 2018, 8:45 p.m. UTC
Signed-off-by: Marton Balint <cus@passwd.hu>
---
 libavformat/segment.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol Oct. 1, 2018, 7:13 p.m. UTC | #1
On 9/30/18, Marton Balint <cus@passwd.hu> wrote:
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  libavformat/segment.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/segment.c b/libavformat/segment.c
> index 7fb4dc7d21..e2ac2c3a7f 100644
> --- a/libavformat/segment.c
> +++ b/libavformat/segment.c
> @@ -1045,7 +1045,7 @@ static const AVOption options[] = {
>      { "segment_clocktime_offset", "set segment clocktime offset",
> OFFSET(clocktime_offset), AV_OPT_TYPE_DURATION, {.i64 = 0}, 0,
> 86400000000LL, E},
>      { "segment_clocktime_wrap_duration", "set segment clocktime wrapping
> duration", OFFSET(clocktime_wrap_duration), AV_OPT_TYPE_DURATION, {.i64 =
> INT64_MAX}, 0, INT64_MAX, E},
>      { "segment_time",      "set segment duration",
> OFFSET(time_str),AV_OPT_TYPE_STRING, {.str = NULL},  0, 0,       E },
> -    { "segment_time_delta","set approximation value used for the segment
> times", OFFSET(time_delta), AV_OPT_TYPE_DURATION, {.i64 = 0}, 0, 0, E },
> +    { "segment_time_delta","set approximation value used for the segment
> times", OFFSET(time_delta), AV_OPT_TYPE_DURATION, {.i64 = 0}, 0, INT64_MAX,
> E },
>      { "segment_times",     "set segment split time points",
> OFFSET(times_str),AV_OPT_TYPE_STRING,{.str = NULL},  0, 0,       E },
>      { "segment_frames",    "set segment split frame numbers",
> OFFSET(frames_str),AV_OPT_TYPE_STRING,{.str = NULL},  0, 0,       E },
>      { "segment_wrap",      "set number after which the index wraps",
> OFFSET(segment_idx_wrap), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, E },
> --
> 2.16.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

LGTM
diff mbox

Patch

diff --git a/libavformat/segment.c b/libavformat/segment.c
index 7fb4dc7d21..e2ac2c3a7f 100644
--- a/libavformat/segment.c
+++ b/libavformat/segment.c
@@ -1045,7 +1045,7 @@  static const AVOption options[] = {
     { "segment_clocktime_offset", "set segment clocktime offset",        OFFSET(clocktime_offset), AV_OPT_TYPE_DURATION, {.i64 = 0}, 0, 86400000000LL, E},
     { "segment_clocktime_wrap_duration", "set segment clocktime wrapping duration", OFFSET(clocktime_wrap_duration), AV_OPT_TYPE_DURATION, {.i64 = INT64_MAX}, 0, INT64_MAX, E},
     { "segment_time",      "set segment duration",                       OFFSET(time_str),AV_OPT_TYPE_STRING, {.str = NULL},  0, 0,       E },
-    { "segment_time_delta","set approximation value used for the segment times", OFFSET(time_delta), AV_OPT_TYPE_DURATION, {.i64 = 0}, 0, 0, E },
+    { "segment_time_delta","set approximation value used for the segment times", OFFSET(time_delta), AV_OPT_TYPE_DURATION, {.i64 = 0}, 0, INT64_MAX, E },
     { "segment_times",     "set segment split time points",              OFFSET(times_str),AV_OPT_TYPE_STRING,{.str = NULL},  0, 0,       E },
     { "segment_frames",    "set segment split frame numbers",            OFFSET(frames_str),AV_OPT_TYPE_STRING,{.str = NULL},  0, 0,       E },
     { "segment_wrap",      "set number after which the index wraps",     OFFSET(segment_idx_wrap), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, E },