From patchwork Tue Oct 16 12:16:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Lhomme X-Patchwork-Id: 10684 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 33677446E3E for ; Tue, 16 Oct 2018 15:16:50 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 834BC68A060; Tue, 16 Oct 2018 15:16:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4905968976F for ; Tue, 16 Oct 2018 15:16:25 +0300 (EEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 4EC4B2B2; Tue, 16 Oct 2018 08:16:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 16 Oct 2018 08:16:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ycbcr.xyz; h= from:to:cc:subject:date:message-id; s=fm3; bh=KFBYpL/Lw9inIOSJgb dcxsQZ1qgmqPClL8KfGM/DKG4=; b=bKBhiHr7tBStbC7Lpg7H7aBrTx0Ha6C05n opZDGnh5acxNW6bbTbyKNY4EMBrXBWuyyWBDBqmi9175hX5AY8AFkUx7qYITIwJ2 jjDlK7lUbmiUZMpY7LZOagSMMfz3JXY/Ywe66yBZlEAUez1keF+zPsxv/84ycyp/ yhOhR8yCUzWP+mALthCtanz1Yx3x6XWTvxdCO4DUG8BrFHcLak4R25QTQMfGX550 7YS1519Iv9kDpMg29JPUf4h0bBsWLuj58K7qvVqC6tfwyQEW4IExDgBM7ZjgHxb3 /SkkR8Xxe3oGmIlCWyt5vSeiVk48pYmCkSZ9Z8diE/vY6S0cEHMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=KFBYpL/Lw9inIOSJgbdcxsQZ1qgmqPClL8KfGM/DKG4=; b=d3t1r5+X IP1W9XVCUXJRU9Uebyv8+XzMwbIrw8ejY9fMXQy0lRuPd3PZWb3uaKoWPUqSzrKU u2ywMgEM2z+tX/oHTilrXsv2GI4a3rHEG0zm96F/yOG7CN4GcZK6ZgSDaCRgT+NA wjg2rCEtc/WWx4TazgRBD1s3eAlkvDgu5oL2gropNV6plKhKvjTyalbTusffHDTS x/7FtbLNy4NTbn49YDTj1oLJCjqQwiGp60o1eZEGJAZMTfWI7nDCaUxPtBWpEJrw +IyzfEV0M4YU0jqq03IL7YGXLT4bi1lS5DMmBXeBVA60ExAXpDRYnSIASfsd/cuS RKH57/1+VWuIhQ== X-ME-Sender: X-ME-Proxy: Received: from localhost.localdomain (229.74.9.109.rev.sfr.net [109.9.74.229]) by mail.messagingengine.com (Postfix) with ESMTPA id 7C185E4430; Tue, 16 Oct 2018 08:16:45 -0400 (EDT) From: Steve Lhomme To: ffmpeg-devel@ffmpeg.org Date: Tue, 16 Oct 2018 14:16:08 +0200 Message-Id: <20181016121608.19072-1-robux4@ycbcr.xyz> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH] ffmpeg: release the last_frame before the decoders are closed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steve Lhomme MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" If the decoder provides its own buffers it might not be able to release its buffers once it has been closed. (this is the case with dav1d). --- fftools/ffmpeg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index da4259a9a8..faf62475a2 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -4738,6 +4738,7 @@ static int transcode(void) if (ost->encoding_needed) { av_freep(&ost->enc_ctx->stats_in); } + av_frame_unref(ost->last_frame); total_packets_written += ost->packets_written; }