diff mbox

[FFmpeg-devel,3/3] libaomenc: Deprecate unused noise-sensitivity option

Message ID 20181028200819.15139-3-sw@jkqxz.net
State New
Headers show

Commit Message

Mark Thompson Oct. 28, 2018, 8:08 p.m. UTC 
---
This was in the 4.0 release, unfortunately (and did nothing there as well).


 libavcodec/libaomenc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Carl Eugen Hoyos Oct. 28, 2018, 9:02 p.m. UTC | #1 
2018-10-28 21:08 GMT+01:00, Mark Thompson <sw@jkqxz.net>:
> ---
> This was in the 4.0 release, unfortunately (and did nothing there as well).

If it has never worked, it can be removed imo.

Carl Eugen
diff mbox

Patch

diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
index c5458766cb..0c2eb6517f 100644
--- a/libavcodec/libaomenc.c
+++ b/libavcodec/libaomenc.c
@@ -71,7 +71,7 @@  typedef struct AOMEncoderContext {
     int crf;
     int static_thresh;
     int drop_threshold;
-    int noise_sensitivity;
+    int noise_sensitivity_unused;
     uint64_t sse[4];
     int have_sse; /**< true if we have pending sse[] */
     uint64_t frame_number;
@@ -980,7 +980,7 @@  static const AVOption options[] = {
     { "crf",              "Select the quality for constant quality mode", offsetof(AOMContext, crf), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 63, VE },
     { "static-thresh",    "A change threshold on blocks below which they will be skipped by the encoder", OFFSET(static_thresh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, VE },
     { "drop-threshold",   "Frame drop threshold", offsetof(AOMContext, drop_threshold), AV_OPT_TYPE_INT, {.i64 = 0 }, INT_MIN, INT_MAX, VE },
-    { "noise-sensitivity", "Noise sensitivity", OFFSET(noise_sensitivity), AV_OPT_TYPE_INT, {.i64 = 0 }, 0, 4, VE},
+    { "noise-sensitivity", "Deprecated, this option does nothing", OFFSET(noise_sensitivity_unused), AV_OPT_TYPE_INT, {.i64 = 0 }, 0, 4, VE | AV_OPT_FLAG_DEPRECATED },
     { "tiles",            "Tile columns x rows", OFFSET(tile_cols), AV_OPT_TYPE_IMAGE_SIZE, { .str = NULL }, 0, 0, VE },
     { "tile-columns",     "Log2 of number of tile columns to use", OFFSET(tile_cols_log2), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 6, VE},
     { "tile-rows",        "Log2 of number of tile rows to use",    OFFSET(tile_rows_log2), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 6, VE},