From patchwork Tue Nov 20 11:38:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 11087 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 6101644C72B for ; Tue, 20 Nov 2018 13:47:07 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C7734689EDC; Tue, 20 Nov 2018 13:47:07 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 05DC268048D for ; Tue, 20 Nov 2018 13:47:02 +0200 (EET) Received: by mail-wr1-f67.google.com with SMTP id r10so1619288wrs.10 for ; Tue, 20 Nov 2018 03:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1CNOhOdjV0dT2dF7UOqho/4bo56Hpu8cQEZCuoOO26E=; b=GIsGw5xC8cXPYS/aoN1nhZf6tq2kcc8UtKXHornsOVNukrgV5Q7AJopZCh7OyJXXw/ yBC+bpJexW23FVJvSxBbZm7iLeKfekFn2OVJwlPlt//KO9sNDEuH5yndu8vnXKijNRM3 u+uQtaBG/ONZALaQmfcaaD2V2ToXK72UiJjK1dOGdQv3XMS+etuFBhL5FTqp31wmTBCh u2FSukAEmW4dqhS8+IbmbECZagJk90p5g3GBYX7zPK9ZwG5qD9zhWMOfXepcdp+E8Wuc v/cMGhswMVIBnEvLf+ItLd1VMvOZmEvHDuhVlFOZorhnfLVfkUHRx/piMF4xLqTAC8hD H/9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1CNOhOdjV0dT2dF7UOqho/4bo56Hpu8cQEZCuoOO26E=; b=dQIaxjZqrYl+MJxbInMlixT8Ec/XaygntF7Fy8RpTSDqNuuCEiw0pId60bhBP4712Y QYQh/XESYs9LqG8rn+SG8qFScV0DCBnPOqLnWh07rozZmN2u6FGsT4PRy8psAvQ/pnxe F7T3Dwi65hxCoor7lBXPVIhZDw8Mkl070UwW3a/MZa+1HTy3UlnjsbKjdiKnMCISus8w BOcGF0tuICeKYKbi7MP5B5Ce+XDXgyb+Cdku9pagkockK+RJa5Z33012QYA2ElLPWJTf +n4SdVcYVaMZ+fKWnSGTCYJQwVQirIZI0lsjlP46P9Mlmcru2yeNT6CN6lJo7XP4eqlK ODxw== X-Gm-Message-State: AA+aEWYeIH3flwWk9SA54F4TPiQyBOxI6HzWtcGCkYL9V6K77lyQUp7U Xg4ufknrzDLZ0EzoMGyZIP2Q0OpT X-Google-Smtp-Source: AFSGD/VVzNHYbQLoXPXlyuS13j+fOLoWgGLXjw9oZXaPRbGnKjULQnOl+27AU6F0elEfOnK9i9sP9w== X-Received: by 2002:a5d:4202:: with SMTP id n2mr1625552wrq.260.1542713952951; Tue, 20 Nov 2018 03:39:12 -0800 (PST) Received: from localhost.localdomain (ipbcc08c44.dynamic.kabel-deutschland.de. [188.192.140.68]) by smtp.googlemail.com with ESMTPSA id b13sm13007389wrn.28.2018.11.20.03.39.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Nov 2018 03:39:12 -0800 (PST) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 20 Nov 2018 12:38:36 +0100 Message-Id: <20181120113839.4512-2-andreas.rheinhardt@googlemail.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181120113839.4512-1-andreas.rheinhardt@googlemail.com> References: <20181120113839.4512-1-andreas.rheinhardt@googlemail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/4] cbs_h2645: Avoid memcpy when splitting fragment X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Now memcpy is avoided for NAL units that don't contain 0x03 escape characters. Improves performance of cbs_h2645_fragment_add_nals from 36940 decicycles to 6364 decicycles based on 8 runs with a 5.1 Mb/s H.264 sample (262144 runs each). Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h2645.c | 29 +++++++++++++++++------------ libavcodec/h2645_parse.h | 5 +++++ 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index a2d0170e97..6846cad0bb 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -532,24 +532,29 @@ static int cbs_h2645_fragment_add_nals(CodedBitstreamContext *ctx, for (i = 0; i < packet->nb_nals; i++) { const H2645NAL *nal = &packet->nals[i]; size_t size = nal->size; - uint8_t *data; - // Remove trailing zeroes. while (size > 0 && nal->data[size - 1] == 0) --size; av_assert0(size > 0); - data = av_malloc(size + AV_INPUT_BUFFER_PADDING_SIZE); - if (!data) - return AVERROR(ENOMEM); - memcpy(data, nal->data, size); - memset(data + size, 0, AV_INPUT_BUFFER_PADDING_SIZE); + if (nal->data == nal->raw_data) { + err = ff_cbs_insert_unit_data(ctx, frag, -1, nal->type, + (uint8_t*)nal->data, size, frag->data_ref); + if (err < 0) + return err; + } else { + uint8_t *data = av_malloc(size + AV_INPUT_BUFFER_PADDING_SIZE); + if (!data) + return AVERROR(ENOMEM); + memcpy(data, nal->data, size); + memset(data + size, 0, AV_INPUT_BUFFER_PADDING_SIZE); - err = ff_cbs_insert_unit_data(ctx, frag, -1, nal->type, - data, size, NULL); - if (err < 0) { - av_freep(&data); - return err; + err = ff_cbs_insert_unit_data(ctx, frag, -1, nal->type, + data, size, NULL); + if (err < 0) { + av_freep(&data); + return err; + } } } diff --git a/libavcodec/h2645_parse.h b/libavcodec/h2645_parse.h index 2e29ad26cb..a0a5ca5868 100644 --- a/libavcodec/h2645_parse.h +++ b/libavcodec/h2645_parse.h @@ -86,6 +86,11 @@ int ff_h2645_extract_rbsp(const uint8_t *src, int length, H2645RBSP *rbsp, /** * Split an input packet into NAL units. + * If data == raw_data holds true for a NAL unit of the returned pkt, then + * said NAL unit does not contain any emulation_prevention_three_byte and + * the data is contained in the input buffer pointed to by buf. + * Otherwise, the unescaped data is part of the rbsp_buffer described by the + * packet's H2645RBSP. */ int ff_h2645_packet_split(H2645Packet *pkt, const uint8_t *buf, int length, void *logctx, int is_nalff, int nal_length_size,