| Message ID | 20181122003907.12088-1-cus@passwd.hu |
|---|---|
| State | New |
| Headers | show |
On Thu, 22 Nov 2018, Marton Balint wrote: > After finishing the last file all durations and start times should be known. > > Signed-off-by: Marton Balint <cus@passwd.hu> > --- > libavformat/concatdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c > index bbe13136fa..a5883ec66e 100644 > --- a/libavformat/concatdec.c > +++ b/libavformat/concatdec.c > @@ -525,6 +525,7 @@ static int open_next_file(AVFormatContext *avf) > > if (++fileno >= cat->nb_files) { > cat->eof = 1; > + cat->seekable = 1; > return AVERROR_EOF; > } > return open_file(avf, fileno); > -- > 2.16.4 Ping for the series... Thanks, Marton
On Sun, 2 Dec 2018, Marton Balint wrote: > > > On Thu, 22 Nov 2018, Marton Balint wrote: > >> After finishing the last file all durations and start times should be > known. >> >> Signed-off-by: Marton Balint <cus@passwd.hu> >> --- >> libavformat/concatdec.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c >> index bbe13136fa..a5883ec66e 100644 >> --- a/libavformat/concatdec.c >> +++ b/libavformat/concatdec.c >> @@ -525,6 +525,7 @@ static int open_next_file(AVFormatContext *avf) >> >> if (++fileno >= cat->nb_files) { >> cat->eof = 1; >> + cat->seekable = 1; >> return AVERROR_EOF; >> } >> return open_file(avf, fileno); >> -- >> 2.16.4 > > Ping for the series... Will apply soon. Regards, Marton
Marton Balint (2018-12-09):
> Will apply soon.
Sorry, I was busy and it slipped my mind.
I will try hard to have a careful look tomorrow.
Regards,
Marton Balint (2018-11-22): > After finishing the last file all durations and start times should be known. > > Signed-off-by: Marton Balint <cus@passwd.hu> > --- > libavformat/concatdec.c | 1 + > 1 file changed, 1 insertion(+) Ok in principle. I would be more comfortable if some kind of consistency test were added to check the "should", but I do not consider blocking. Regards,
diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index bbe13136fa..a5883ec66e 100644 --- a/libavformat/concatdec.c +++ b/libavformat/concatdec.c @@ -525,6 +525,7 @@ static int open_next_file(AVFormatContext *avf) if (++fileno >= cat->nb_files) { cat->eof = 1; + cat->seekable = 1; return AVERROR_EOF; } return open_file(avf, fileno);
After finishing the last file all durations and start times should be known. Signed-off-by: Marton Balint <cus@passwd.hu> --- libavformat/concatdec.c | 1 + 1 file changed, 1 insertion(+)