| Message ID | 20181228212257.32672-2-michael@niedermayer.cc |
|---|---|
| State | Accepted |
| Commit | 062bf5639359e183e016bcb795ac10735f83e863 |
| Headers | show |
On Fri, Dec 28, 2018 at 22:22:53 +0100, Michael Niedermayer wrote: > - * Reinitializes the V4L2m2mContext when the driver cant continue processing > + * Reinitializes the V4L2m2mContext when the driver cannot continue processing > * with the any of the current V4L2Contexts (ie, changes in output and capture). The line below is also wrong. "with the any of" does not make any sense, and "ie," is very ugly. Suggestion: Reinitializes the V4L2m2mContext when the driver cannot continue processing with any of the current V4L2Contexts (i.e. changes in output and capture). Even with "i.e.", the text in the parantheses doesn't make sense to me. My guess is "ie" meant to be "e.g.". So: Reinitializes the V4L2m2mContext when the driver cannot continue processing with any of the current V4L2Contexts (e.g. changes in output and capture). Gruß, Moritz
On Fri, Dec 28, 2018 at 11:35:52PM +0100, Moritz Barsnick wrote: > On Fri, Dec 28, 2018 at 22:22:53 +0100, Michael Niedermayer wrote: > > - * Reinitializes the V4L2m2mContext when the driver cant continue processing > > + * Reinitializes the V4L2m2mContext when the driver cannot continue processing > > * with the any of the current V4L2Contexts (ie, changes in output and capture). > > The line below is also wrong. "with the any of" does not make any > sense, and "ie," is very ugly. > > Suggestion: > > Reinitializes the V4L2m2mContext when the driver cannot continue processing > with any of the current V4L2Contexts (i.e. changes in output and capture). > > Even with "i.e.", the text in the parantheses doesn't make sense to me. > My guess is "ie" meant to be "e.g.". > > So: > > Reinitializes the V4L2m2mContext when the driver cannot continue processing > with any of the current V4L2Contexts (e.g. changes in output and capture). I agree but this seems unrelated to the typo fix and its your change its better if you commit this instead of it being added into the same commit as the typo fix. also feel free to push trivial changes like mine if you want to work on top of them so they dont hold you up thx [...]
diff --git a/libavcodec/v4l2_m2m.h b/libavcodec/v4l2_m2m.h index 452bf0d9bc..0d4671beb1 100644 --- a/libavcodec/v4l2_m2m.h +++ b/libavcodec/v4l2_m2m.h @@ -104,7 +104,7 @@ int ff_v4l2_m2m_codec_init(AVCodecContext *avctx); int ff_v4l2_m2m_codec_end(AVCodecContext *avctx); /** - * Reinitializes the V4L2m2mContext when the driver cant continue processing + * Reinitializes the V4L2m2mContext when the driver cannot continue processing * with the capture parameters. * * @param[in] ctx The V4L2m2mContext instantiated by the encoder/decoder. @@ -114,7 +114,7 @@ int ff_v4l2_m2m_codec_end(AVCodecContext *avctx); int ff_v4l2_m2m_codec_reinit(V4L2m2mContext *ctx); /** - * Reinitializes the V4L2m2mContext when the driver cant continue processing + * Reinitializes the V4L2m2mContext when the driver cannot continue processing * with the any of the current V4L2Contexts (ie, changes in output and capture). * * @param[in] ctx The V4L2m2mContext instantiated by the encoder/decoder.
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/v4l2_m2m.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)