From patchwork Sun Feb 10 19:46:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 12026 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 36E4444665E for ; Sun, 10 Feb 2019 21:47:23 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2241068A768; Sun, 10 Feb 2019 21:47:23 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 07BB668A2B8 for ; Sun, 10 Feb 2019 21:47:16 +0200 (EET) Received: by mail-wm1-f53.google.com with SMTP id x10so7577412wmg.2 for ; Sun, 10 Feb 2019 11:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=d9+AuwX9i0D+tF9MycvcHMDcjLbjLekwYh3WgpMoNT4=; b=JeaXNA5MnffzJlGllamatOEEs7tTacCeEEEWuzexGikcfkZ7EJ39lt7HkpkrCTXp2L NO76fEG4FsdvlhBEhjYHAk+cbo+ufe0J6chdWPfeZXGGyM2pARnPLnUsjdMX8whcpXvg lqO5UVbIZ0PwRfni0Nc7m+oZk5nI14uJ83oh9rdGvJB+3pNoHMdyHO/1QYt5cEAh720T 5qwt53C7lbS1fG9dx+0t1QgEdq8sUYPYvRzjqJB8QJViuZqT+kTaqywxoXTXnbVzQKUk 921MYAusBZ48Vp7xOWpotPYWQf7Z1B1AhX2sKJLyF7yaOZTmXhiOFeVbd6cSlTZFoulR F37w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d9+AuwX9i0D+tF9MycvcHMDcjLbjLekwYh3WgpMoNT4=; b=r0g+f+K5ThUQbO4J/H51bklCKoxQqoSI32NghxN3Vr/Moxf4v7WFH+qcrSwIHB6x/e DY+5A+OG3+prPbqSK9S58JMDmj7d6a/MAlrGLNthmB7r3e4m0M9geice0pza+fzeX/wQ LTuolafe0C8cZdQU2a5fD8KsL6DubjR0S40b7+SmdPTz5yxO0g0SrkbPsJvcCqb8H69F 3MmgcE/pQmFMgcsAkrmwEnyseWyUDRMIHgs71Zy4prl48CQlRYF5R3+IAXV/xb+wfghs jWicYNL4fUWW0PgPoSvxN+aw4uoAgyTLOqkeL+Oi/plMbH5+3od7UTMLHq3LPyUj2inV e6zg== X-Gm-Message-State: AHQUAua0rVc25osppfxzcOvSBNlCVPDLFsNWFBDTRWA+3+jEtzh5dmgQ YInmFMtHHlnWLR6KVdBlJB5hOv7i8Bt44Q== X-Google-Smtp-Source: AHgI3IYZ6v+7hlKmq3Od6OBI13TxUsISbM6JyrazLcp9uYdctpJw4ur22MZwTejviSExqATxuFidNA== X-Received: by 2002:a5d:4a89:: with SMTP id o9mr16460319wrq.323.1549828035281; Sun, 10 Feb 2019 11:47:15 -0800 (PST) Received: from rywe.jkqxz.net (cpc91242-cmbg18-2-0-cust650.5-4.cable.virginm.net. [82.8.130.139]) by smtp.gmail.com with ESMTPSA id u15sm24059889wrm.63.2019.02.10.11.47.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Feb 2019 11:47:14 -0800 (PST) From: Mark Thompson To: ffmpeg-devel@ffmpeg.org Date: Sun, 10 Feb 2019 19:46:58 +0000 Message-Id: <20190210194705.3598-5-sw@jkqxz.net> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190210194705.3598-1-sw@jkqxz.net> References: <20190210194705.3598-1-sw@jkqxz.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 05/12] vaapi_encode_vp8: Enable support for more RC modes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" --- libavcodec/vaapi_encode_vp8.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavcodec/vaapi_encode_vp8.c b/libavcodec/vaapi_encode_vp8.c index 166636cd84..ddbe4c9075 100644 --- a/libavcodec/vaapi_encode_vp8.c +++ b/libavcodec/vaapi_encode_vp8.c @@ -161,14 +161,15 @@ static int vaapi_encode_vp8_write_quant_table(AVCodecContext *avctx, static av_cold int vaapi_encode_vp8_configure(AVCodecContext *avctx) { + VAAPIEncodeContext *ctx = avctx->priv_data; VAAPIEncodeVP8Context *priv = avctx->priv_data; - priv->q_index_p = av_clip(avctx->global_quality, 0, VP8_MAX_QUANT); + priv->q_index_p = av_clip(ctx->rc_quality, 0, VP8_MAX_QUANT); if (avctx->i_quant_factor > 0.0) - priv->q_index_i = av_clip((avctx->global_quality * - avctx->i_quant_factor + - avctx->i_quant_offset) + 0.5, - 0, VP8_MAX_QUANT); + priv->q_index_i = + av_clip((avctx->i_quant_factor * priv->q_index_p + + avctx->i_quant_offset) + 0.5, + 0, VP8_MAX_QUANT); else priv->q_index_i = priv->q_index_p; @@ -185,6 +186,8 @@ static const VAAPIEncodeType vaapi_encode_type_vp8 = { .configure = &vaapi_encode_vp8_configure, + .default_quality = 40, + .sequence_params_size = sizeof(VAEncSequenceParameterBufferVP8), .init_sequence_params = &vaapi_encode_vp8_init_sequence_params, @@ -215,6 +218,8 @@ static av_cold int vaapi_encode_vp8_init(AVCodecContext *avctx) #define FLAGS (AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM) static const AVOption vaapi_encode_vp8_options[] = { VAAPI_ENCODE_COMMON_OPTIONS, + VAAPI_ENCODE_RC_OPTIONS, + { "loop_filter_level", "Loop filter level", OFFSET(loop_filter_level), AV_OPT_TYPE_INT, { .i64 = 16 }, 0, 63, FLAGS }, { "loop_filter_sharpness", "Loop filter sharpness", @@ -226,7 +231,6 @@ static const AVCodecDefault vaapi_encode_vp8_defaults[] = { { "b", "0" }, { "bf", "0" }, { "g", "120" }, - { "global_quality", "40" }, { "qmin", "-1" }, { "qmax", "-1" }, { NULL },