[FFmpeg-devel,v2,2/2] fate/mxf: add mxf user comments tests

Message ID	20190311202238.72685-2-mindmark@gmail.com
State	Accepted
Commit	7ff89574c78d6d653534477dbd6fa152738819dc
Headers	show Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> From: mindmark@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Mon, 11 Mar 2019 13:22:38 -0700 Message-Id: <20190311202238.72685-2-mindmark@gmail.com> In-Reply-To: <20190311202238.72685-1-mindmark@gmail.com> References: <20190311202238.72685-1-mindmark@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 2/2] fate/mxf: add mxf user comments tests Precedence: list Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: Mark Reid <mindmark@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>

Message ID

20190311202238.72685-2-mindmark@gmail.com

State

Accepted

Commit

7ff89574c78d6d653534477dbd6fa152738819dc

Headers

From: mindmark@gmail.com
To: ffmpeg-devel@ffmpeg.org
Date: Mon, 11 Mar 2019 13:22:38 -0700
Message-Id: <20190311202238.72685-2-mindmark@gmail.com>
In-Reply-To: <20190311202238.72685-1-mindmark@gmail.com>
References: <20190311202238.72685-1-mindmark@gmail.com>
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH v2 2/2] fate/mxf: add mxf user comments tests
Precedence: list
Reply-To: FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Cc: Mark Reid <mindmark@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>

Commit Message

Mark Reid March 11, 2019, 8:22 p.m. UTC

From: Mark Reid <mindmark@gmail.com>

---
 tests/fate/mxf.mak                      | 15 ++++++++++++++-
 tests/ref/fate/mxf-d10-user-comments    |  1 +
 tests/ref/fate/mxf-opatom-user-comments |  1 +
 tests/ref/fate/mxf-user-comments        |  1 +
 4 files changed, 17 insertions(+), 1 deletion(-)
 create mode 100644 tests/ref/fate/mxf-d10-user-comments
 create mode 100644 tests/ref/fate/mxf-opatom-user-comments
 create mode 100644 tests/ref/fate/mxf-user-comments

Comments

Tomas Härdin March 11, 2019, 9:51 p.m. UTC | #1

mån 2019-03-11 klockan 13:22 -0700 skrev mindmark@gmail.com:
> From: Mark Reid <mindmark@gmail.com>
> 
> ---
>  tests/fate/mxf.mak                      | 15 ++++++++++++++-
>  tests/ref/fate/mxf-d10-user-comments    |  1 +
>  tests/ref/fate/mxf-opatom-user-comments |  1 +
>  tests/ref/fate/mxf-user-comments        |  1 +
>  4 files changed, 17 insertions(+), 1 deletion(-)
>  create mode 100644 tests/ref/fate/mxf-d10-user-comments
>  create mode 100644 tests/ref/fate/mxf-opatom-user-comments
>  create mode 100644 tests/ref/fate/mxf-user-comments
> 
> diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak
> index dce23d522e..62e4ec01cb 100644
> --- a/tests/fate/mxf.mak
> +++ b/tests/fate/mxf.mak
> @@ -37,9 +37,22 @@ FATE_MXF_REEL_NAME-$(call ENCDEC2, MPEG2VIDEO,
> PCM_S16LE, MXF) += fate-mxf-reel_
>  fate-mxf-reel_name: $(TARGET_SAMPLES)/mxf/Sony-00001.mxf
>  fate-mxf-reel_name: CMD = md5 -y -i $(TARGET_SAMPLES)/mxf/Sony-
> 00001.mxf  -c copy -timecode 00:00:00:00 -metadata
> "reel_name=test_reel" -fflags +bitexact -f mxf
>  
> +FATE_MXF_USER_COMMENTS-$(call ENCDEC2, MPEG2VIDEO, PCM_S16LE, MXF)
> += fate-mxf-user-comments
> +fate-mxf-user-comments: $(TARGET_SAMPLES)/mxf/Sony-00001.mxf
> +fate-mxf-user-comments: CMD = md5 -y -i $(TARGET_SAMPLES)/mxf/Sony-
> 00001.mxf -c copy -metadata "comment_test=value" -fflags +bitexact -f
> mxf

For a while I thought we could maybe make these tests faster by not
muxing any essence, but the opatom case wouldn't work, and maybe not
the others either. In short: looks OK to me.

/Tomas

Michael Niedermayer March 12, 2019, 9:04 p.m. UTC | #2

On Mon, Mar 11, 2019 at 01:22:38PM -0700, mindmark@gmail.com wrote:
> From: Mark Reid <mindmark@gmail.com>
> 
> ---
>  tests/fate/mxf.mak                      | 15 ++++++++++++++-
>  tests/ref/fate/mxf-d10-user-comments    |  1 +
>  tests/ref/fate/mxf-opatom-user-comments |  1 +
>  tests/ref/fate/mxf-user-comments        |  1 +
>  4 files changed, 17 insertions(+), 1 deletion(-)
>  create mode 100644 tests/ref/fate/mxf-d10-user-comments
>  create mode 100644 tests/ref/fate/mxf-opatom-user-comments
>  create mode 100644 tests/ref/fate/mxf-user-comments

tested on x86-64 and mips qemu

[...]

Michael Niedermayer March 13, 2019, 8:28 a.m. UTC | #3

On Tue, Mar 12, 2019 at 10:04:32PM +0100, Michael Niedermayer wrote:
> On Mon, Mar 11, 2019 at 01:22:38PM -0700, mindmark@gmail.com wrote:
> > From: Mark Reid <mindmark@gmail.com>
> > 
> > ---
> >  tests/fate/mxf.mak                      | 15 ++++++++++++++-
> >  tests/ref/fate/mxf-d10-user-comments    |  1 +
> >  tests/ref/fate/mxf-opatom-user-comments |  1 +
> >  tests/ref/fate/mxf-user-comments        |  1 +
> >  4 files changed, 17 insertions(+), 1 deletion(-)
> >  create mode 100644 tests/ref/fate/mxf-d10-user-comments
> >  create mode 100644 tests/ref/fate/mxf-opatom-user-comments
> >  create mode 100644 tests/ref/fate/mxf-user-comments
> 
> tested on x86-64 and mips qemu

will apply patchset

thx

[...]

diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak
index dce23d522e..62e4ec01cb 100644
--- a/tests/fate/mxf.mak
+++ b/tests/fate/mxf.mak
@@ -37,9 +37,22 @@  FATE_MXF_REEL_NAME-$(call ENCDEC2, MPEG2VIDEO, PCM_S16LE, MXF) += fate-mxf-reel_
 fate-mxf-reel_name: $(TARGET_SAMPLES)/mxf/Sony-00001.mxf
 fate-mxf-reel_name: CMD = md5 -y -i $(TARGET_SAMPLES)/mxf/Sony-00001.mxf  -c copy -timecode 00:00:00:00 -metadata "reel_name=test_reel" -fflags +bitexact -f mxf
 
+FATE_MXF_USER_COMMENTS-$(call ENCDEC2, MPEG2VIDEO, PCM_S16LE, MXF) += fate-mxf-user-comments
+fate-mxf-user-comments: $(TARGET_SAMPLES)/mxf/Sony-00001.mxf
+fate-mxf-user-comments: CMD = md5 -y -i $(TARGET_SAMPLES)/mxf/Sony-00001.mxf -c copy -metadata "comment_test=value" -fflags +bitexact -f mxf
+
+FATE_MXF_D10_USER_COMMENTS-$(call ENCDEC2, MPEG2VIDEO, PCM_S16LE, MXF) += fate-mxf-d10-user-comments
+fate-mxf-d10-user-comments: $(TARGET_SAMPLES)/mxf/Sony-00001.mxf
+fate-mxf-d10-user-comments: CMD = md5 -y -i $(TARGET_SAMPLES)/mxf/Sony-00001.mxf -c copy -metadata "comment_test=value" -store_user_comments 1 -fflags +bitexact -f mxf_d10
+
+FATE_MXF_OPATOM_USER_COMMENTS-$(call ENCDEC2, MPEG2VIDEO, PCM_S16LE, MXF) += fate-mxf-opatom-user-comments
+fate-mxf-opatom-user-comments: $(TARGET_SAMPLES)/mxf/Sony-00001.mxf
+fate-mxf-opatom-user-comments: CMD = md5 -y -i $(TARGET_SAMPLES)/mxf/Sony-00001.mxf -an -vcodec copy -metadata "comment_test=value" -fflags +bitexact -f mxf_opatom
+
 FATE_MXF-$(CONFIG_MXF_DEMUXER) += $(FATE_MXF)
 
 FATE_SAMPLES_AVCONV += $(FATE_MXF-yes) $(FATE_MXF_REEL_NAME-yes)
+FATE_SAMPLES_AVCONV += $(FATE_MXF_USER_COMMENTS-yes) $(FATE_MXF_D10_USER_COMMENTS-yes) $(FATE_MXF_OPATOM_USER_COMMENTS-yes)
 FATE_SAMPLES_FFPROBE += $(FATE_MXF_PROBE-yes)
 
-fate-mxf: $(FATE_MXF-yes) $(FATE_MXF_PROBE-yes) $(FATE_MXF_REEL_NAME-yes)
+fate-mxf: $(FATE_MXF-yes) $(FATE_MXF_PROBE-yes) $(FATE_MXF_REEL_NAME-yes) $(FATE_MXF_USER_COMMENTS-yes) $(FATE_MXF_D10_USER_COMMENTS-yes) $(FATE_MXF_OPATOM_USER_COMMENTS-yes)
diff --git a/tests/ref/fate/mxf-d10-user-comments b/tests/ref/fate/mxf-d10-user-comments
new file mode 100644
index 0000000000..e78765020c
--- /dev/null
+++ b/tests/ref/fate/mxf-d10-user-comments
@@ -0,0 +1 @@ 
+b659c1204f8d04e2a5607af083590dca
diff --git a/tests/ref/fate/mxf-opatom-user-comments b/tests/ref/fate/mxf-opatom-user-comments
new file mode 100644
index 0000000000..1834b9e074
--- /dev/null
+++ b/tests/ref/fate/mxf-opatom-user-comments
@@ -0,0 +1 @@ 
+892cf02e44bf7d61b6d6f01e41db9375
diff --git a/tests/ref/fate/mxf-user-comments b/tests/ref/fate/mxf-user-comments
new file mode 100644
index 0000000000..4b734a0f85
--- /dev/null
+++ b/tests/ref/fate/mxf-user-comments
@@ -0,0 +1 @@ 
+683bacb0105e5bc5bbf46aa430c644d1

[FFmpeg-devel,v2,2/2] fate/mxf: add mxf user comments tests

Commit Message

Comments

Patch