From patchwork Sat Mar 16 01:04:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Li X-Patchwork-Id: 12319 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 34DE6448920 for ; Sat, 16 Mar 2019 03:04:40 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D314689AC1; Sat, 16 Mar 2019 03:04:40 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A95AE680C8F for ; Sat, 16 Mar 2019 03:04:33 +0200 (EET) Received: by mail-pf1-f196.google.com with SMTP id r15so4702539pfn.9 for ; Fri, 15 Mar 2019 18:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=IPm3mdZufimo5J6S5cjf4PAzrs1s0goqoAoyAU4Wh10=; b=HRP+H93keiHUWvC7Onc89vBbCY6/Kw3amLo5KkUYcDU0hGP5gjc0KYK34dOmwZedwJ JhfRd1tYjVIpO3epx0+/8nfnkrC1dTw+cDLgiC8KzqTzPh3x7vYo1xk7etJqW7Jk9K18 6LpKsDrScvaYesJIPr3IuRST7wCA1Q77gqrbPaGgfiscGSXjVf0C9d39AT2A0mVxcdvV yeKCfxJinNSv6A5zMLcpX7s7ndTaAXpR5rcePa2kfM416Hy5iYp+z82qwFo/BReeVa83 FHqCAZ+pUOEVct3OQ/tcZBxFGpTkYl1kjz0DFwLSpKAcTtOIExGRnETFROH68JMlK3/o ZIDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=IPm3mdZufimo5J6S5cjf4PAzrs1s0goqoAoyAU4Wh10=; b=KaDYNg1zk3iLWTtinM0nIbYLycYRFZrjEOq2I3QsSj7qO3PWuOUNIal2ryUJKScnEe Rvp8PVO90NaGbgI1FZzbk47NCenEZBocosbRCb+ZQfV4Y9l9gMWiFp6sNa1eR9f8MtPZ 2UyBZ3+8hv3XN1H7eej13UGxsLG9g6/zwuwp/lYgIHemyxpcFuxnXPQmOLilf0zuh9+R dSgTod7jmMXuZlo2KPPrWSx23kqHav2ZtUNf3tL/1udp8RWYPUvJt+EyH0gVQBF/X6mH Vh8Ln+HGMQV0L7EkP8DlTVH5pLd6QsrT9r+rTHqTaskXF4DS0fFakrEa2LbMHduVuY7M Uu7A== X-Gm-Message-State: APjAAAV9G1P9DSGl043P39yB8GX0rBXJbwjGIs4jvxRRcCXMmZfc31e3 ylaXil3cdWtbHzG350w8VGu1Le+0 X-Google-Smtp-Source: APXvYqyYVvciwxUZvQp6FqFzKFFZpC16j3B13NwzXKTUH9CvyM/pcG12MyHGstUJnDHC44oJDCHMdw== X-Received: by 2002:a17:902:8d8b:: with SMTP id v11mr7303431plo.241.1552698270903; Fri, 15 Mar 2019 18:04:30 -0700 (PDT) Received: from jun-ubuntu.corp.microsoft.com ([2001:4898:80e8:b:2437:7fe7:9adf:4955]) by smtp.googlemail.com with ESMTPSA id p6sm4300567pgd.69.2019.03.15.18.04.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 18:04:29 -0700 (PDT) From: Jun Li To: ffmpeg-devel@ffmpeg.org Date: Fri, 15 Mar 2019 18:04:23 -0700 Message-Id: <20190316010423.25985-1-junli1026@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH v5] avformat/smoothstreamingenc:add bitrate calculate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Calculate bitrate based on fragment size, only applied when bitrate is not set, for example rtsp source. Signed-off-by: Jun Li --- libavformat/smoothstreamingenc.c | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c index 094712af27..bd7f841dc7 100644 --- a/libavformat/smoothstreamingenc.c +++ b/libavformat/smoothstreamingenc.c @@ -320,11 +320,13 @@ static int ism_write_header(AVFormatContext *s) AVDictionary *opts = NULL; if (!s->streams[i]->codecpar->bit_rate) { - av_log(s, AV_LOG_ERROR, "No bit rate set for stream %d\n", i); - ret = AVERROR(EINVAL); - goto fail; + av_log(s, AV_LOG_WARNING, "No bit rate set for stream %d\n", i); + // create a tmp name for the directory of fragments + snprintf(os->dirname, sizeof(os->dirname), "%s/QualityLevels(Tmp_%d)", s->url, i); + } else { + snprintf(os->dirname, sizeof(os->dirname), "%s/QualityLevels(%"PRId64")", s->url, s->streams[i]->codecpar->bit_rate); } - snprintf(os->dirname, sizeof(os->dirname), "%s/QualityLevels(%"PRId64")", s->url, s->streams[i]->codecpar->bit_rate); + if (mkdir(os->dirname, 0777) == -1 && errno != EEXIST) { ret = AVERROR(errno); av_log(s, AV_LOG_ERROR, "mkdir failed\n"); @@ -519,7 +521,7 @@ static int ism_flush(AVFormatContext *s, int final) for (i = 0; i < s->nb_streams; i++) { OutputStream *os = &c->streams[i]; - char filename[1024], target_filename[1024], header_filename[1024]; + char filename[1024], target_filename[1024], header_filename[1024], curr_dirname[1024]; int64_t size; int64_t start_ts, duration, moof_size; if (!os->packets_written) @@ -541,6 +543,26 @@ static int ism_flush(AVFormatContext *s, int final) size = os->tail_pos - os->cur_start_pos; if ((ret = parse_fragment(s, filename, &start_ts, &duration, &moof_size, size)) < 0) break; + + if (!s->streams[i]->codecpar->bit_rate) { + int64_t bitrate = (int64_t) size * 8 * AV_TIME_BASE / av_rescale_q(duration, s->streams[i]->time_base, AV_TIME_BASE_Q); + if (!bitrate) { + av_log(s, AV_LOG_ERROR, "calculating bitrate got zero.\n"); + ret = AVERROR(EINVAL); + return ret; + } + + av_log(s, AV_LOG_DEBUG, "calculated bitrate: %"PRId64"\n", bitrate); + s->streams[i]->codecpar->bit_rate = bitrate; + memcpy(curr_dirname, os->dirname, sizeof(os->dirname)); + snprintf(os->dirname, sizeof(os->dirname), "%s/QualityLevels(%"PRId64")", s->url, s->streams[i]->codecpar->bit_rate); + snprintf(filename, sizeof(filename), "%s/temp", os->dirname); + + // rename the tmp folder back to the correct name since we now have the bitrate + if ((ret = ff_rename((const char*)curr_dirname, os->dirname, s)) < 0) + return ret; + } + snprintf(header_filename, sizeof(header_filename), "%s/FragmentInfo(%s=%"PRIu64")", os->dirname, os->stream_type_tag, start_ts); snprintf(target_filename, sizeof(target_filename), "%s/Fragments(%s=%"PRIu64")", os->dirname, os->stream_type_tag, start_ts); copy_moof(s, filename, header_filename, moof_size);