diff mbox

[FFmpeg-devel] h2645_parse: Fix loglevel for NAL header parsing

Message ID 20190318191906.5175-1-derek.buitenhuis@gmail.com
State Accepted
Commit 90b85ab21fcb2895d4cf25527179ea0fa5f08ec0
Headers show

Commit Message

Derek Buitenhuis March 18, 2019, 7:19 p.m. UTC
We don't treat this as an error.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 libavcodec/h2645_parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Almer March 18, 2019, 8:33 p.m. UTC | #1
On 3/18/2019 4:19 PM, Derek Buitenhuis wrote:
> We don't treat this as an error.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
>  libavcodec/h2645_parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c
> index 942f2c5d71..24658b3dfa 100644
> --- a/libavcodec/h2645_parse.c
> +++ b/libavcodec/h2645_parse.c
> @@ -499,7 +499,7 @@ int ff_h2645_packet_split(H2645Packet *pkt, const uint8_t *buf, int length,
>              ret = h264_parse_nal_header(nal, logctx);
>          if (ret <= 0 || nal->size <= 0 || nal->size_bits <= 0) {
>              if (ret < 0) {
> -                av_log(logctx, AV_LOG_ERROR, "Invalid NAL unit %d, skipping.\n",
> +                av_log(logctx, AV_LOG_WARNING, "Invalid NAL unit %d, skipping.\n",
>                         nal->type);
>              }
>              pkt->nb_nals--;

LGTM
Michael Niedermayer March 18, 2019, 9 p.m. UTC | #2
On Mon, Mar 18, 2019 at 07:19:06PM +0000, Derek Buitenhuis wrote:
> We don't treat this as an error.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
>  libavcodec/h2645_parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c
> index 942f2c5d71..24658b3dfa 100644
> --- a/libavcodec/h2645_parse.c
> +++ b/libavcodec/h2645_parse.c
> @@ -499,7 +499,7 @@ int ff_h2645_packet_split(H2645Packet *pkt, const uint8_t *buf, int length,
>              ret = h264_parse_nal_header(nal, logctx);
>          if (ret <= 0 || nal->size <= 0 || nal->size_bits <= 0) {
>              if (ret < 0) {
> -                av_log(logctx, AV_LOG_ERROR, "Invalid NAL unit %d, skipping.\n",
> +                av_log(logctx, AV_LOG_WARNING, "Invalid NAL unit %d, skipping.\n",
>                         nal->type);
>              }
>              pkt->nb_nals--;

LGTM

thx

[...]
diff mbox

Patch

diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c
index 942f2c5d71..24658b3dfa 100644
--- a/libavcodec/h2645_parse.c
+++ b/libavcodec/h2645_parse.c
@@ -499,7 +499,7 @@  int ff_h2645_packet_split(H2645Packet *pkt, const uint8_t *buf, int length,
             ret = h264_parse_nal_header(nal, logctx);
         if (ret <= 0 || nal->size <= 0 || nal->size_bits <= 0) {
             if (ret < 0) {
-                av_log(logctx, AV_LOG_ERROR, "Invalid NAL unit %d, skipping.\n",
+                av_log(logctx, AV_LOG_WARNING, "Invalid NAL unit %d, skipping.\n",
                        nal->type);
             }
             pkt->nb_nals--;