From patchwork Mon Apr 8 12:14:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diego Felix de Souza via ffmpeg-devel X-Patchwork-Id: 12643 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 710D24494A0 for ; Mon, 8 Apr 2019 15:14:38 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4867768A931; Mon, 8 Apr 2019 15:14:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f201.google.com (mail-qt1-f201.google.com [209.85.160.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 04C9E68A713 for ; Mon, 8 Apr 2019 15:14:31 +0300 (EEST) Received: by mail-qt1-f201.google.com with SMTP id n13so12413219qtn.6 for ; Mon, 08 Apr 2019 05:14:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=TEXJFjmMrlOnTAzMOtGejL8C3QX9+tJGFo5E13spyoI=; b=EkUrOX+zyWytUL/FblplN4lfVbOvlMH68qWpwajWGt281kOmRvaQ8bgBFMvimWtGQ9 MfY3yDRMZiW8oJSpKM9BxF1E6GMlyQEzrYp28CkdpU+MvP3aYcDjk+GDtaw1ZTDyPhbP ufjZTidtW2H5kczmN/5mhOP/GFSm2jzIuy3jzmPR059tpEGcVYUPbTIWI0CZ27wtVc8W I2QQXeUERPV0HeIAJo3GrstAVeM8PpWYu1IXLr8ksPyxZVa03LhdfxF1qIZWWFqV9Jjo 94fCWfXn09CthDI2+PDH00u59wA6fX5sH7o9k9O95clObp2DcstRzGO0HPSWs8Cg0h3k jOFQ== X-Gm-Message-State: APjAAAUIUrtACJgZ9Ms+eeytzTqMQnDKgYcbXw0ZvzOuN/gCed7ykZqq YTawPGlhNcs9TllLAKUQi3PWHQKlgVNK0RzMV0QwuHV+dENo4dsSEe2vMU+eoVzX9yHgjR0XJUc pQ02sqRgEEonf3bP7I0o/ci7BBUlKnb6Ay9jNpT4rrjY6fsGbExHPtjJJjhd9BHRVHmLB X-Google-Smtp-Source: APXvYqxQQLDHLOTWJLu9JsfHLIR0N7PK0AEw/4PfSvyRE1Y+GA7MJWbIAylycjwX0Z6MRkCc45q7qqfOaxyQvQ== X-Received: by 2002:ac8:28d5:: with SMTP id j21mr3703513qtj.4.1554725670324; Mon, 08 Apr 2019 05:14:30 -0700 (PDT) Date: Mon, 8 Apr 2019 08:14:27 -0400 Message-Id: <20190408121427.196572-1-jdorfman@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avformat/av1: Initialize padding in ff_isom_write_av1c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jeremy Dorfman via ffmpeg-devel From: Diego Felix de Souza via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Jeremy Dorfman Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Otherwise, AV1 encodes with FFmpeg trigger use-of-uninitialized-value warnings under MemorySanitizer, and the output buffer potentially changes from run to run. --- libavformat/av1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/av1.c b/libavformat/av1.c index a0aad436a6..5fde8df97e 100644 --- a/libavformat/av1.c +++ b/libavformat/av1.c @@ -372,6 +372,7 @@ int ff_isom_write_av1c(AVIOContext *pb, const uint8_t *buf, int size) put_bits(&pbc, 1, seq_params.chroma_subsampling_x); put_bits(&pbc, 1, seq_params.chroma_subsampling_y); put_bits(&pbc, 2, seq_params.chroma_sample_position); + put_bits(&pbc, 8, 0); // padding flush_put_bits(&pbc); avio_write(pb, header, sizeof(header));