From patchwork Fri Jun 21 14:41:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Derek Buitenhuis X-Patchwork-Id: 13665 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 9F5D0449AD6 for ; Fri, 21 Jun 2019 17:41:36 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 872BF68AB12; Fri, 21 Jun 2019 17:41:36 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 52DA968AAC7 for ; Fri, 21 Jun 2019 17:41:30 +0300 (EEST) Received: by mail-wr1-f65.google.com with SMTP id p11so6829260wre.7 for ; Fri, 21 Jun 2019 07:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=VAlMlk5tdWH44VxSMp3nbz3fVu85nNaj+Cac5mMmlMA=; b=agBDMqN4Yeglv5GdtszuSWgt/XCshVAFzQIDysTbDuWKohlO3hQ8xHI+M0+zoze5yL qv9et2JiCqpVLFU3YryZEIohDFB+EbLwoA0vKHrGwXxWEaSd7kcaDUwMKFMcRRUO85Tt kEGB+vRj+mQlFUzrAny+D+PoPyioY9N8hOyr8mnoHk7qwaB7Ie8482wGd4ns8Ing1DR0 ZatgYhC9adjkBQ4yWT4Ib66NAyYWGtrFTKlfs4NB0Ckd53s3mMDxKbjxXH4+hYDlgDmB Fq1rA44rHirv2pp0r917uO2JKCVTy7Vrbjhx2RNBV3ZbBOY9tmCvmpD1P3Q+epVHId78 FL2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=VAlMlk5tdWH44VxSMp3nbz3fVu85nNaj+Cac5mMmlMA=; b=IQqTlNMFxShQ+5Q10UV+APNLjij3x18SioihCjsFI8vGuBNptpI9Y6VbutRNB/1ly7 VaAvZSPRqtd1x2JA7LrbGUKEPqxqZ7iUJc2GFSJgv6D1y+zEcOByUvlQ0nNmxVZxlAAN C3Y1QtWUorw2+sXGbc32oDT0XdMYsJrG46yUbDmFB1MFtIYodo+bSG9q2LIq6TDrgPD8 35es932x4LvGI0MrpuJ/plTbxlTw/3HJGsPPEqlNyjD+/5g2OAPQwUrf6Ms+aVHVX39f xTUBsdyUH4S52QxOr+U1UbXn+esT0l09CATSXkKuzwHPRNT0W0bVXBEsQuMG/PK8FT9o e2qQ== X-Gm-Message-State: APjAAAUkPAIqN5FG4gWbOz7SGUu0oQJH9WeVvofQwtuXcFCZo7FqAayt ER1trk5oYtsE0EXiP61yMk4K22Cv X-Google-Smtp-Source: APXvYqwDSO6RagaD30w+pVF5kMFEYpvKmt9MHRGft82pcVs6jH3lATtYHgAI9rY2RycAE8VxUqWhpg== X-Received: by 2002:a5d:4949:: with SMTP id r9mr36986704wrs.289.1561128089743; Fri, 21 Jun 2019 07:41:29 -0700 (PDT) Received: from localhost.localdomain ([82.129.87.116]) by smtp.gmail.com with ESMTPSA id o12sm3021972wrx.63.2019.06.21.07.41.28 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 21 Jun 2019 07:41:29 -0700 (PDT) From: Derek Buitenhuis To: ffmpeg-devel@ffmpeg.org Date: Fri, 21 Jun 2019 15:41:19 +0100 Message-Id: <20190621144119.21603-1-derek.buitenhuis@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3] ffprobe: Fix memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" This packet was not necessarily unreferenced. Signed-off-by: Derek Buitenhuis --- fftools/ffprobe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 3becb6330e..5aaddb0308 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2429,9 +2429,7 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile, } av_packet_unref(&pkt); } - av_init_packet(&pkt); - pkt.data = NULL; - pkt.size = 0; + av_packet_unref(&pkt); //Flush remaining frames that are cached in the decoder for (i = 0; i < fmt_ctx->nb_streams; i++) { pkt.stream_index = i;