From patchwork Thu Jul 4 13:43:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Bouron X-Patchwork-Id: 13817 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 4B840448C7F for ; Thu, 4 Jul 2019 16:52:43 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3407E68ABEC; Thu, 4 Jul 2019 16:52:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D4E5468ABE9 for ; Thu, 4 Jul 2019 16:52:36 +0300 (EEST) Received: by mail-wm1-f48.google.com with SMTP id f17so6263157wme.2 for ; Thu, 04 Jul 2019 06:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FM+ib7LU1QgK1HsbQ1rixP6bgvWALX7ipKWJTZyA/qw=; b=SIP8P90jbHC0615JZJPgc7bQ42D98CaKsY1EGObp4A3VTn9ReUicQ+m0wddQ9EXf3v J2Yh5+Lm3zGDsyIMNmFRck2KwsY8YCJM7vXeV2Jq0nyfIYEIDVPzcZuyFUMV34xDWVyx XhJ8mr10lEgA93LXp4uzZWUqqEth20a4qzqrlDYV40cc8D1TKdu2/IvCG7bwffjIHFUa sDPpyPgYnpXXJ3H8r8Ss1W4LZPIxHGLkO2Q1MngqEvqjjbHwCT0oyMS+/PCzQu24QOfg RT30Z2E0tLj/2khkIo5VjZsB/uUn5hIHzvJbeIeh/AhwJxkMSkTpxSUA1uccpGtPVqqN RKBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FM+ib7LU1QgK1HsbQ1rixP6bgvWALX7ipKWJTZyA/qw=; b=J25yPnK8+l2qWYN/L3GPQfcs0/nQPrgooT8SI6neuB+Cb9JgO+e4+VEqsExfwqeNFs Q0t9fFe4fih2OmQn3aAh3q93cRUenjWW52gx/e6JpY6cU7Vf4l4nqN4Ju8XWhDlZJg0f K+Z+ywJzfxH19mTnQclKHDunC9rKZx+i6j2jKssWhIVOv0/YCLjjbZE2GIxQ2PxZwHiq LXienZ70sjDNZbq1JEWo2GALDqDXm6sfVa9NXmlEGaDNpMimGrogrhDFhw7SWNGXX3T6 4726fmOGcw/p394nlBUWWPWM0UHXp6ZMbRn1nNsjsyX3lRMCDvXFXf6HflQiCiW4G+Ho wy0A== X-Gm-Message-State: APjAAAUnMAZ5XoL+8kH8Gc88eRhjc///sf87DFL8QcgqcUEPO+fCojUP ctzgFIQiVVanCebbEQdKDZHzEWAG X-Google-Smtp-Source: APXvYqxp+AQ8Nt8XSU3mT4PKkaBcwBIo6kBKBhGowiK5GkjbuLZHt1TkLYFLfqkcHXkOIRZpHbb+ZA== X-Received: by 2002:a1c:9696:: with SMTP id y144mr12742054wmd.73.1562247860728; Thu, 04 Jul 2019 06:44:20 -0700 (PDT) Received: from boken.gopro.lcl (73.136-14-84.ripe.coltfrance.com. [84.14.136.73]) by smtp.gmail.com with ESMTPSA id o7sm1440835wmc.36.2019.07.04.06.44.20 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 06:44:20 -0700 (PDT) From: Matthieu Bouron To: ffmpeg-devel@ffmpeg.org Date: Thu, 4 Jul 2019 15:43:46 +0200 Message-Id: <20190704134348.6071-2-matthieu.bouron@gmail.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190704134348.6071-1-matthieu.bouron@gmail.com> References: <20190704134348.6071-1-matthieu.bouron@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/4] avcodec/mediacodec_wrapper: fix a local reference leak in ff_AMediaCodec_getName() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Matthieu Bouron Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" --- libavcodec/mediacodec_wrapper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index a024e3bdb1..e2df07cb41 100644 --- a/libavcodec/mediacodec_wrapper.c +++ b/libavcodec/mediacodec_wrapper.c @@ -1337,6 +1337,10 @@ char *ff_AMediaCodec_getName(FFAMediaCodec *codec) ret = ff_jni_jstring_to_utf_chars(env, name, codec); fail: + if (name) { + (*env)->DeleteLocalRef(env, name); + } + return ret; }