diff mbox

[FFmpeg-devel,09/13] avformat/realtextdec: Check for duplicate extradata in realtext_read_header()

Message ID 20190804164416.23266-9-michael@niedermayer.cc
State Accepted
Commit 652ea23cb34bc59b38c0088865600e2b86079815
Headers show

Commit Message

Michael Niedermayer Aug. 4, 2019, 4:44 p.m. UTC 
Fixes: memleak
Fixes: 16140/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5684008052064256

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/realtextdec.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox

Patch

diff --git a/libavformat/realtextdec.c b/libavformat/realtextdec.c
index e12871e6ad..204e557aa2 100644
--- a/libavformat/realtextdec.c
+++ b/libavformat/realtextdec.c
@@ -87,6 +87,10 @@  static int realtext_read_header(AVFormatContext *s)
             /* save header to extradata */
             const char *p = ff_smil_get_attr_ptr(buf.str, "duration");
 
+            if (st->codecpar->extradata) {
+                res = AVERROR_INVALIDDATA;
+                goto end;
+            }
             if (p)
                 duration = read_ts(p);
             st->codecpar->extradata = av_strdup(buf.str);